Skip to contentSkip to conversation

help conform gasket page table to style

PATCH In review Robert Deal 2 participants 2 messages Nov 12, 2018 Staging

lore
Share & tools
lore

Robert Deal

author
#0 lore raw

PATCH 1/1 help conform gasket page table to style

Formating arguments in gasket_page_table.c functions to conform to the kernel style.

This is my first patch and I apologise in advance if this email and or patch is not correct, or if i sent it to the wrong maintainers.

Signed-off-by Robert Deal <[email protected]>
---
 drivers/staging/gasket/gasket_page_table.c | 24 ++++++++++------------
 1 file changed, 11 insertions(+), 13 deletions(-)
drivers/staging/gasket/gasket_page_table.c +11 -13
index f5253ba9a430..26755d9ca41d 100644
@@ -1088,9 +1088,9 @@ void gasket_page_table_reset(struct gasket_page_table *pg_tbl)
 }
 
 /* See gasket_page_table.h for description. */
-int gasket_page_table_lookup_page(
-	struct gasket_page_table *pg_tbl, ulong dev_addr, struct page **ppage,
-	ulong *poffset)
+int gasket_page_table_lookup_page(struct gasket_page_table *pg_tbl,
+				  ulong dev_addr, struct page **ppage,
+				  ulong *poffset)
 {
 	uint page_num;
 	struct gasket_page_table_entry *pte;

@@ -1134,9 +1134,9 @@ int gasket_page_table_lookup_page(
 }
 
 /* See gasket_page_table.h for description. */
-bool gasket_page_table_are_addrs_bad(
-	struct gasket_page_table *pg_tbl, ulong host_addr, ulong dev_addr,
-	ulong bytes)
+bool gasket_page_table_are_addrs_bad(struct gasket_page_table *pg_tbl,
+				     ulong host_addr, ulong dev_addr,
+				     ulong bytes)
 {
 	if (host_addr & (PAGE_SIZE - 1)) {
 		dev_err(pg_tbl->device,

@@ -1150,8 +1150,8 @@ bool gasket_page_table_are_addrs_bad(
 EXPORT_SYMBOL(gasket_page_table_are_addrs_bad);
 
 /* See gasket_page_table.h for description. */
-bool gasket_page_table_is_dev_addr_bad(
-	struct gasket_page_table *pg_tbl, ulong dev_addr, ulong bytes)
+bool gasket_page_table_is_dev_addr_bad(struct gasket_page_table *pg_tbl,
+				       ulong dev_addr, ulong bytes)
 {
 	uint num_pages = bytes / PAGE_SIZE;
 

@@ -1226,9 +1226,8 @@ int gasket_page_table_system_status(struct gasket_page_table *page_table)
 }
 
 /* Record the host_addr to coherent dma memory mapping. */
-int gasket_set_user_virt(
-	struct gasket_dev *gasket_dev, u64 size, dma_addr_t dma_address,
-	ulong vma)
+int gasket_set_user_virt(struct gasket_dev *gasket_dev, u64 size,
+			 dma_addr_t dma_address, ulong vma)
 {
 	int j;
 	struct gasket_page_table *pg_tbl;

@@ -1346,8 +1345,7 @@ int gasket_free_coherent_memory(struct gasket_dev *gasket_dev, u64 size,
 }
 
 /* Release all coherent memory. */
-void gasket_free_coherent_memory_all(
-	struct gasket_dev *gasket_dev, u64 index)
+void gasket_free_coherent_memory_all(struct gasket_dev *gasket_dev, u64 index)
 {
 	if (!gasket_dev->page_table[index])
 		return;
Signature · 1 line
2.17.1
maintainer
#1 lore raw
Quoted 5 lines · Robert Deal

Formating arguments in gasket_page_table.c functions to conform to the kernel style.

This is my first patch and I apologise in advance if this email and or patch is not correct, or if i sent it to the wrong maintainers.

No need to put this paragraph in the middle of the changelog text :)

Also, use scripts/get_maintainer.pl, it will tell you who to send it to, including what mailing list(s).

And finally, fix up your subject: line to look more like the same way the other patches are for this file.

Can you fix that all up and resend it?

thanks,

greg k-h