Skip to contentSkip to conversation

s390/cio: Fix cleanup of pfn_array alloc failure

GIT PULL Cornelia Huck 1 participant 1 message Nov 13, 2018

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

From: Eric Farman <[email protected]>

If pfn_array_alloc fails somehow, we need to release the pfn_array_table that was malloc'd earlier.

Message-Id: <[email protected]>

---
 drivers/s390/cio/vfio_ccw_cp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/s390/cio/vfio_ccw_cp.c +1 -1
index fd77e46eb3b2..ef5ab45d94b3 100644
@@ -528,7 +528,7 @@ static int ccwchain_fetch_direct(struct ccwchain *chain,
 
 	ret = pfn_array_alloc_pin(pat->pat_pa, cp->mdev, ccw->cda, ccw->count);
 	if (ret < 0)
-		goto out_init;
+		goto out_unpin;
 
 	/* Translate this direct ccw to a idal ccw. */
 	idaws = kcalloc(ret, sizeof(*idaws), GFP_DMA | GFP_KERNEL);
Signature · 1 line
2.17.2