s390/cio: Fix cleanup when unsupported IDA format is used
Subsystems (3)
From: Eric Farman <[email protected]>
Direct returns from within a loop are rude, but it doesn't mean it gets to avoid releasing the memory acquired beforehand.
Signed-off-by Eric Farman <[email protected]>
Message-Id: <[email protected]>
Reviewed-by Farhan Ali <[email protected]>
Reviewed-by Pierre Morel <[email protected]>
Acked-by Halil Pasic <[email protected]>
Signed-off-by Cornelia Huck <[email protected]>
--- drivers/s390/cio/vfio_ccw_cp.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/s390/cio/vfio_ccw_cp.c +3 -1
@@ -387,8 +387,10 @@ static int ccwchain_calc_length(u64 iova, struct channel_program *cp)* orb specified one of the unsupported formats, we defer * checking for IDAWs in unsupported formats to here. */ -if ((!cp->orb.cmd.c64 || cp->orb.cmd.i2k) &&ccw_is_idal (ccw)) +if ((!cp->orb.cmd.c64 || cp->orb.cmd.i2k) &&ccw_is_idal (ccw)) { +kfree (p);return -EOPNOTSUPP ; + }if ((!ccw_is_chain (ccw)) && (!ccw_is_tic (ccw)))break ;
Signature · 1 line
2.17.2