hwmon (lm63) Do not overwrite data->kind
Guenter Roeck
maintainerQuoted 4 lines · Nicolin Chen
According to the code right before the removed line,
data->kindshould be either from DT or from id pointer. So there shouldn't be an additional overwriting after the if-else statement.
Quoted 8 lines
So this patch just removes the overwriting line.
Signed-off-by Nicolin Chen <[email protected]>---
Guenter,
I have not really tested this change but still sent it out since it looks obvious. Please feel free to drop it if you have concern at an untested change. Thanks.
Good find. You are right, the patch introducing the DT code didn't really do anything. Given that no one (including me) noticed that commit b25f663b91f1a was effectively a no-op, I'll queue this up for the next kernel release.
Thanks,
Guenter
Quoted 19 lines
drivers/hwmon/lm63.c | 1 - 1 file changed, 1 deletion(-)drivers/hwmon/lm63.c +0
-1@@ -1120,7 +1120,6 @@ static int lm63_probe(struct i2c_client *client, data->kind = (enum chips )of_device_get_match_data (&client->dev); else data->kind = id->driver_data; - data->kind = id->driver_data;if (data->kind == lm64) data->temp2_offset =16000 ;Signature · 1 line
2.17.1