Skip to contentSkip to conversation

u-boot: Add mkenvimage tool

PATCH Superseded Alexey Brodkin 4 participants 5 messages Nov 15, 2018 Synopsys ARC architecture

v2 of 7 Superseded Latest is v7 →

lore
Share & tools
lore

Alexey Brodkin

author
#0 lore raw

PATCH v2 1/1 u-boot: Add mkenvimage tool

This utility is used for creation of images containing usable in run-time U-Boot environment.

Note it is already gets built with "make tools" command together with "mkimage" so we just need to install "mkenvimage".

As of today this utility is added per-board like here [1] for Intel Edison board.

[1] http://git.yoctoproject.org/cgit/cgit.cgi/meta-intel-edison/tree/meta-intel-edison-bsp/recipes-bsp/u-boot/u-boot-tools_2014.04.bb

Signed-off-by Alexey Brodkin <abrodkin at synopsys.com>
Cc Richard Purdie <richard.purdie at linuxfoundation.org>
Cc Otavio Salvador <otavio at ossystems.com.br>
Cc Martin Jansa <martin.jansa at gmail.com>
Cc Ross Burton <ross.burton at intel.com>
Cc Marek Vasut <marex at denx.de>

---

Chnages v1 -> v2:

* Got rid of a separate recipe and instead added mkenvimage to u-boot mkimage recipy

 meta/recipes-bsp/u-boot/u-boot-mkimage_2018.07.bb | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)
meta/recipes-bsp/u-boot/u-boot-mkimage_2018.07.bb +7 -1
index 08bff1d161..8a8a1ed449 100644
@@ -1,6 +1,6 @@
 require u-boot-common_${PV}.inc
 
-SUMMARY = "U-Boot bootloader image creation tool"
+SUMMARY = "U-Boot bootloader environment & image creation tools"
 DEPENDS += "openssl"
 
 EXTRA_OEMAKE_class-target = 'CROSS_COMPILE="${TARGET_PREFIX}" CC="${CC} ${CFLAGS} ${LDFLAGS}" HOSTCC="${BUILD_CC} ${BUILD_CFLAGS} ${BUILD_LDFLAGS}" STRIP=true V=1'

@@ -20,8 +20,14 @@ do_compile () {
 
 do_install () {
 	install -d ${D}${bindir}
+
+	# mkimage
 	install -m 0755 tools/mkimage ${D}${bindir}/uboot-mkimage
 	ln -sf uboot-mkimage ${D}${bindir}/mkimage
+
+	# mkenvimage
+	install -m 0755 tools/mkenvimage ${D}${bindir}/uboot-mkenvimage
+	ln -sf uboot-mkenvimage ${D}${bindir}/mkenvimage
 }
 
 RDEPENDS_${PN} += "dtc"
Signature · 1 line
2.16.2
#1 lore raw

PATCH v2 1/1 u-boot: Add mkenvimage tool

Quoted 44 lines · Alexey Brodkin

This utility is used for creation of images containing usable in run-time U-Boot environment.

Note it is already gets built with "make tools" command together with "mkimage" so we just need to install "mkenvimage".

As of today this utility is added per-board like here [1] for Intel Edison board.

[1] http://git.yoctoproject.org/cgit/cgit.cgi/meta-intel-edison/tree/meta-intel-edison-bsp/recipes-bsp/u-boot/u-boot-tools_2014.04.bb

Signed-off-by Alexey Brodkin <abrodkin at synopsys.com>
Cc Richard Purdie <richard.purdie at linuxfoundation.org>
Cc Otavio Salvador <otavio at ossystems.com.br>
Cc Martin Jansa <martin.jansa at gmail.com>
Cc Ross Burton <ross.burton at intel.com>
Cc Marek Vasut <marex at denx.de>

---

Chnages v1 -> v2:

* Got rid of a separate recipe and instead added mkenvimage to u-boot mkimage recipy

 meta/recipes-bsp/u-boot/u-boot-mkimage_2018.07.bb | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)
meta/recipes-bsp/u-boot/u-boot-mkimage_2018.07.bb +2 -1
index 08bff1d161..8a8a1ed449 100644
@@ -1,6 +1,6 @@
 require u-boot-common_${PV}.inc
 
-SUMMARY = "U-Boot bootloader image creation tool"
+SUMMARY = "U-Boot bootloader environment & image creation tools"
 DEPENDS += "openssl"
 
 EXTRA_OEMAKE_class-target = 'CROSS_COMPILE="${TARGET_PREFIX}" CC="${CC} ${CFLAGS} ${LDFLAGS}" HOSTCC="${BUILD_CC} ${BUILD_CFLAGS} ${BUILD_LDFLAGS}" STRIP=true V=1'

@@ -20,8 +20,14 @@ do_compile () {
 
 do_install () {
 	install -d ${D}${bindir}
+

meta/recipes-bsp/u-boot/u-boot-mkimage_2018.07.bb do_compile () { · line 33

Quoted 10 lines
meta/recipes-bsp/u-boot/u-boot-mkimage_2018.07.bb +5 -0
+	# mkimage
 	install -m 0755 tools/mkimage ${D}${bindir}/uboot-mkimage
 	ln -sf uboot-mkimage ${D}${bindir}/mkimage
+
+	# mkenvimage
+	install -m 0755 tools/mkenvimage ${D}${bindir}/uboot-mkenvimage
+	ln -sf uboot-mkenvimage ${D}${bindir}/mkenvimage
 }
 
 RDEPENDS_${PN} += "dtc"

I have to admit, the recipe name becomes a misnomer then. But renaming this recipe would be hard, since it's used all over the place. Any ideas?

Signature · 2 lines
Best regards,
Marek Vasut
#2 lore raw

PATCH v2 1/1 u-boot: Add mkenvimage tool

Quoted 2 lines · Marek Vasut

I have to admit, the recipe name becomes a misnomer then. But renaming this recipe would be hard, since it's used all over the place. Any ideas?

Call it u-boot-tools, potentially merge the other recipe tool, and add RPROVIDES for compatibility?

Ross

#3 lore raw

PATCH v2 1/1 u-boot: Add mkenvimage tool

Quoted 6 lines · Ross
Quoted 2 lines · Marek Vasut

I have to admit, the recipe name becomes a misnomer then. But renaming this recipe would be hard, since it's used all over the place. Any ideas?

Call it u-boot-tools, potentially merge the other recipe tool, and add RPROVIDES for compatibility?

Ah :-)

I wonder if it'd make sense to have this new recipe generate multiple packages, one per tool ?

Signature · 2 lines
Best regards,
Marek Vasut
#4 lore raw

PATCH v2 1/1 u-boot: Add mkenvimage tool

In reply to Burton, Ross
Quoted 9 lines · Ross
Quoted 4 lines · Marek Vasut

I have to admit, the recipe name becomes a misnomer then. But renaming
this recipe would be hard, since it's used all over the place. Any ideas?

Call it u-boot-tools, potentially merge the other recipe tool, and add
RPROVIDES for compatibility?

You mean PROVIDES since we're talking PN namespace, not PACKAGES?

Cheers,

Richard