Skip to contentSkip to conversation

cpufreq: powernv: add of_node_put()

PATCH Superseded Yangtao Li 3 participants 4 messages Nov 20, 2018 – Dec 11, 2018

Subsystems (2)
PowerPC CPU frequency scaling framework
lore
Share & tools
lore

Yangtao Li

author
#0 lore raw

PATCH v2 1/1 cpufreq: powernv: add of_node_put()

The of_find_node_by_path() returns a node pointer with refcount incremented,but there is the lack of use of the of_node_put() when done.Add the missing of_node_put() to release the refcount.

Signed-off-by Yangtao Li <[email protected]>

---
Changes in v2
-update changelog

---
 drivers/cpufreq/powernv-cpufreq.c | 17 +++++++++++------
 1 file changed, 11 insertions(+), 6 deletions(-)
drivers/cpufreq/powernv-cpufreq.c +11 -6
index bf6519cf64bc..7e7ad3879c4e 100644
@@ -253,18 +253,18 @@ static int init_powernv_pstates(void)
 
 	if (of_property_read_u32(power_mgt, "ibm,pstate-min", &pstate_min)) {
 		pr_warn("ibm,pstate-min node not found\n");
-		return -ENODEV;
+		goto out;
 	}
 
 	if (of_property_read_u32(power_mgt, "ibm,pstate-max", &pstate_max)) {
 		pr_warn("ibm,pstate-max node not found\n");
-		return -ENODEV;
+		goto out;
 	}
 
 	if (of_property_read_u32(power_mgt, "ibm,pstate-nominal",
 				 &pstate_nominal)) {
 		pr_warn("ibm,pstate-nominal not found\n");
-		return -ENODEV;
+		goto out;
 	}
 
 	if (of_property_read_u32(power_mgt, "ibm,pstate-ultra-turbo",

@@ -293,14 +293,14 @@ static int init_powernv_pstates(void)
 	pstate_ids = of_get_property(power_mgt, "ibm,pstate-ids", &len_ids);
 	if (!pstate_ids) {
 		pr_warn("ibm,pstate-ids not found\n");
-		return -ENODEV;
+		goto out;
 	}
 
 	pstate_freqs = of_get_property(power_mgt, "ibm,pstate-frequencies-mhz",
 				      &len_freqs);
 	if (!pstate_freqs) {
 		pr_warn("ibm,pstate-frequencies-mhz not found\n");
-		return -ENODEV;
+		goto out;
 	}
 
 	if (len_ids != len_freqs) {

@@ -311,7 +311,7 @@ static int init_powernv_pstates(void)
 	nr_pstates = min(len_ids, len_freqs) / sizeof(u32);
 	if (!nr_pstates) {
 		pr_warn("No PStates found\n");
-		return -ENODEV;
+		goto out;
 	}
 
 	powernv_pstate_info.nr_pstates = nr_pstates;

@@ -352,7 +352,12 @@ static int init_powernv_pstates(void)
 
 	/* End of list marker entry */
 	powernv_freqs[i].frequency = CPUFREQ_TABLE_END;
+
+	of_node_put(power_mgt);
 	return 0;
+out:
+	of_node_put(power_mgt);
+	return -ENODEV;
 }
 
 /* Returns the CPU frequency corresponding to the pstate_id. */
Signature · 1 line
2.17.0
maintainer Acked-by on v2 1/1
#1 lore raw
Quoted 11 lines · Yangtao Li

The of_find_node_by_path() returns a node pointer with refcount incremented,but there is the lack of use of the of_node_put() when done.Add the missing of_node_put() to release the refcount.

Signed-off-by Yangtao Li <[email protected]>

---
Changes in v2
-update changelog

---
 drivers/cpufreq/powernv-cpufreq.c | 17 +++++++++++------
 1 file changed, 11 insertions(+), 6 deletions(-)
Acked-by Viresh Kumar <[email protected]>
Signature · 1 line
viresh
author
#2 lore raw
Quoted 14 lines · Viresh Kumar
Quoted 11 lines · Yangtao Li

The of_find_node_by_path() returns a node pointer with refcount incremented,but there is the lack of use of the of_node_put() when done.Add the missing of_node_put() to release the refcount.

Signed-off-by Yangtao Li <[email protected]>

---
Changes in v2
-update changelog

---
 drivers/cpufreq/powernv-cpufreq.c | 17 +++++++++++------
 1 file changed, 11 insertions(+), 6 deletions(-)
Quoted 4 lines
Acked-by Viresh Kumar <[email protected]>

--
viresh

Hi Gautham：

Can you add your Reviewed-by here?

Thanks，
Yangtao

#3 lore raw
In reply to Viresh Kumar
Quoted 13 lines · CET Viresh Kumar
Quoted 11 lines · Yangtao Li

The of_find_node_by_path() returns a node pointer with refcount incremented,but there is the lack of use of the of_node_put() when done.Add the missing of_node_put() to release the refcount.

Signed-off-by Yangtao Li <[email protected]>

---
Changes in v2
-update changelog

---
 drivers/cpufreq/powernv-cpufreq.c | 17 +++++++++++------
 1 file changed, 11 insertions(+), 6 deletions(-)
Quoted 1 line
Acked-by Viresh Kumar <[email protected]>

Patch applied, thanks!