Skip to contentSkip to conversation

drm/pl111: add of_node_put()

PATCH In review Yangtao Li 2 participants 2 messages Nov 21, 2018 – Nov 28, 2018

Subsystems (4)
lore
Share & tools
lore

Yangtao Li

author
#0 lore raw

PATCH 1/1 drm/pl111: add of_node_put()

of_find_node_by_path() acquires a reference to the node returned by it and that reference needs to be dropped by its caller. bl_idle_init() doesn't do that, so fix it.

---
 drivers/gpu/drm/pl111/pl111_vexpress.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/gpu/drm/pl111/pl111_vexpress.c +2 -0
index 5fa0441bb6df..38c938c9adda 100644
@@ -55,6 +55,8 @@ int pl111_vexpress_clcd_init(struct device *dev,
 		}
 	}
 
+	of_node_put(root);
+
 	/*
 	 * If there is a coretile HDLCD and it has a driver,
 	 * do not mux the CLCD on the motherboard to the DVI.
Signature · 1 line
2.17.0
#1 lore raw
Quoted 3 lines · Yangtao Li

of_find_node_by_path() acquires a reference to the node returned by it and that reference needs to be dropped by its caller. bl_idle_init() doesn't do that, so fix it.

The "bl_idle_init" appeared to be copy-and-paste from some other commit message, so I droppped that bit and pushed. Thanks!