Skip to contentSkip to conversation

drivers/tty: add missing of_node_put()

PATCH Applied Yangtao Li 2 participants 2 messages Nov 21, 2018 – Dec 3, 2018

Subsystems (2)
lore
Share & tools
lore

Yangtao Li

author
#0 lore raw

PATCH 1/1 drivers/tty: add missing of_node_put()

of_find_node_by_path() acquires a reference to the node returned by it and that reference needs to be dropped by its caller. This place is not doing this, so fix it.

---
 drivers/tty/serial/suncore.c | 1 +
 1 file changed, 1 insertion(+)
drivers/tty/serial/suncore.c +1 -0
index 70a4ea4eaa6e..990376576970 100644
@@ -112,6 +112,7 @@ void sunserial_console_termios(struct console *con, struct device_node *uart_dp)
 		mode = of_get_property(dp, mode_prop, NULL);
 		if (!mode)
 			mode = "9600,8,n,1,-";
+		of_node_put(dp);
 	}
 
 	cflag = CREAD | HUPCL | CLOCAL;
Signature · 1 line
2.17.0
maintainer Applied
#1 lore raw

From: Yangtao Li <[email protected]>
Date: Wed, 21 Nov 2018 10:22:54 -0500

Quoted 5 lines

of_find_node_by_path() acquires a reference to the node returned by it and that reference needs to be dropped by its caller. This place is not doing this, so fix it.

Applied.