Skip to contentSkip to conversation

net: amd: add missing of_node_put()

PATCH Applied Yangtao Li 2 participants 2 messages Nov 22, 2018 – Nov 24, 2018

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Yangtao Li

author
#0 lore raw

PATCH v2 1/1 net: amd: add missing of_node_put()

of_find_node_by_path() acquires a reference to the node returned by it and that reference needs to be dropped by its caller. This place doesn't do that, so fix it.

Signed-off-by Yangtao Li <[email protected]>

---
Changes in v2:
-update changelog

---
 drivers/net/ethernet/amd/sunlance.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/net/ethernet/amd/sunlance.c +3 -1
index b4fc0ed5bce8..9d4899826823 100644
@@ -1419,7 +1419,7 @@ static int sparc_lance_probe_one(struct platform_device *op,
 
 			prop = of_get_property(nd, "tpe-link-test?", NULL);
 			if (!prop)
-				goto no_link_test;
+				goto node_put;
 
 			if (strcmp(prop, "true")) {
 				printk(KERN_NOTICE "SunLance: warning: overriding option "

@@ -1428,6 +1428,8 @@ static int sparc_lance_probe_one(struct platform_device *op,
 				       "to [email protected]\n");
 				auxio_set_lte(AUXIO_LTE_ON);
 			}
+node_put:
+			of_node_put(nd);
 no_link_test:
 			lp->auto_select = 1;
 			lp->tpe = 0;
Signature · 1 line
2.17.0
maintainer Applied
#1 lore raw

From: Yangtao Li <[email protected]>
Date: Thu, 22 Nov 2018 07:34:41 -0500

Quoted 5 lines

of_find_node_by_path() acquires a reference to the node returned by it and that reference needs to be dropped by its caller. This place doesn't do that, so fix it.

Signed-off-by Yangtao Li <[email protected]>

Applied.