Skip to contentSkip to conversation

soc: sunxi: Change to use DEFINE_SHOW_ATTRIBUTE macro

PATCH Applied Yangtao Li 2 participants 2 messages Nov 22, 2018 Arm/Allwinner sunXi SoC support

lore
Share & tools
lore

Yangtao Li

author
#0 lore raw

PATCH 1/1 soc: sunxi: Change to use DEFINE_SHOW_ATTRIBUTE macro

Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.

Signed-off-by Yangtao Li <[email protected]>
---
 drivers/soc/sunxi/sunxi_sram.c | 12 +-----------
 1 file changed, 1 insertion(+), 11 deletions(-)
drivers/soc/sunxi/sunxi_sram.c +1 -11
index b4b0f3480bd3..71e3ee4a3f19 100644
@@ -155,17 +155,7 @@ static int sunxi_sram_show(struct seq_file *s, void *data)
 	return 0;
 }
 
-static int sunxi_sram_open(struct inode *inode, struct file *file)
-{
-	return single_open(file, sunxi_sram_show, inode->i_private);
-}
-
-static const struct file_operations sunxi_sram_fops = {
-	.open = sunxi_sram_open,
-	.read = seq_read,
-	.llseek = seq_lseek,
-	.release = single_release,
-};
+DEFINE_SHOW_ATTRIBUTE(sunxi_sram);
 
 static inline struct sunxi_sram_desc *to_sram_desc(const struct sunxi_sram_data *data)
 {
Signature · 1 line
2.17.0
Applied
#1 lore raw
Quoted 3 lines · Yangtao Li

Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.

Signed-off-by Yangtao Li <[email protected]>

Applied, thanks!
Maxime

Signature · 10 lines
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20181122/6fd0078d/attachment.sig>