Skip to contentSkip to conversation

memory: tegra: Convert to using %pOFn instead of device_node.name

PATCH In review Yangtao Li 2 participants 2 messages Nov 24, 2018 – Nov 27, 2018

Subsystems (2)
Tegra architecture support Memory controller drivers
lore
Share & tools
lore

Yangtao Li

author
#0 lore raw

PATCH 1/1 memory: tegra: Convert to using %pOFn instead of device_node.name

In preparation to remove the node name pointer from struct device_node, convert printf users to use the %pOFn format specifier.

Signed-off-by Yangtao Li <[email protected]>
---
 drivers/memory/tegra/mc.c           |  6 +++---
 drivers/memory/tegra/tegra124-emc.c | 12 ++++++------
 2 files changed, 9 insertions(+), 9 deletions(-)
drivers/memory/tegra/mc.c +3 -3
index bd25faf6d13d..24afc36833bf 100644
@@ -345,7 +345,7 @@ static int load_one_timing(struct tegra_mc *mc,
 	err = of_property_read_u32(node, "clock-frequency", &tmp);
 	if (err) {
 		dev_err(mc->dev,
-			"timing %s: failed to read rate\n", node->name);
+			"timing %pOFn: failed to read rate\n", node);
 		return err;
 	}
 

@@ -360,8 +360,8 @@ static int load_one_timing(struct tegra_mc *mc,
 					 mc->soc->num_emem_regs);
 	if (err) {
 		dev_err(mc->dev,
-			"timing %s: failed to read EMEM configuration\n",
-			node->name);
+			"timing %pOFn: failed to read EMEM configuration\n",
+			node);
 		return err;
 	}
drivers/memory/tegra/tegra124-emc.c +6 -6
index 392dc8dd481f..eedb7d48e2ea 100644
@@ -888,8 +888,8 @@ static int load_one_timing_from_dt(struct tegra_emc *emc,
 
 	err = of_property_read_u32(node, "clock-frequency", &value);
 	if (err) {
-		dev_err(emc->dev, "timing %s: failed to read rate: %d\n",
-			node->name, err);
+		dev_err(emc->dev, "timing %pOFn: failed to read rate: %d\n",
+			node, err);
 		return err;
 	}
 

@@ -900,16 +900,16 @@ static int load_one_timing_from_dt(struct tegra_emc *emc,
 					 ARRAY_SIZE(timing->emc_burst_data));
 	if (err) {
 		dev_err(emc->dev,
-			"timing %s: failed to read emc burst data: %d\n",
-			node->name, err);
+			"timing %pOFn: failed to read emc burst data: %d\n",
+			node, err);
 		return err;
 	}
 
 #define EMC_READ_PROP(prop, dtprop) { \
 	err = of_property_read_u32(node, dtprop, &timing->prop); \
 	if (err) { \
-		dev_err(emc->dev, "timing %s: failed to read " #prop ": %d\n", \
-			node->name, err); \
+		dev_err(emc->dev, "timing %pOFn: failed to read " #prop ": %d\n", \
+			node, err); \
 		return err; \
 	} \
 }
Signature · 1 line
2.17.0
#1 lore raw
Quoted 9 lines · Yangtao Li

In preparation to remove the node name pointer from struct device_node, convert printf users to use the %pOFn format specifier.

Signed-off-by Yangtao Li <[email protected]>
---
 drivers/memory/tegra/mc.c           |  6 +++---
 drivers/memory/tegra/tegra124-emc.c | 12 ++++++------
 2 files changed, 9 insertions(+), 9 deletions(-)

Thanks, but I already sent a patch for this and all the others in drivers/memory/ and have queued it since no one picked it up.

Rob