Skip to contentSkip to conversation

power/reset: axxia: Convert to using %pOFn instead of device_node.name

PATCH In review Yangtao Li 3 participants 3 messages Nov 24, 2018 – Dec 5, 2018 System reset/shutdown drivers

lore
Share & tools
lore

Yangtao Li

author
#0 lore raw

PATCH 1/1 power/reset: axxia: Convert to using %pOFn instead of device_node.name

In preparation to remove the node name pointer from struct device_node, convert printf users to use the %pOFn format specifier.

Signed-off-by Yangtao Li <[email protected]>
---
 drivers/power/reset/axxia-reset.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/power/reset/axxia-reset.c +1 -1
index 4e4cd1c8fe50..b16013265142 100644
@@ -65,7 +65,7 @@ static int axxia_reset_probe(struct platform_device *pdev)
 
 	syscon = syscon_regmap_lookup_by_phandle(dev->of_node, "syscon");
 	if (IS_ERR(syscon)) {
-		pr_err("%s: syscon lookup failed\n", dev->of_node->name);
+		pr_err("%pOFn: syscon lookup failed\n", dev->of_node);
 		return PTR_ERR(syscon);
 	}
Signature · 1 line
2.17.0
#1 lore raw
Quoted 8 lines · Yangtao Li

In preparation to remove the node name pointer from struct device_node, convert printf users to use the %pOFn format specifier.

Signed-off-by Yangtao Li <[email protected]>
---
 drivers/power/reset/axxia-reset.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Thanks, but I already sent out the same patch and have queued it since no one picked it up.

Rob

Quoted 17 lines
drivers/power/reset/axxia-reset.c +1 -2
index 4e4cd1c8fe50..b16013265142 100644
@@ -65,7 +65,7 @@ static int axxia_reset_probe(struct platform_device *pdev)
 
        syscon = syscon_regmap_lookup_by_phandle(dev->of_node, "syscon");
        if (IS_ERR(syscon)) {
-               pr_err("%s: syscon lookup failed\n", dev->of_node->name);
+               pr_err("%pOFn: syscon lookup failed\n", dev->of_node);
                return PTR_ERR(syscon);
        }
 
--

2.17.0

#2 lore raw

Hi,

Quoted 5 lines · Rob Herring
Quoted 4 lines · Yangtao Li

In preparation to remove the node name pointer from struct device_node, convert printf users to use the %pOFn format specifier.

Quoted 7 lines
Quoted 4 lines
Signed-off-by Yangtao Li <[email protected]>
---
 drivers/power/reset/axxia-reset.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Thanks, but I already sent out the same patch and have queued it since no one picked it up.

Yeah, I did not find enough time to review patches in the last few weeks. OTOH I don't see a previous patch with axxia in the Subject in my mailbox anyways. FWIW I will skip this one.

-- Sebastian

Quoted 19 lines

Rob

Quoted 17 lines
drivers/power/reset/axxia-reset.c +1 -2
index 4e4cd1c8fe50..b16013265142 100644
@@ -65,7 +65,7 @@ static int axxia_reset_probe(struct platform_device *pdev)
 
        syscon = syscon_regmap_lookup_by_phandle(dev->of_node, "syscon");
        if (IS_ERR(syscon)) {
-               pr_err("%s: syscon lookup failed\n", dev->of_node->name);
+               pr_err("%pOFn: syscon lookup failed\n", dev->of_node);
                return PTR_ERR(syscon);
        }
 
--

2.17.0