Skip to contentSkip to conversation

MAINTAINERS: Add various missing entries

PATCH Applied Philippe Mathieu-Daudé 15 participants 79 messages Nov 25, 2018 – Nov 27, 2018

v1 of 2 Applied Latest is v2 →

lore
Share & tools
lore

Philippe Mathieu-Daudé

author
#0 lore raw

cover MAINTAINERS: Add various missing entries

Hi,

This cleanup effort is inspired by Markus "Full list of unmaintained files" from the "MAINTAINERS leaves too many files uncovered" thread:
https://lists.gnu.org/archive/html/qemu-devel/2018-11/msg04270.html

Regards,

Phil.

Philippe Mathieu-Daudé (25):
MAINTAINERS: Fix ACPI tests data files path
MAINTAINERS: Add a missing entry to the SPARC CPU
MAINTAINERS: Add missing entries to the X86 section (AMD SEV)
MAINTAINERS: Add missing entries for the Xilinx ZynqMP machine
MAINTAINERS: Add missing entries for the Jazz machine
MAINTAINERS: Add a missing entry for the Xilinx S3A-DSP 1800 machine
MAINTAINERS: Add a missing entry for the Fulong 2E machine
MAINTAINERS: Add a missing entry for the Old World machines
MAINTAINERS: Add a missing entry for the sun4m machines
MAINTAINERS: Add missing entries for the sun4u machines
MAINTAINERS: Add missing entries for the PC machines
MAINTAINERS: Add missing entries to the PC Chipset section
MAINTAINERS: Add missing entries to VFIO
MAINTAINERS: Add missing entries to the vhost section
MAINTAINERS: Add missing entries for the Canon DIGIC machine
MAINTAINERS: Add missing entries for the MPS2 machine
MAINTAINERS: Add a missing entry to SPICE
MAINTAINERS: Add missing entries for the QObject section
MAINTAINERS: Add a missing entry to the QMP section
MAINTAINERS: Add missing test entries to the Cryptography section
MAINTAINERS: Add a missing entry for the NVDIMM device
MAINTAINERS: Add a missing entry to the New World machines
MAINTAINERS: Add an entry for the Dino machine
MAINTAINERS: Use my work email to review Build and test automation patches
MAINTAINERS: Remove duplicate entries of [email protected]

 MAINTAINERS | 69 ++++++++++++++++++++++++++++++++++++++++-------------
 1 file changed, 52 insertions(+), 17 deletions(-)
Signature · 1 line
2.17.2
author
#1 lore raw

PATCH 1/25 MAINTAINERS: Fix ACPI tests data files path

Missed while moving those files in 438c78dab75.

Signed-off-by Philippe Mathieu-Daudé <[email protected]>
Reviewed-by Igor Mammedov <[email protected]>
---
 MAINTAINERS | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
MAINTAINERS +1 -2
index 1032406c56..6c4f25fb05 100644
@@ -1216,8 +1216,7 @@ F: hw/i386/acpi-build.[hc]
 F: hw/arm/virt-acpi-build.c
 F: tests/bios-tables-test.c
 F: tests/acpi-utils.[hc]
-F: tests/acpi-test-data/*
-F: tests/acpi-test-data/*/*
+F: tests/data/acpi/
 
 ppc4xx
 M: David Gibson <[email protected]>
Signature · 1 line
2.17.2
Reviewed-by on v1 1/25
#2 lore raw

Re: [Qemu-devel] [PATCH for-3.1 01/25] MAINTAINERS: Fix ACPI tests data files path

Quoted 14 lines · Philippe Mathieu-Daudé

Missed while moving those files in 438c78dab75.

Signed-off-by Philippe Mathieu-Daudé <[email protected]>
Reviewed-by Igor Mammedov <[email protected]>
---
 MAINTAINERS | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
MAINTAINERS +0 -0
index 1032406c56..6c4f25fb05 100644

MAINTAINERS F: hw/i386/acpi-build.[hc] · line 1222

Quoted 9 lines
MAINTAINERS +1 -2
@@ -1216,8 +1216,7 @@ F: hw/i386/acpi-build.[hc]
 F: hw/arm/virt-acpi-build.c
 F: tests/bios-tables-test.c
 F: tests/acpi-utils.[hc]
-F: tests/acpi-test-data/*
-F: tests/acpi-test-data/*/*
+F: tests/data/acpi/
 
 ppc4xx
 M: David Gibson <[email protected]>
Reviewed-by Thomas Huth <[email protected]>
Applied
#3 lore raw

Re: [Qemu-devel] [Qemu-trivial] [PATCH for-3.1 01/25] MAINTAINERS: Fix ACPI tests data files path

In reply to Philippe Mathieu-Daudé
Quoted 14 lines · Philippe Mathieu-Daudé

Missed while moving those files in 438c78dab75.

Signed-off-by Philippe Mathieu-Daudé <[email protected]>
Reviewed-by Igor Mammedov <[email protected]>
---
 MAINTAINERS | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
MAINTAINERS +0 -0
index 1032406c56..6c4f25fb05 100644

MAINTAINERS F: hw/i386/acpi-build.[hc] · line 1222

Quoted 9 lines
MAINTAINERS +1 -2
@@ -1216,8 +1216,7 @@ F: hw/i386/acpi-build.[hc]
 F: hw/arm/virt-acpi-build.c
 F: tests/bios-tables-test.c
 F: tests/acpi-utils.[hc]
-F: tests/acpi-test-data/*
-F: tests/acpi-test-data/*/*
+F: tests/data/acpi/
 
 ppc4xx
 M: David Gibson <[email protected]>

Applied to my trivial-patches branch.

Thanks,
Laurent

Reviewed-by on v1 2/25
#5 lore raw

Re: [Qemu-devel] [PATCH for-3.1 02/25] MAINTAINERS: Add a missing entry to the SPARC CPU

Quoted 10 lines · Philippe Mathieu-Daudé
Signed-off-by Philippe Mathieu-Daudé <[email protected]>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)
MAINTAINERS +0 -0
index 6c4f25fb05..ae12323647 100644

MAINTAINERS S: Maintained · line 287

Quoted 7 lines
MAINTAINERS +1 -0
@@ -281,6 +281,7 @@ S: Maintained
 F: target/sparc/
 F: hw/sparc/
 F: hw/sparc64/
+F: include/hw/sparc/sparc64.h
 F: disas/sparc.c
 
 UniCore32
Reviewed-by Mark Cave-Ayland <[email protected]>

ATB,

Mark.

Applied
#6 lore raw

Re: [Qemu-devel] [Qemu-trivial] [PATCH for-3.1 02/25] MAINTAINERS: Add a missing entry to the SPARC CPU

In reply to Philippe Mathieu-Daudé
Quoted 11 lines · Philippe Mathieu-Daudé
Signed-off-by Philippe Mathieu-Daudé <[email protected]>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)
MAINTAINERS +0 -0
index 6c4f25fb05..ae12323647 100644

MAINTAINERS S: Maintained · line 287

Quoted 7 lines
MAINTAINERS +1 -0
@@ -281,6 +281,7 @@ S: Maintained
 F: target/sparc/
 F: hw/sparc/
 F: hw/sparc64/
+F: include/hw/sparc/sparc64.h
 F: disas/sparc.c
 
 UniCore32

Applied to my trivial-patches branch.

Thanks,
Laurent

author
#7 lore raw

PATCH 3/25 MAINTAINERS: Add missing entries to the X86 section (AMD SEV)

In reply to Philippe Mathieu-Daudé
Signed-off-by Philippe Mathieu-Daudé <[email protected]>
---
 MAINTAINERS | 2 ++
 1 file changed, 2 insertions(+)
MAINTAINERS +2 -0
index ae12323647..3b9996ab2c 100644
@@ -300,8 +300,10 @@ F: target/i386/
 F: tests/tcg/i386/
 F: tests/tcg/x86_64/
 F: hw/i386/
+F: include/sysemu/sev.h
 F: disas/i386.c
 F: docs/qemu-cpu-models.texi
+F: docs/amd-memory-encryption.txt
 T: git https://github.com/ehabkost/qemu.git x86-next
 
 Xtensa
Signature · 1 line
2.17.2
#8 lore raw

Re: [Qemu-devel] [PATCH for-3.1 03/25] MAINTAINERS: Add missing entries to the X86 section (AMD SEV)

Quoted 10 lines · Philippe Mathieu-Daudé
Signed-off-by Philippe Mathieu-Daudé <[email protected]>
---
 MAINTAINERS | 2 ++
 1 file changed, 2 insertions(+)
MAINTAINERS +0 -0
index ae12323647..3b9996ab2c 100644

MAINTAINERS F: target/i386/ · line 307

Quoted 8 lines
MAINTAINERS +2 -0
@@ -300,8 +300,10 @@ F: target/i386/
 F: tests/tcg/i386/
 F: tests/tcg/x86_64/
 F: hw/i386/
+F: include/sysemu/sev.h
 F: disas/i386.c
 F: docs/qemu-cpu-models.texi
+F: docs/amd-memory-encryption.txt
 T: git https://github.com/ehabkost/qemu.git x86-next

Not sure, but I think this should rather be added to the KVM section, not to the TCG section?

Thomas

#9 lore raw

Re: [Qemu-devel] [PATCH for-3.1 03/25] MAINTAINERS: Add missing entries to the X86 section (AMD SEV)

Quoted 6 lines · Thomas Huth
Quoted 5 lines · Philippe Mathieu-Daudé
Signed-off-by Philippe Mathieu-Daudé <[email protected]>
---
 MAINTAINERS | 2 ++
 1 file changed, 2 insertions(+)
Quoted 16 lines

MAINTAINERS F: target/i386/ · line 307

Quoted 13 lines
MAINTAINERS +2 -0
index ae12323647..3b9996ab2c 100644
@@ -300,8 +300,10 @@ F: target/i386/
 F: tests/tcg/i386/
 F: tests/tcg/x86_64/
 F: hw/i386/
+F: include/sysemu/sev.h
 F: disas/i386.c
 F: docs/qemu-cpu-models.texi
+F: docs/amd-memory-encryption.txt
 T: git https://github.com/ehabkost/qemu.git x86-next

Not sure, but I think this should rather be added to the KVM section, not to the TCG section?

Yes, agreed.

Paolo

author
#10 lore raw

PATCH 4/25 MAINTAINERS: Add missing entries for the Xilinx ZynqMP machine

In reply to Philippe Mathieu-Daudé
Signed-off-by Philippe Mathieu-Daudé <[email protected]>
---
 MAINTAINERS | 3 +++
 1 file changed, 3 insertions(+)
MAINTAINERS +3 -0
index 3b9996ab2c..007f89f126 100644
@@ -711,6 +711,9 @@ L: [email protected]
 S: Maintained
 F: hw/*/xlnx*.c
 F: include/hw/*/xlnx*.h
+F: include/hw/ssi/xilinx_spips.h
+F: hw/display/dpcd.c
+F: include/hw/display/dpcd.h
 
 ARM ACPI Subsystem
 M: Shannon Zhao <[email protected]>
Signature · 1 line
2.17.2
Reviewed-by on v1 4/25
#11 lore raw

Re: [Qemu-arm] [Qemu-devel] [PATCH for-3.1 04/25] MAINTAINERS: Add missing entries for the Xilinx ZynqMP machine

Quoted 2 lines · Philippe Mathieu-Daudé
Signed-off-by Philippe Mathieu-Daudé <[email protected]>
Reviewed-by Alistair Francis <[email protected]>

Alistair

Quoted 22 lines
---
 MAINTAINERS | 3 +++
 1 file changed, 3 insertions(+)
MAINTAINERS +3 -1
index 3b9996ab2c..007f89f126 100644
@@ -711,6 +711,9 @@ L: [email protected]
 S: Maintained
 F: hw/*/xlnx*.c
 F: include/hw/*/xlnx*.h
+F: include/hw/ssi/xilinx_spips.h
+F: hw/display/dpcd.c
+F: include/hw/display/dpcd.h
 
 ARM ACPI Subsystem
 M: Shannon Zhao <[email protected]>
--

2.17.2

Applied
#12 lore raw

Re: [Qemu-arm] [Qemu-trivial] [PATCH for-3.1 04/25] MAINTAINERS: Add missing entries for the Xilinx ZynqMP machine

In reply to Philippe Mathieu-Daudé
Quoted 11 lines · Philippe Mathieu-Daudé
Signed-off-by Philippe Mathieu-Daudé <[email protected]>
---
 MAINTAINERS | 3 +++
 1 file changed, 3 insertions(+)
MAINTAINERS +0 -0
index 3b9996ab2c..007f89f126 100644

MAINTAINERS L: [email protected] · line 719

Quoted 9 lines
MAINTAINERS +3 -0
@@ -711,6 +711,9 @@ L: [email protected]
 S: Maintained
 F: hw/*/xlnx*.c
 F: include/hw/*/xlnx*.h
+F: include/hw/ssi/xilinx_spips.h
+F: hw/display/dpcd.c
+F: include/hw/display/dpcd.h
 
 ARM ACPI Subsystem
 M: Shannon Zhao <[email protected]>

Applied to my trivial-patches branch.

Thanks,
Laurent

author
#13 lore raw

PATCH 5/25 MAINTAINERS: Add missing entries for the Jazz machine

In reply to Philippe Mathieu-Daudé
Signed-off-by Philippe Mathieu-Daudé <[email protected]>
---
 MAINTAINERS | 2 ++
 1 file changed, 2 insertions(+)
MAINTAINERS +2 -0
index 007f89f126..4e396cbe71 100644
@@ -835,6 +835,8 @@ M: Hervé Poussineau <[email protected]>
 R: Stefan Markovic <[email protected]>
 S: Maintained
 F: hw/mips/mips_jazz.c
+F: hw/display/jazz_led.c
+F: hw/dma/rc4030.c
 
 Malta
 M: Aurelien Jarno <[email protected]>
Signature · 1 line
2.17.2
Reviewed-by on v1 5/25
#14 lore raw

Re: [Qemu-devel] [PATCH for-3.1 05/25] MAINTAINERS: Add missing entries for the Jazz machine

Quoted 4 lines · Philippe Mathieu-Daudé
Signed-off-by Philippe Mathieu-Daudé <[email protected]>
---
  MAINTAINERS | 2 ++
  1 file changed, 2 insertions(+)
Reviewed-by Stefan Markovic <[email protected]>
Quoted 13 lines
MAINTAINERS +2 -0
index 007f89f126..4e396cbe71 100644
@@ -835,6 +835,8 @@ M: Hervé Poussineau <[email protected]>
  R: Stefan Markovic <[email protected]>
  S: Maintained
  F: hw/mips/mips_jazz.c
+F: hw/display/jazz_led.c
+F: hw/dma/rc4030.c
 
  Malta
  M: Aurelien Jarno <[email protected]>
Applied
#15 lore raw

Re: [Qemu-devel] [Qemu-trivial] [PATCH for-3.1 05/25] MAINTAINERS: Add missing entries for the Jazz machine

In reply to Philippe Mathieu-Daudé
Quoted 11 lines · Philippe Mathieu-Daudé
Signed-off-by Philippe Mathieu-Daudé <[email protected]>
---
 MAINTAINERS | 2 ++
 1 file changed, 2 insertions(+)
MAINTAINERS +0 -0
index 007f89f126..4e396cbe71 100644

MAINTAINERS M: Hervé Poussineau <[email protected]> · line 842

Quoted 8 lines
MAINTAINERS +2 -0
@@ -835,6 +835,8 @@ M: Hervé Poussineau <[email protected]>
 R: Stefan Markovic <[email protected]>
 S: Maintained
 F: hw/mips/mips_jazz.c
+F: hw/display/jazz_led.c
+F: hw/dma/rc4030.c
 
 Malta
 M: Aurelien Jarno <[email protected]>

Applied to my trivial-patches branch.

Thanks,
Laurent

author
#16 lore raw

PATCH 6/25 MAINTAINERS: Add a missing entry for the Xilinx S3A-DSP 1800 machine

In reply to Philippe Mathieu-Daudé
Signed-off-by Philippe Mathieu-Daudé <[email protected]>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)
MAINTAINERS +1 -0
index 4e396cbe71..aa17e9bbd3 100644
@@ -822,6 +822,7 @@ petalogix_s3adsp1800
 M: Edgar E. Iglesias <[email protected]>
 S: Maintained
 F: hw/microblaze/petalogix_s3adsp1800_mmu.c
+include/hw/char/xilinx_uartlite.h
 
 petalogix_ml605
 M: Edgar E. Iglesias <[email protected]>
Signature · 1 line
2.17.2
#17 lore raw

Re: [Qemu-arm] [PATCH for-3.1 06/25] MAINTAINERS: Add a missing entry for the Xilinx S3A-DSP 1800 machine

Quoted 11 lines · Philippe Mathieu-Daudé
Signed-off-by Philippe Mathieu-Daudé <[email protected]>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)
MAINTAINERS +0 -0
index 4e396cbe71..aa17e9bbd3 100644

MAINTAINERS petalogix_s3adsp1800 · line 825

Quoted 4 lines
MAINTAINERS +1 -0
@@ -822,6 +822,7 @@ petalogix_s3adsp1800
 M: Edgar E. Iglesias <[email protected]>
 S: Maintained
 F: hw/microblaze/petalogix_s3adsp1800_mmu.c
+include/hw/char/xilinx_uartlite.h

Missing the leading "F: " ?

MAINTAINERS petalogix_s3adsp1800 · line 828

Quoted 2 lines
MAINTAINERS +0 -0
 petalogix_ml605
 M: Edgar E. Iglesias <[email protected]>

thanks
-- PMM

author
#18 lore raw

Re: [Qemu-arm] [PATCH for-3.1 06/25] MAINTAINERS: Add a missing entry for the Xilinx S3A-DSP 1800 machine

Quoted 7 lines · Peter Maydell
Quoted 6 lines · Philippe Mathieu-Daudé
Signed-off-by Philippe Mathieu-Daudé <[email protected]>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)
Quoted 11 lines

MAINTAINERS petalogix_s3adsp1800 · line 825

Quoted 9 lines
MAINTAINERS +1 -0
index 4e396cbe71..aa17e9bbd3 100644
@@ -822,6 +822,7 @@ petalogix_s3adsp1800
 M: Edgar E. Iglesias <[email protected]>
 S: Maintained
 F: hw/microblaze/petalogix_s3adsp1800_mmu.c
+include/hw/char/xilinx_uartlite.h

Missing the leading "F: " ?

Argh... If there is no need to respin, maybe the maintainer taking those patches is willing to fix this mistake... :)

Thanks btw!

Quoted 7 lines

MAINTAINERS petalogix_s3adsp1800 · line 828

Quoted 3 lines
MAINTAINERS +0 -0
 petalogix_ml605
 M: Edgar E. Iglesias <[email protected]>

thanks
-- PMM

Applied
#19 lore raw

Re: [Qemu-arm] [Qemu-trivial] [PATCH for-3.1 06/25] MAINTAINERS: Add a missing entry for the Xilinx S3A-DSP 1800 machine

In reply to Philippe Mathieu-Daudé
Quoted 11 lines · Philippe Mathieu-Daudé
Signed-off-by Philippe Mathieu-Daudé <[email protected]>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)
MAINTAINERS +0 -0
index 4e396cbe71..aa17e9bbd3 100644

MAINTAINERS petalogix_s3adsp1800 · line 828

Quoted 7 lines
MAINTAINERS +1 -0
@@ -822,6 +822,7 @@ petalogix_s3adsp1800
 M: Edgar E. Iglesias <[email protected]>
 S: Maintained
 F: hw/microblaze/petalogix_s3adsp1800_mmu.c
+include/hw/char/xilinx_uartlite.h
 
 petalogix_ml605
 M: Edgar E. Iglesias <[email protected]>

I've added the missing 'F:' field.

Applied to my trivial-patches branch.

Thanks,
Laurent

author
#20 lore raw

Re: [Qemu-devel] [Qemu-trivial] [PATCH for-3.1 06/25] MAINTAINERS: Add a missing entry for the Xilinx S3A-DSP 1800 machine

Quoted 16 lines · Laurent Vivier
Quoted 15 lines · Philippe Mathieu-Daudé
Signed-off-by Philippe Mathieu-Daudé <[email protected]>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)
MAINTAINERS +1 -0
index 4e396cbe71..aa17e9bbd3 100644
@@ -822,6 +822,7 @@ petalogix_s3adsp1800
 M: Edgar E. Iglesias <[email protected]>
 S: Maintained
 F: hw/microblaze/petalogix_s3adsp1800_mmu.c
+include/hw/char/xilinx_uartlite.h
Quoted 7 lines

MAINTAINERS petalogix_s3adsp1800 · line 828

Quoted 3 lines
MAINTAINERS +0 -0
 petalogix_ml605
 M: Edgar E. Iglesias <[email protected]>

I've added the missing 'F:' field.

Applied to my trivial-patches branch.

Thanks Laurent!

author
#21 lore raw

PATCH 7/25 MAINTAINERS: Add a missing entry for the Fulong 2E machine

In reply to Philippe Mathieu-Daudé
Signed-off-by Philippe Mathieu-Daudé <[email protected]>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)
MAINTAINERS +1 -0
index aa17e9bbd3..81a22b2ccf 100644
@@ -864,6 +864,7 @@ R: Stefan Markovic <[email protected]>
 S: Odd Fixes
 F: hw/mips/mips_fulong2e.c
 F: hw/isa/vt82c686.c
+F: hw/pci-host/bonito.c
 
 F: include/hw/isa/vt82c686.h
Signature · 1 line
2.17.2
Reviewed-by on v1 7/25
#22 lore raw

Re: [Qemu-devel] [PATCH for-3.1 07/25] MAINTAINERS: Add a missing entry for the Fulong 2E machine

Quoted 4 lines · Philippe Mathieu-Daudé
Signed-off-by Philippe Mathieu-Daudé <[email protected]>
---
  MAINTAINERS | 1 +
  1 file changed, 1 insertion(+)
Reviewed-by Stefan Markovic <[email protected]>
Quoted 12 lines
MAINTAINERS +1 -0
index aa17e9bbd3..81a22b2ccf 100644
@@ -864,6 +864,7 @@ R: Stefan Markovic <[email protected]>
  S: Odd Fixes
  F: hw/mips/mips_fulong2e.c
  F: hw/isa/vt82c686.c
+F: hw/pci-host/bonito.c
 
  F: include/hw/isa/vt82c686.h
#23 lore raw

Re: [Qemu-devel] [PATCH for-3.1 07/25] MAINTAINERS: Add a missing entry for the Fulong 2E machine

In reply to Philippe Mathieu-Daudé
Quoted 10 lines · Philippe Mathieu-Daudé
Signed-off-by Philippe Mathieu-Daudé <[email protected]>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)
MAINTAINERS +0 -0
index aa17e9bbd3..81a22b2ccf 100644

MAINTAINERS R: Stefan Markovic <[email protected]> · line 869

Quoted 6 lines
MAINTAINERS +1 -0
@@ -864,6 +864,7 @@ R: Stefan Markovic <[email protected]>
 S: Odd Fixes
 F: hw/mips/mips_fulong2e.c
 F: hw/isa/vt82c686.c
+F: hw/pci-host/bonito.c
 
 F: include/hw/isa/vt82c686.h

Please remove the empty line between bonito.c and vt82c686.h - or we could use my patch here from last Thursday instead:

https://lists.gnu.org/archive/html/qemu-devel/2018-11/msg04526.html

Thomas

#24 lore raw

Re: [Qemu-devel] [PATCH for-3.1 07/25] MAINTAINERS: Add a missing entry for the Fulong 2E machine

I like better the patch that Thomas linked to. I think Philippe should have included Thomas' patch, rather than creating new, overlapping, patches. Confusion about straitforward things! Aleksandar

________________________________________
From: Thomas Huth <[email protected]>
Sent: Tuesday, November 27, 2018 10:49:27 AM
To: Philippe Mathieu-Daudé; Aleksandar Markovic; Stefan Markovic
Cc: [email protected]; [email protected]
Subject: Re: [PATCH for-3.1 07/25] MAINTAINERS: Add a missing entry for the Fulong 2E machine

Quoted 10 lines · Philippe Mathieu-Daudé
Signed-off-by Philippe Mathieu-Daudé <[email protected]>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)
MAINTAINERS +0 -0
index aa17e9bbd3..81a22b2ccf 100644

MAINTAINERS R: Stefan Markovic <[email protected]> · line 869

Quoted 6 lines
MAINTAINERS +1 -0
@@ -864,6 +864,7 @@ R: Stefan Markovic <[email protected]>
 S: Odd Fixes
 F: hw/mips/mips_fulong2e.c
 F: hw/isa/vt82c686.c
+F: hw/pci-host/bonito.c
 
 F: include/hw/isa/vt82c686.h

Please remove the empty line between bonito.c and vt82c686.h - or we could use my patch here from last Thursday instead:

https://lists.gnu.org/archive/html/qemu-devel/2018-11/msg04526.html

Thomas

author
#25 lore raw

Re: [Qemu-devel] [PATCH for-3.1 07/25] MAINTAINERS: Add a missing entry for the Fulong 2E machine

On 27/11/18 10:58, Aleksandar Markovic wrote:

[moving Aleksandar reply down to avoid top-posting on technical list]

Quoted 17 lines

From: Thomas Huth <[email protected]>

Quoted 15 lines · Philippe Mathieu-Daudé
Signed-off-by Philippe Mathieu-Daudé <[email protected]>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)
MAINTAINERS +1 -0
index aa17e9bbd3..81a22b2ccf 100644
@@ -864,6 +864,7 @@ R: Stefan Markovic <[email protected]>
 S: Odd Fixes
 F: hw/mips/mips_fulong2e.c
 F: hw/isa/vt82c686.c
+F: hw/pci-host/bonito.c
Quoted 8 lines

MAINTAINERS R: Stefan Markovic <[email protected]> · line 869

Quoted 1 line
MAINTAINERS +0 -0
 F: include/hw/isa/vt82c686.h

Please remove the empty line between bonito.c and vt82c686.h - or we could use my patch here from last Thursday instead:

https://lists.gnu.org/archive/html/qemu-devel/2018-11/msg04526.html

I like better the patch that Thomas linked to. I think Philippe should

have included Thomas' patch, rather than creating new, overlapping, patches. Confusion about straitforward things! Aleksandar

Yes you are right, I missed Thomas's patch, so please disregard mine.

Thanks!

Phil.

Quoted 4 lines

Thomas

author
#26 lore raw

PATCH 8/25 MAINTAINERS: Add a missing entry for the Old World machines

In reply to Philippe Mathieu-Daudé
Signed-off-by Philippe Mathieu-Daudé <[email protected]>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)
MAINTAINERS +1 -0
index 81a22b2ccf..aa51ae813b 100644
@@ -936,6 +936,7 @@ F: hw/ppc/mac_oldworld.c
 F: hw/pci-host/grackle.c
 F: hw/misc/macio/
 F: hw/intc/heathrow_pic.c
+F: include/hw/intc/heathrow_pic.h
 
 PReP
 M: Hervé Poussineau <[email protected]>
Signature · 1 line
2.17.2
Acked-by on v1 8/25
#27 lore raw

Re: [Qemu-devel] [PATCH for-3.1 08/25] MAINTAINERS: Add a missing entry for the Old World machines

Quoted 1 line · Philippe Mathieu-Daudé
Signed-off-by Philippe Mathieu-Daudé <[email protected]>
Acked-by David Gibson <[email protected]>
Quoted 16 lines
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)
MAINTAINERS +1 -0
index 81a22b2ccf..aa51ae813b 100644
@@ -936,6 +936,7 @@ F: hw/ppc/mac_oldworld.c
 F: hw/pci-host/grackle.c
 F: hw/misc/macio/
 F: hw/intc/heathrow_pic.c
+F: include/hw/intc/heathrow_pic.h
 
 PReP
 M: Hervé Poussineau <[email protected]>
Signature · 4 lines
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson
Reviewed-by on v1 8/25
#28 lore raw

Re: [Qemu-devel] [PATCH for-3.1 08/25] MAINTAINERS: Add a missing entry for the Old World machines

In reply to Philippe Mathieu-Daudé
Quoted 10 lines · Philippe Mathieu-Daudé
Signed-off-by Philippe Mathieu-Daudé <[email protected]>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)
MAINTAINERS +0 -0
index 81a22b2ccf..aa51ae813b 100644

MAINTAINERS F: hw/ppc/mac_oldworld.c · line 942

Quoted 7 lines
MAINTAINERS +1 -0
@@ -936,6 +936,7 @@ F: hw/ppc/mac_oldworld.c
 F: hw/pci-host/grackle.c
 F: hw/misc/macio/
 F: hw/intc/heathrow_pic.c
+F: include/hw/intc/heathrow_pic.h
 
 PReP
 M: Hervé Poussineau <[email protected]>
Reviewed-by Mark Cave-Ayland <[email protected]>

ATB,

Mark.

Applied
#29 lore raw

Re: [Qemu-devel] [Qemu-trivial] [PATCH for-3.1 08/25] MAINTAINERS: Add a missing entry for the Old World machines

In reply to Philippe Mathieu-Daudé
Quoted 11 lines · Philippe Mathieu-Daudé
Signed-off-by Philippe Mathieu-Daudé <[email protected]>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)
MAINTAINERS +0 -0
index 81a22b2ccf..aa51ae813b 100644

MAINTAINERS F: hw/ppc/mac_oldworld.c · line 942

Quoted 7 lines
MAINTAINERS +1 -0
@@ -936,6 +936,7 @@ F: hw/ppc/mac_oldworld.c
 F: hw/pci-host/grackle.c
 F: hw/misc/macio/
 F: hw/intc/heathrow_pic.c
+F: include/hw/intc/heathrow_pic.h
 
 PReP
 M: Hervé Poussineau <[email protected]>

Applied to my trivial-patches branch.

Thanks,
Laurent

author
#30 lore raw

PATCH 9/25 MAINTAINERS: Add a missing entry for the sun4m machines

In reply to Philippe Mathieu-Daudé
Signed-off-by Philippe Mathieu-Daudé <[email protected]>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)
MAINTAINERS +1 -0
index aa51ae813b..ba9cd9ac2b 100644
@@ -1013,6 +1013,7 @@ F: hw/misc/eccmemctl.c
 F: hw/misc/slavio_misc.c
 F: include/hw/sparc/sparc32_dma.h
 F: pc-bios/openbios-sparc32
+F: include/hw/sparc/sun4m_iommu.h
 
 Sun4u
 M: Mark Cave-Ayland <[email protected]>
Signature · 1 line
2.17.2
Reviewed-by on v1 9/25
#31 lore raw

Re: [Qemu-devel] [PATCH for-3.1 09/25] MAINTAINERS: Add a missing entry for the sun4m machines

Quoted 10 lines · Philippe Mathieu-Daudé
Signed-off-by Philippe Mathieu-Daudé <[email protected]>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)
MAINTAINERS +0 -0
index aa51ae813b..ba9cd9ac2b 100644

MAINTAINERS F: hw/misc/eccmemctl.c · line 1019

Quoted 7 lines
MAINTAINERS +1 -0
@@ -1013,6 +1013,7 @@ F: hw/misc/eccmemctl.c
 F: hw/misc/slavio_misc.c
 F: include/hw/sparc/sparc32_dma.h
 F: pc-bios/openbios-sparc32
+F: include/hw/sparc/sun4m_iommu.h
 
 Sun4u
 M: Mark Cave-Ayland <[email protected]>
Reviewed-by Mark Cave-Ayland <[email protected]>

ATB,

Mark.

author
#32 lore raw

PATCH 10/25 MAINTAINERS: Add missing entries for the sun4u machines

In reply to Philippe Mathieu-Daudé
Signed-off-by Philippe Mathieu-Daudé <[email protected]>
---
 MAINTAINERS | 4 ++++
 1 file changed, 4 insertions(+)
MAINTAINERS +4 -0
index ba9cd9ac2b..d9cddb0cc8 100644
@@ -1019,6 +1019,10 @@ Sun4u
 M: Mark Cave-Ayland <[email protected]>
 S: Maintained
 F: hw/sparc64/sun4u.c
+F: hw/sparc64/sun4u_iommu.c
+F: include/hw/sparc/sun4u_iommu.h
+F: hw/pci-host/sabre.c
+F: include/hw/pci-host/sabre.h
 F: pc-bios/openbios-sparc64
 
 Sun4v
Signature · 1 line
2.17.2
Reviewed-by on v1 10/25
#33 lore raw

Re: [Qemu-devel] [PATCH for-3.1 10/25] MAINTAINERS: Add missing entries for the sun4u machines

Quoted 10 lines · Philippe Mathieu-Daudé
Signed-off-by Philippe Mathieu-Daudé <[email protected]>
---
 MAINTAINERS | 4 ++++
 1 file changed, 4 insertions(+)
MAINTAINERS +0 -0
index ba9cd9ac2b..d9cddb0cc8 100644

MAINTAINERS Sun4u · line 1026

Quoted 8 lines
MAINTAINERS +4 -0
@@ -1019,6 +1019,10 @@ Sun4u
 M: Mark Cave-Ayland <[email protected]>
 S: Maintained
 F: hw/sparc64/sun4u.c
+F: hw/sparc64/sun4u_iommu.c
+F: include/hw/sparc/sun4u_iommu.h
+F: hw/pci-host/sabre.c
+F: include/hw/pci-host/sabre.h
 F: pc-bios/openbios-sparc64

These are correct, however you also want to add the simba PCI bridges i.e.

F: hw/pci-bridge/simba.c
F: include/hw/pci-bridge/simba.h

So with that:

Reviewed-by Mark Cave-Ayland <[email protected]>

ATB,

Mark.

author
#34 lore raw

Re: [Qemu-devel] [PATCH for-3.1 10/25] MAINTAINERS: Add missing entries for the sun4u machines

Quoted 23 lines · Mark Cave-Ayland
Quoted 10 lines · Philippe Mathieu-Daudé
Signed-off-by Philippe Mathieu-Daudé <[email protected]>
---
 MAINTAINERS | 4 ++++
 1 file changed, 4 insertions(+)
MAINTAINERS +0 -0
index ba9cd9ac2b..d9cddb0cc8 100644

MAINTAINERS Sun4u · line 1026

Quoted 8 lines
MAINTAINERS +4 -0
@@ -1019,6 +1019,10 @@ Sun4u
 M: Mark Cave-Ayland <[email protected]>
 S: Maintained
 F: hw/sparc64/sun4u.c
+F: hw/sparc64/sun4u_iommu.c
+F: include/hw/sparc/sun4u_iommu.h
+F: hw/pci-host/sabre.c
+F: include/hw/pci-host/sabre.h
 F: pc-bios/openbios-sparc64

These are correct, however you also want to add the simba PCI bridges i.e.

Quoted 2 lines

F: hw/pci-bridge/simba.c
F: include/hw/pci-bridge/simba.h

OK, will update.

Quoted 4 lines

So with that:

Reviewed-by Mark Cave-Ayland <[email protected]>

Thanks!

Phil.

author
#35 lore raw

PATCH 11/25 MAINTAINERS: Add missing entries for the PC machines

In reply to Philippe Mathieu-Daudé
Signed-off-by Philippe Mathieu-Daudé <[email protected]>
---
 MAINTAINERS | 4 ++++
 1 file changed, 4 insertions(+)
MAINTAINERS +4 -0
index d9cddb0cc8..9f89e37a1e 100644
@@ -1101,6 +1101,10 @@ F: hw/acpi/ich9.c
 F: include/hw/acpi/ich9.h
 F: include/hw/acpi/piix4.h
 F: hw/misc/sga.c
+F: hw/isa/apm.c
+F: include/hw/isa/apm.h
+F: tests/test-x86-cpuid.c
+F: tests/test-x86-cpuid-compat.c
 
 PC Chipset
 M: Michael S. Tsirkin <[email protected]>
Signature · 1 line
2.17.2
author
#36 lore raw

PATCH 12/25 MAINTAINERS: Add missing entries to the PC Chipset section

In reply to Philippe Mathieu-Daudé
Signed-off-by Philippe Mathieu-Daudé <[email protected]>
---
 MAINTAINERS | 2 ++
 1 file changed, 2 insertions(+)
MAINTAINERS +2 -0
index 9f89e37a1e..bfe71f2555 100644
@@ -1126,11 +1126,13 @@ F: hw/timer/hpet*
 F: hw/timer/i8254*
 F: hw/timer/mc146818rtc*
 F: hw/watchdog/wdt_ib700.c
+F: hw/watchdog/wdt_i6300esb.c
 F: include/hw/display/vga.h
 F: include/hw/char/parallel.h
 F: include/hw/dma/i8257.h
 F: include/hw/i2c/pm_smbus.h
 F: include/hw/input/i8042.h
+F: include/hw/isa/i8259_internal.h
 F: include/hw/isa/superio.h
 F: include/hw/timer/hpet.h
 F: include/hw/timer/i8254*
Signature · 1 line
2.17.2
Reviewed-by on v1 12/25
#37 lore raw

Re: [Qemu-devel] [PATCH for-3.1 12/25] MAINTAINERS: Add missing entries to the PC Chipset section

Quoted 13 lines · Philippe Mathieu-Daudé
Signed-off-by Philippe Mathieu-Daudé <[email protected]>
---
 MAINTAINERS | 2 ++
 1 file changed, 2 insertions(+)
MAINTAINERS +0 -0
index 9f89e37a1e..bfe71f2555 100644
@@ -1126,11 +1126,13 @@ F: hw/timer/hpet*
 F: hw/timer/i8254*
 F: hw/timer/mc146818rtc*
 F: hw/watchdog/wdt_ib700.c

MAINTAINERS F: hw/timer/hpet* · line 1138

Quoted 10 lines
MAINTAINERS +2 -0
+F: hw/watchdog/wdt_i6300esb.c
 F: include/hw/display/vga.h
 F: include/hw/char/parallel.h
 F: include/hw/dma/i8257.h
 F: include/hw/i2c/pm_smbus.h
 F: include/hw/input/i8042.h
+F: include/hw/isa/i8259_internal.h
 F: include/hw/isa/superio.h
 F: include/hw/timer/hpet.h
 F: include/hw/timer/i8254*
Reviewed-by Thomas Huth <[email protected]>
Applied
#38 lore raw

Re: [Qemu-devel] [Qemu-trivial] [PATCH for-3.1 12/25] MAINTAINERS: Add missing entries to the PC Chipset section

In reply to Philippe Mathieu-Daudé
Quoted 14 lines · Philippe Mathieu-Daudé
Signed-off-by Philippe Mathieu-Daudé <[email protected]>
---
 MAINTAINERS | 2 ++
 1 file changed, 2 insertions(+)
MAINTAINERS +0 -0
index 9f89e37a1e..bfe71f2555 100644
@@ -1126,11 +1126,13 @@ F: hw/timer/hpet*
 F: hw/timer/i8254*
 F: hw/timer/mc146818rtc*
 F: hw/watchdog/wdt_ib700.c

MAINTAINERS F: hw/timer/hpet* · line 1138

Quoted 10 lines
MAINTAINERS +2 -0
+F: hw/watchdog/wdt_i6300esb.c
 F: include/hw/display/vga.h
 F: include/hw/char/parallel.h
 F: include/hw/dma/i8257.h
 F: include/hw/i2c/pm_smbus.h
 F: include/hw/input/i8042.h
+F: include/hw/isa/i8259_internal.h
 F: include/hw/isa/superio.h
 F: include/hw/timer/hpet.h
 F: include/hw/timer/i8254*

Applied to my trivial-patches branch.

Thanks,
Laurent

author
#39 lore raw

PATCH 13/25 MAINTAINERS: Add missing entries to VFIO

In reply to Philippe Mathieu-Daudé
Signed-off-by Philippe Mathieu-Daudé <[email protected]>
---
 MAINTAINERS | 2 ++
 1 file changed, 2 insertions(+)
MAINTAINERS +2 -0
index bfe71f2555..e124792557 100644
@@ -1326,6 +1326,8 @@ M: Alex Williamson <[email protected]>
 S: Supported
 F: hw/vfio/*
 F: include/hw/vfio/
+F: include/qemu/vfio-helpers.h
+F: docs/igd-assign.txt
 
 vfio-ccw
 M: Cornelia Huck <[email protected]>
Signature · 1 line
2.17.2
Reviewed-by on v1 13/25
#40 lore raw

Re: [Qemu-devel] [PATCH for-3.1 13/25] MAINTAINERS: Add missing entries to VFIO

Quoted 10 lines · Philippe Mathieu-Daudé
Signed-off-by Philippe Mathieu-Daudé <[email protected]>
---
 MAINTAINERS | 2 ++
 1 file changed, 2 insertions(+)
MAINTAINERS +0 -0
index bfe71f2555..e124792557 100644

MAINTAINERS M: Alex Williamson <[email protected]> · line 1330

Quoted 5 lines
MAINTAINERS +2 -0
@@ -1326,6 +1326,8 @@ M: Alex Williamson <[email protected]>
 S: Supported
 F: hw/vfio/*
 F: include/hw/vfio/
+F: include/qemu/vfio-helpers.h
+F: docs/igd-assign.txt

Sounds reasonable to me.

Reviewed-by Thomas Huth <[email protected]>
Applied
#41 lore raw

Re: [Qemu-devel] [Qemu-trivial] [PATCH for-3.1 13/25] MAINTAINERS: Add missing entries to VFIO

In reply to Philippe Mathieu-Daudé
Quoted 11 lines · Philippe Mathieu-Daudé
Signed-off-by Philippe Mathieu-Daudé <[email protected]>
---
 MAINTAINERS | 2 ++
 1 file changed, 2 insertions(+)
MAINTAINERS +0 -0
index bfe71f2555..e124792557 100644

MAINTAINERS M: Alex Williamson <[email protected]> · line 1333

Quoted 8 lines
MAINTAINERS +2 -0
@@ -1326,6 +1326,8 @@ M: Alex Williamson <[email protected]>
 S: Supported
 F: hw/vfio/*
 F: include/hw/vfio/
+F: include/qemu/vfio-helpers.h
+F: docs/igd-assign.txt
 
 vfio-ccw
 M: Cornelia Huck <[email protected]>

Applied to my trivial-patches branch.

Thanks,
Laurent

#42 lore raw

Re: [Qemu-devel] [PATCH for-3.1 13/25] MAINTAINERS: Add missing entries to VFIO

In reply to Philippe Mathieu-Daudé
Quoted 10 lines · On Sun, 25 Nov 2018 21:49:48 +0100 Philippe Mathieu-Daudé <[email protected]>…
Signed-off-by Philippe Mathieu-Daudé <[email protected]>
---
 MAINTAINERS | 2 ++
 1 file changed, 2 insertions(+)
MAINTAINERS +0 -0
index bfe71f2555..e124792557 100644

MAINTAINERS M: Alex Williamson <[email protected]> · line 1329

Quoted 4 lines
MAINTAINERS +1 -0
@@ -1326,6 +1326,8 @@ M: Alex Williamson <[email protected]>
 S: Supported
 F: hw/vfio/*
 F: include/hw/vfio/
+F: include/qemu/vfio-helpers.h

This misses util/vfio-helpers.c, both of which are contributed by Fam and currently only used by nvme. I really haven't done anything with them, so they should probably be under the NVMe block driver, but if it makes more sense for me to look after them, I can start paying more attention to them. I'm not sure signing someone up for new files they've never touched counts as trivial ;) Thanks,

Alex

Quoted 4 lines
MAINTAINERS +1 -0
+F: docs/igd-assign.txt
 
 vfio-ccw
 M: Cornelia Huck <[email protected]>
author
#43 lore raw

Re: [Qemu-devel] [PATCH for-3.1 13/25] MAINTAINERS: Add missing entries to VFIO

Quoted 8 lines · Alex Williamson
Quoted 5 lines · On Sun, 25 Nov 2018 21:49:48 +0100 Philippe Mathieu-Daudé <[email protected]>…
Signed-off-by Philippe Mathieu-Daudé <[email protected]>
---
 MAINTAINERS | 2 ++
 1 file changed, 2 insertions(+)
Quoted 16 lines

MAINTAINERS M: Alex Williamson <[email protected]> · line 1329

Quoted 9 lines
MAINTAINERS +1 -0
index bfe71f2555..e124792557 100644
@@ -1326,6 +1326,8 @@ M: Alex Williamson <[email protected]>
 S: Supported
 F: hw/vfio/*
 F: include/hw/vfio/
+F: include/qemu/vfio-helpers.h

This misses util/vfio-helpers.c, both of which are contributed by Fam and currently only used by nvme. I really haven't done anything with them, so they should probably be under the NVMe block driver, but if it makes more sense for me to look after them, I can start paying more attention to them. I'm not sure signing someone up for new files they've never touched counts as trivial ;) Thanks,

OK (Cc'ed Fam).

Laurent, can you unqueue this patch? (sorry).

Thanks,

Phil.

Quoted 8 lines

Alex

Quoted 4 lines
MAINTAINERS +1 -0
+F: docs/igd-assign.txt
 
 vfio-ccw
 M: Cornelia Huck <[email protected]>
#44 lore raw

Re: [Qemu-devel] [PATCH for-3.1 13/25] MAINTAINERS: Add missing entries to VFIO

In reply to Alex Williamson
Quoted 8 lines · Alex Williamson
Quoted 5 lines · On Sun, 25 Nov 2018 21:49:48 +0100 Philippe Mathieu-Daudé <[email protected]>…
Signed-off-by Philippe Mathieu-Daudé <[email protected]>
---
 MAINTAINERS | 2 ++
 1 file changed, 2 insertions(+)
Quoted 16 lines

MAINTAINERS M: Alex Williamson <[email protected]> · line 1329

Quoted 9 lines
MAINTAINERS +1 -0
index bfe71f2555..e124792557 100644
@@ -1326,6 +1326,8 @@ M: Alex Williamson <[email protected]>
 S: Supported
 F: hw/vfio/*
 F: include/hw/vfio/
+F: include/qemu/vfio-helpers.h

This misses util/vfio-helpers.c, both of which are contributed by Fam and currently only used by nvme. I really haven't done anything with them, so they should probably be under the NVMe block driver, but if it makes more sense for me to look after them, I can start paying more attention to them. I'm not sure signing someone up for new files they've never touched counts as trivial ;) Thanks,

Un-applied to my trivial-patches branch...

Thanks,
Laurent

author
#45 lore raw

PATCH 14/25 MAINTAINERS: Add missing entries to the vhost section

In reply to Philippe Mathieu-Daudé
Signed-off-by Philippe Mathieu-Daudé <[email protected]>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)
MAINTAINERS +1 -0
index e124792557..eab0fb9742 100644
@@ -1359,6 +1359,7 @@ M: Michael S. Tsirkin <[email protected]>
 S: Supported
 F: hw/*/*vhost*
 F: docs/interop/vhost-user.txt
+F: contrib/vhost-user-*/
 
 virtio
 M: Michael S. Tsirkin <[email protected]>
Signature · 1 line
2.17.2
Reviewed-by on v1 14/25
#46 lore raw

Re: [Qemu-devel] [PATCH for-3.1 14/25] MAINTAINERS: Add missing entries to the vhost section

Quoted 11 lines · Philippe Mathieu-Daudé
Signed-off-by Philippe Mathieu-Daudé <[email protected]>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)
MAINTAINERS +0 -0
index e124792557..eab0fb9742 100644

MAINTAINERS M: Michael S. Tsirkin <[email protected]> · line 1365

Quoted 7 lines
MAINTAINERS +1 -0
@@ -1359,6 +1359,7 @@ M: Michael S. Tsirkin <[email protected]>
 S: Supported
 F: hw/*/*vhost*
 F: docs/interop/vhost-user.txt
+F: contrib/vhost-user-*/
 
 virtio
 M: Michael S. Tsirkin <[email protected]>
Reviewed-by Thomas Huth <[email protected]>
Applied
#47 lore raw

Re: [Qemu-devel] [Qemu-trivial] [PATCH for-3.1 14/25] MAINTAINERS: Add missing entries to the vhost section

In reply to Philippe Mathieu-Daudé
Quoted 11 lines · Philippe Mathieu-Daudé
Signed-off-by Philippe Mathieu-Daudé <[email protected]>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)
MAINTAINERS +0 -0
index e124792557..eab0fb9742 100644

MAINTAINERS M: Michael S. Tsirkin <[email protected]> · line 1365

Quoted 7 lines
MAINTAINERS +1 -0
@@ -1359,6 +1359,7 @@ M: Michael S. Tsirkin <[email protected]>
 S: Supported
 F: hw/*/*vhost*
 F: docs/interop/vhost-user.txt
+F: contrib/vhost-user-*/
 
 virtio
 M: Michael S. Tsirkin <[email protected]>

Applied to my trivial-patches branch.

Thanks,
Laurent

author
#48 lore raw

PATCH 15/25 MAINTAINERS: Add missing entries for the Canon DIGIC machine

In reply to Philippe Mathieu-Daudé

This pattern now also matches:
- include/hw/timer/digic-timer.h
- include/hw/char/digic-uart.h

Signed-off-by Philippe Mathieu-Daudé <[email protected]>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)
MAINTAINERS +1 -0
index eab0fb9742..e04f2f1a44 100644
@@ -527,6 +527,7 @@ L: [email protected]
 S: Odd Fixes
 F: include/hw/arm/digic.h
 F: hw/*/digic*
+F: include/hw/*/digic*
 
 Gumstix
 M: Peter Maydell <[email protected]>
Signature · 1 line
2.17.2
Reviewed-by on v1 15/25
#49 lore raw

Re: [Qemu-arm] [PATCH for-3.1 15/25] MAINTAINERS: Add missing entries for the Canon DIGIC machine

Quoted 15 lines · Philippe Mathieu-Daudé

This pattern now also matches:
- include/hw/timer/digic-timer.h
- include/hw/char/digic-uart.h

Signed-off-by Philippe Mathieu-Daudé <[email protected]>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)
MAINTAINERS +0 -0
index eab0fb9742..e04f2f1a44 100644

MAINTAINERS L: [email protected] · line 533

Quoted 7 lines
MAINTAINERS +1 -0
@@ -527,6 +527,7 @@ L: [email protected]
 S: Odd Fixes
 F: include/hw/arm/digic.h
 F: hw/*/digic*
+F: include/hw/*/digic*
 
 Gumstix
 M: Peter Maydell <[email protected]>
Reviewed-by Peter Maydell <[email protected]>

thanks
-- PMM

Applied
#50 lore raw

Re: [Qemu-arm] [Qemu-trivial] [PATCH for-3.1 15/25] MAINTAINERS: Add missing entries for the Canon DIGIC machine

In reply to Philippe Mathieu-Daudé
Quoted 15 lines · Philippe Mathieu-Daudé

This pattern now also matches:
- include/hw/timer/digic-timer.h
- include/hw/char/digic-uart.h

Signed-off-by Philippe Mathieu-Daudé <[email protected]>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)
MAINTAINERS +0 -0
index eab0fb9742..e04f2f1a44 100644

MAINTAINERS L: [email protected] · line 533

Quoted 7 lines
MAINTAINERS +1 -0
@@ -527,6 +527,7 @@ L: [email protected]
 S: Odd Fixes
 F: include/hw/arm/digic.h
 F: hw/*/digic*
+F: include/hw/*/digic*
 
 Gumstix
 M: Peter Maydell <[email protected]>

Applied to my trivial-patches branch.

Thanks,
Laurent

author
#51 lore raw

PATCH 16/25 MAINTAINERS: Add missing entries for the MPS2 machine

In reply to Philippe Mathieu-Daudé

Missed in de343bb632a.

Signed-off-by Philippe Mathieu-Daudé <[email protected]>
---
 MAINTAINERS | 2 ++
 1 file changed, 2 insertions(+)
MAINTAINERS +2 -0
index e04f2f1a44..2795135a09 100644
@@ -587,6 +587,8 @@ F: hw/misc/mps2-*.c
 F: include/hw/misc/mps2-*.h
 F: hw/arm/iotkit.c
 F: include/hw/arm/iotkit.h
+F: hw/misc/iotkit-secctl.c
+F: include/hw/misc/iotkit-secctl.h
 F: hw/misc/iotkit-sysctl.c
 F: include/hw/misc/iotkit-sysctl.h
 F: hw/misc/iotkit-sysinfo.c
Signature · 1 line
2.17.2
Reviewed-by on v1 16/25
#52 lore raw

Re: [Qemu-devel] [PATCH for-3.1 16/25] MAINTAINERS: Add missing entries for the MPS2 machine

Quoted 13 lines · Philippe Mathieu-Daudé

Missed in de343bb632a.

Signed-off-by Philippe Mathieu-Daudé <[email protected]>
---
 MAINTAINERS | 2 ++
 1 file changed, 2 insertions(+)
MAINTAINERS +0 -0
index e04f2f1a44..2795135a09 100644

MAINTAINERS F: hw/misc/mps2-*.c

Quoted 9 lines
MAINTAINERS +2 -1
@@ -587,6 +587,8 @@ F: hw/misc/mps2-*.c
 F: include/hw/misc/mps2-*.h
 F: hw/arm/iotkit.c
 F: include/hw/arm/iotkit.h
+F: hw/misc/iotkit-secctl.c
+F: include/hw/misc/iotkit-secctl.h
 F: hw/misc/iotkit-sysctl.c
 F: include/hw/misc/iotkit-sysctl.h
 F: hw/misc/iotkit-sysinfo.c
--
Reviewed-by Peter Maydell <[email protected]>

thanks
-- PMM

Applied
#53 lore raw

Re: [Qemu-arm] [Qemu-trivial] [PATCH for-3.1 16/25] MAINTAINERS: Add missing entries for the MPS2 machine

In reply to Philippe Mathieu-Daudé
Quoted 13 lines · Philippe Mathieu-Daudé

Missed in de343bb632a.

Signed-off-by Philippe Mathieu-Daudé <[email protected]>
---
 MAINTAINERS | 2 ++
 1 file changed, 2 insertions(+)
MAINTAINERS +0 -0
index e04f2f1a44..2795135a09 100644

MAINTAINERS F: hw/misc/mps2-*.c · line 594

Quoted 8 lines
MAINTAINERS +2 -0
@@ -587,6 +587,8 @@ F: hw/misc/mps2-*.c
 F: include/hw/misc/mps2-*.h
 F: hw/arm/iotkit.c
 F: include/hw/arm/iotkit.h
+F: hw/misc/iotkit-secctl.c
+F: include/hw/misc/iotkit-secctl.h
 F: hw/misc/iotkit-sysctl.c
 F: include/hw/misc/iotkit-sysctl.h
 F: hw/misc/iotkit-sysinfo.c

Applied to my trivial-patches branch.

Thanks,
Laurent

author
#54 lore raw

PATCH 17/25 MAINTAINERS: Add a missing entry to SPICE

In reply to Philippe Mathieu-Daudé
Signed-off-by Philippe Mathieu-Daudé <[email protected]>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)
MAINTAINERS +1 -0
index 2795135a09..28e5038c73 100644
@@ -1736,6 +1736,7 @@ F: ui/spice-*.c
 F: audio/spiceaudio.c
 F: hw/display/qxl*
 F: qapi/ui.json
+F: docs/spice-port-fqdn.txt
 
 Graphics
 M: Gerd Hoffmann <[email protected]>
Signature · 1 line
2.17.2
Reviewed-by on v1 17/25
#55 lore raw

Re: [Qemu-devel] [PATCH for-3.1 17/25] MAINTAINERS: Add a missing entry to SPICE

Quoted 10 lines · Philippe Mathieu-Daudé
Signed-off-by Philippe Mathieu-Daudé <[email protected]>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)
MAINTAINERS +0 -0
index 2795135a09..28e5038c73 100644

MAINTAINERS F: ui/spice-*.c · line 1739

Quoted 4 lines
MAINTAINERS +1 -0
@@ -1736,6 +1736,7 @@ F: ui/spice-*.c
 F: audio/spiceaudio.c
 F: hw/display/qxl*
 F: qapi/ui.json
+F: docs/spice-port-fqdn.txt
Reviewed-by Gerd Hoffmann <[email protected]>
author
#56 lore raw

PATCH 18/25 MAINTAINERS: Add missing entries for the QObject section

In reply to Philippe Mathieu-Daudé
Signed-off-by Philippe Mathieu-Daudé <[email protected]>
---
 MAINTAINERS | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)
MAINTAINERS +7 -1
index 28e5038c73..ac5d25491f 100644
@@ -1846,12 +1846,18 @@ S: Supported
 F: qobject/
 F: include/qapi/qmp/
 X: include/qapi/qmp/dispatch.h
+F: include/qemu/qdist.h
 F: scripts/coccinelle/qobject.cocci
 F: tests/check-qdict.c
-F: tests/check-qnum.c
 F: tests/check-qjson.c
 F: tests/check-qlist.c
+F: tests/check-qlit.c
+F: tests/check-qnull.c
+F: tests/check-qnum.c
+F: tests/check-qobject.c
 F: tests/check-qstring.c
+F: tests/test-qdist.c
+F: qdict-test-data.txt
 T: git https://repo.or.cz/qemu/armbru.git qapi-next
 
 QEMU Guest Agent
Signature · 1 line
2.17.2
#57 lore raw

Re: [Qemu-devel] [PATCH for-3.1 18/25] MAINTAINERS: Add missing entries for the QObject section

Quoted 10 lines · Philippe Mathieu-Daudé
Signed-off-by Philippe Mathieu-Daudé <[email protected]>
---
 MAINTAINERS | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)
MAINTAINERS +0 -0
index 28e5038c73..ac5d25491f 100644

MAINTAINERS S: Supported · line 1849

Quoted 4 lines
MAINTAINERS +1 -0
@@ -1846,12 +1846,18 @@ S: Supported
 F: qobject/
 F: include/qapi/qmp/
 X: include/qapi/qmp/dispatch.h
+F: include/qemu/qdist.h

This isn't part of QObject.

MAINTAINERS S: Supported · line 1857

Quoted 9 lines
MAINTAINERS +4 -1
 F: scripts/coccinelle/qobject.cocci
 F: tests/check-qdict.c
-F: tests/check-qnum.c
 F: tests/check-qjson.c
 F: tests/check-qlist.c
+F: tests/check-qlit.c
+F: tests/check-qnull.c
+F: tests/check-qnum.c
+F: tests/check-qobject.c

There are good.

MAINTAINERS S: Supported · line 1859

Quoted 2 lines
MAINTAINERS +1 -0
 F: tests/check-qstring.c
+F: tests/test-qdist.c

Not part of QObject.

MAINTAINERS S: Supported · line 1860

Quoted 1 line
MAINTAINERS +1 -0
+F: qdict-test-data.txt

Good. Should be moved to tests/, but not in this series.

Quoted 3 lines
MAINTAINERS +0 -0
 T: git https://repo.or.cz/qemu/armbru.git qapi-next
 
 QEMU Guest Agent
author
#58 lore raw

PATCH 19/25 MAINTAINERS: Add a missing entry to the QMP section

In reply to Philippe Mathieu-Daudé
Signed-off-by Philippe Mathieu-Daudé <[email protected]>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)
MAINTAINERS +1 -0
index ac5d25491f..c73dde10a5 100644
@@ -1887,6 +1887,7 @@ S: Supported
 F: qmp.c
 F: monitor.c
 F: docs/devel/*qmp-*
+F: docs/interop/*qmp-*
 F: scripts/qmp/
 F: tests/qmp-test.c
 F: tests/qmp-cmd-test.c
Signature · 1 line
2.17.2
Reviewed-by on v1 19/25
#59 lore raw

Re: [Qemu-devel] [PATCH for-3.1 19/25] MAINTAINERS: Add a missing entry to the QMP section

Quoted 10 lines · Philippe Mathieu-Daudé
Signed-off-by Philippe Mathieu-Daudé <[email protected]>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)
MAINTAINERS +0 -0
index ac5d25491f..c73dde10a5 100644

MAINTAINERS S: Supported · line 1893

Quoted 7 lines
MAINTAINERS +1 -0
@@ -1887,6 +1887,7 @@ S: Supported
 F: qmp.c
 F: monitor.c
 F: docs/devel/*qmp-*
+F: docs/interop/*qmp-*
 F: scripts/qmp/
 F: tests/qmp-test.c
 F: tests/qmp-cmd-test.c
Reviewed-by Markus Armbruster <[email protected]>
Applied
#60 lore raw

Re: [Qemu-devel] [Qemu-trivial] [PATCH for-3.1 19/25] MAINTAINERS: Add a missing entry to the QMP section

In reply to Philippe Mathieu-Daudé
Quoted 11 lines · Philippe Mathieu-Daudé
Signed-off-by Philippe Mathieu-Daudé <[email protected]>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)
MAINTAINERS +0 -0
index ac5d25491f..c73dde10a5 100644

MAINTAINERS S: Supported · line 1893

Quoted 7 lines
MAINTAINERS +1 -0
@@ -1887,6 +1887,7 @@ S: Supported
 F: qmp.c
 F: monitor.c
 F: docs/devel/*qmp-*
+F: docs/interop/*qmp-*
 F: scripts/qmp/
 F: tests/qmp-test.c
 F: tests/qmp-cmd-test.c

Applied to my trivial-patches branch.

Thanks,
Laurent

author
#61 lore raw

PATCH 20/25 MAINTAINERS: Add missing test entries to the Cryptography section

In reply to Philippe Mathieu-Daudé
Signed-off-by Philippe Mathieu-Daudé <[email protected]>
---
 MAINTAINERS | 2 ++
 1 file changed, 2 insertions(+)
MAINTAINERS +2 -0
index c73dde10a5..26727c1561 100644
@@ -1978,6 +1978,8 @@ F: crypto/
 F: include/crypto/
 F: tests/test-crypto-*
 F: tests/benchmark-crypto-*
+F: tests/crypto-tls-*
+F: tests/pkix_asn1_tab.c
 F: qemu.sasl
 
 Coroutines
Signature · 1 line
2.17.2
Acked-by on v1 20/25
#62 lore raw

Re: [Qemu-devel] [PATCH for-3.1 20/25] MAINTAINERS: Add missing test entries to the Cryptography section

Quoted 4 lines · Philippe Mathieu-Daudé
Signed-off-by Philippe Mathieu-Daudé <[email protected]>
---
 MAINTAINERS | 2 ++
 1 file changed, 2 insertions(+)
Acked-by Daniel P. Berrangé <[email protected]>

MAINTAINERS F: crypto/ · line 1983

Quoted 12 lines
MAINTAINERS +2 -0
index c73dde10a5..26727c1561 100644
@@ -1978,6 +1978,8 @@ F: crypto/
 F: include/crypto/
 F: tests/test-crypto-*
 F: tests/benchmark-crypto-*
+F: tests/crypto-tls-*
+F: tests/pkix_asn1_tab.c
 F: qemu.sasl

Regards,
Daniel

Signature · 3 lines
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|
author
#63 lore raw

PATCH 21/25 MAINTAINERS: Add a missing entry for the NVDIMM device

In reply to Philippe Mathieu-Daudé
Signed-off-by Philippe Mathieu-Daudé <[email protected]>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)
MAINTAINERS +1 -0
index 26727c1561..92691589b1 100644
@@ -1475,6 +1475,7 @@ S: Maintained
 F: hw/acpi/nvdimm.c
 F: hw/mem/nvdimm.c
 F: include/hw/mem/nvdimm.h
+F: docs/nvdimm.txt
 
 e1000x
 M: Dmitry Fleytman <[email protected]>
Signature · 1 line
2.17.2
Reviewed-by on v1 21/25
#64 lore raw

Re: [Qemu-devel] [PATCH for-3.1 21/25] MAINTAINERS: Add a missing entry for the NVDIMM device

Quoted 11 lines · Philippe Mathieu-Daudé
Signed-off-by Philippe Mathieu-Daudé <[email protected]>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)
MAINTAINERS +0 -0
index 26727c1561..92691589b1 100644

MAINTAINERS S: Maintained · line 1481

Quoted 7 lines
MAINTAINERS +1 -0
@@ -1475,6 +1475,7 @@ S: Maintained
 F: hw/acpi/nvdimm.c
 F: hw/mem/nvdimm.c
 F: include/hw/mem/nvdimm.h
+F: docs/nvdimm.txt
 
 e1000x
 M: Dmitry Fleytman <[email protected]>
Reviewed-by Thomas Huth <[email protected]>
Applied
#65 lore raw

Re: [Qemu-devel] [Qemu-trivial] [PATCH for-3.1 21/25] MAINTAINERS: Add a missing entry for the NVDIMM device

In reply to Philippe Mathieu-Daudé
Quoted 11 lines · Philippe Mathieu-Daudé
Signed-off-by Philippe Mathieu-Daudé <[email protected]>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)
MAINTAINERS +0 -0
index 26727c1561..92691589b1 100644

MAINTAINERS S: Maintained · line 1481

Quoted 7 lines
MAINTAINERS +1 -0
@@ -1475,6 +1475,7 @@ S: Maintained
 F: hw/acpi/nvdimm.c
 F: hw/mem/nvdimm.c
 F: include/hw/mem/nvdimm.h
+F: docs/nvdimm.txt
 
 e1000x
 M: Dmitry Fleytman <[email protected]>

Applied to my trivial-patches branch.

Thanks,
Laurent

author
#66 lore raw

PATCH 22/25 MAINTAINERS: Add a missing entry to the New World machines

In reply to Philippe Mathieu-Daudé

The CHRP NVRAM has his own section, but since the New World section contains the mac_nvram.c, it makes sens to also monitor the corresponding header.

Signed-off-by Philippe Mathieu-Daudé <[email protected]>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)
MAINTAINERS +1 -0
index 92691589b1..a248c8c564 100644
@@ -930,6 +930,7 @@ F: hw/nvram/mac_nvram.c
 F: include/hw/misc/macio/
 F: include/hw/misc/mos6522.h
 F: include/hw/ppc/mac_dbdma.h
+F: include/hw/nvram/chrp_nvram.h
 
 Old World
 M: David Gibson <[email protected]>
Signature · 1 line
2.17.2
#67 lore raw

Re: [Qemu-devel] [PATCH for-3.1 22/25] MAINTAINERS: Add a missing entry to the New World machines

Quoted 14 lines · Philippe Mathieu-Daudé

The CHRP NVRAM has his own section, but since the New World section contains the mac_nvram.c, it makes sens to also monitor the corresponding header.

Signed-off-by Philippe Mathieu-Daudé <[email protected]>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)
MAINTAINERS +0 -0
index 92691589b1..a248c8c564 100644

MAINTAINERS F: hw/nvram/mac_nvram.c · line 933

Quoted 4 lines
MAINTAINERS +1 -0
@@ -930,6 +930,7 @@ F: hw/nvram/mac_nvram.c
 F: include/hw/misc/macio/
 F: include/hw/misc/mos6522.h
 F: include/hw/ppc/mac_dbdma.h
+F: include/hw/nvram/chrp_nvram.h

I don't see the point why we should add duplicated entries here? The header is also used by the Sparc machines, so why should this be added additionally to the Mac machines only here, too? I suggest to drop this patch.

Thomas

author
#68 lore raw

Re: [Qemu-devel] [PATCH for-3.1 22/25] MAINTAINERS: Add a missing entry to the New World machines

Quoted 10 lines · Thomas Huth
Quoted 9 lines · Philippe Mathieu-Daudé

The CHRP NVRAM has his own section, but since the New World section contains the mac_nvram.c, it makes sens to also monitor the corresponding header.

Signed-off-by Philippe Mathieu-Daudé <[email protected]>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)
Quoted 14 lines

MAINTAINERS F: hw/nvram/mac_nvram.c · line 933

Quoted 9 lines
MAINTAINERS +1 -0
index 92691589b1..a248c8c564 100644
@@ -930,6 +930,7 @@ F: hw/nvram/mac_nvram.c
 F: include/hw/misc/macio/
 F: include/hw/misc/mos6522.h
 F: include/hw/ppc/mac_dbdma.h
+F: include/hw/nvram/chrp_nvram.h

I don't see the point why we should add duplicated entries here? The header is also used by the Sparc machines, so why should this be added additionally to the Mac machines only here, too? I suggest to drop this patch.

OK, will drop.

author
#69 lore raw

PATCH 23/25 MAINTAINERS: Add an entry for the Dino machine

In reply to Philippe Mathieu-Daudé
Signed-off-by Philippe Mathieu-Daudé <[email protected]>
---
 MAINTAINERS | 9 +++++++++
 1 file changed, 9 insertions(+)
MAINTAINERS +9 -0
index a248c8c564..ad82c0377c 100644
@@ -879,6 +879,15 @@ F: hw/core/loader-fit.c
 F: hw/mips/boston.c
 F: hw/pci-host/xilinx-pcie.c
 
+HP-PARISC Machines
+------------------
+
+Dino
+M: Richard Henderson <[email protected]>
+S: Maintained
+F: hw/hppa/
+F: pc-bios/hppa-firmware.img
+
 OpenRISC Machines
 -----------------
 or1k-sim
Signature · 1 line
2.17.2
author
#70 lore raw

PATCH 24/25 MAINTAINERS: Use my work email to review Build and test automation patches

In reply to Philippe Mathieu-Daudé
Signed-off-by Philippe Mathieu-Daudé <[email protected]>
---
 MAINTAINERS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
MAINTAINERS +1 -1
index ad82c0377c..c616861ca3 100644
@@ -2388,7 +2388,7 @@ Build and test automation
 Build and test automation
 M: Alex Bennée <[email protected]>
 M: Fam Zheng <[email protected]>
-R: Philippe Mathieu-Daudé <[email protected]>
+R: Philippe Mathieu-Daudé <[email protected]>
 L: [email protected]
 S: Maintained
 F: .travis.yml
Signature · 1 line
2.17.2
Reviewed-by on v1 24/25
#71 lore raw

Re: [Qemu-devel] [PATCH for-3.1 24/25] MAINTAINERS: Use my work email to review Build and test automation patches

Quoted 11 lines · Philippe Mathieu-Daudé
Signed-off-by Philippe Mathieu-Daudé <[email protected]>
---
 MAINTAINERS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
MAINTAINERS +0 -0
index ad82c0377c..c616861ca3 100644

MAINTAINERS Build and test automation · line 2394

Quoted 8 lines
MAINTAINERS +1 -1
@@ -2388,7 +2388,7 @@ Build and test automation
 Build and test automation
 M: Alex Bennée <[email protected]>
 M: Fam Zheng <[email protected]>
-R: Philippe Mathieu-Daudé <[email protected]>
+R: Philippe Mathieu-Daudé <[email protected]>
 L: [email protected]
 S: Maintained
 F: .travis.yml
Reviewed-by Thomas Huth <[email protected]>
Applied
#72 lore raw

Re: [Qemu-devel] [Qemu-trivial] [PATCH for-3.1 24/25] MAINTAINERS: Use my work email to review Build and test automation patches

In reply to Philippe Mathieu-Daudé
Quoted 11 lines · Philippe Mathieu-Daudé
Signed-off-by Philippe Mathieu-Daudé <[email protected]>
---
 MAINTAINERS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
MAINTAINERS +0 -0
index ad82c0377c..c616861ca3 100644

MAINTAINERS Build and test automation · line 2394

Quoted 8 lines
MAINTAINERS +1 -1
@@ -2388,7 +2388,7 @@ Build and test automation
 Build and test automation
 M: Alex Bennée <[email protected]>
 M: Fam Zheng <[email protected]>
-R: Philippe Mathieu-Daudé <[email protected]>
+R: Philippe Mathieu-Daudé <[email protected]>
 L: [email protected]
 S: Maintained
 F: .travis.yml

Applied to my trivial-patches branch.

Thanks,
Laurent

author
#73 lore raw

PATCH 25/25 MAINTAINERS: Remove duplicate entries of [email protected]

In reply to Philippe Mathieu-Daudé

The list is always selected by the 'All patches CC here' section.

Signed-off-by Philippe Mathieu-Daudé <[email protected]>
---
 MAINTAINERS | 13 -------------
 1 file changed, 13 deletions(-)
MAINTAINERS +0 -13
index c616861ca3..9d6dae71ff 100644
@@ -109,7 +109,6 @@ L: [email protected]
 Guest CPU cores (TCG):
 ----------------------
 Overall
-L: [email protected]
 M: Peter Crosthwaite <[email protected]>
 M: Richard Henderson <[email protected]>
 R: Paolo Bonzini <[email protected]>

@@ -403,30 +402,25 @@ Hosts:
 ------
 
 LINUX
-L: [email protected]
 S: Maintained
 F: linux-*
 F: linux-headers/
 
 POSIX
-L: [email protected]
 S: Maintained
 F: *posix*
 
 NETBSD
-L: [email protected]
 M: Kamil Rytarowski <[email protected]>
 S: Maintained
 K: ^Subject:.*(?i)NetBSD
 
 OPENBSD
-L: [email protected]
 M: Brad Smith <[email protected]>
 S: Maintained
 K: ^Subject:.*(?i)OpenBSD
 
 W32, W64
-L: [email protected]
 M: Stefan Weil <[email protected]>
 S: Maintained
 F: *win32*

@@ -532,7 +526,6 @@ F: include/hw/*/digic*
 Gumstix
 M: Peter Maydell <[email protected]>
 R: Philippe Mathieu-Daudé <[email protected]>
-L: [email protected]
 L: [email protected]
 S: Odd Fixes
 F: hw/arm/gumstix.c

@@ -953,7 +946,6 @@ F: include/hw/intc/heathrow_pic.h
 
 PReP
 M: Hervé Poussineau <[email protected]>
-L: [email protected]
 L: [email protected]
 S: Maintained
 F: hw/ppc/prep.c

@@ -1690,7 +1682,6 @@ S: Supported
 F: scripts/coverity-model.c
 
 CPU
-L: [email protected]
 S: Supported
 F: qom/cpu.c
 F: include/qom/cpu.h

@@ -1722,7 +1713,6 @@ F: util/error.c
 F: util/qemu-error.c
 
 GDB stub
-L: [email protected]
 S: Odd Fixes
 F: gdbstub*
 F: gdb-xml/

@@ -2124,7 +2114,6 @@ F: tcg/arm/
 F: disas/arm.c
 
 i386 target
-L: [email protected]
 S: Maintained
 F: tcg/i386/
 F: disas/i386.c

@@ -2389,7 +2378,6 @@ Build and test automation
 M: Alex Bennée <[email protected]>
 M: Fam Zheng <[email protected]>
 R: Philippe Mathieu-Daudé <[email protected]>
-L: [email protected]
 S: Maintained
 F: .travis.yml
 F: scripts/travis/

@@ -2405,7 +2393,6 @@ M: Alex Bennée <[email protected]>
 R: Philippe Mathieu-Daudé <[email protected]>
 F: tests/tcg/Makefile
 F: tests/tcg/Makefile.include
-L: [email protected]
 
 Documentation
 -------------
Signature · 1 line
2.17.2
#74 lore raw

Re: [Qemu-devel] [PATCH for-3.1 25/25] MAINTAINERS: Remove duplicate entries of [email protected]

Quoted 22 lines · Philippe Mathieu-Daudé

The list is always selected by the 'All patches CC here' section.

Signed-off-by Philippe Mathieu-Daudé <[email protected]>
---
 MAINTAINERS | 13 -------------
 1 file changed, 13 deletions(-)
MAINTAINERS +0 -1
index c616861ca3..9d6dae71ff 100644
@@ -109,7 +109,6 @@ L: [email protected]
 Guest CPU cores (TCG):
 ----------------------
 Overall
-L: [email protected]
 M: Peter Crosthwaite <[email protected]>
 M: Richard Henderson <[email protected]>
 R: Paolo Bonzini <[email protected]>

@@ -403,30 +402,25 @@ Hosts:
 ------

MAINTAINERS Hosts: · line 411

Quoted 10 lines
MAINTAINERS +0 -2
 LINUX
-L: [email protected]
 S: Maintained
 F: linux-*
 F: linux-headers/
 
 POSIX
-L: [email protected]
 S: Maintained
 F: *posix*

I agree that we can remove the "L: qemu-devel" entries everywhere, but for these subsystems that have no "M:" entry, but "S: Maintained", this now looks somewhat strange - the subsystem is "Maintained" but has no maintainer? I think we need somebody who feels responsible to pick up patches here...?

Thomas

#75 lore raw

Re: [Qemu-devel] [PATCH for-3.1 25/25] MAINTAINERS: Remove duplicate entries of [email protected]

Quoted 29 lines · Thomas Huth
Quoted 28 lines · Philippe Mathieu-Daudé

The list is always selected by the 'All patches CC here' section.

Signed-off-by Philippe Mathieu-Daudé <[email protected]>
---
 MAINTAINERS | 13 -------------
 1 file changed, 13 deletions(-)
MAINTAINERS +0 -2
index c616861ca3..9d6dae71ff 100644
@@ -109,7 +109,6 @@ L: [email protected]
 Guest CPU cores (TCG):
 ----------------------
 Overall
-L: [email protected]
 M: Peter Crosthwaite <[email protected]>
 M: Richard Henderson <[email protected]>
 R: Paolo Bonzini <[email protected]>

@@ -403,30 +402,25 @@ Hosts:
 ------
 
 LINUX
-L: [email protected]
 S: Maintained
 F: linux-*
 F: linux-headers/
Quoted 10 lines

MAINTAINERS Hosts: · line 411

Quoted 4 lines
MAINTAINERS +0 -1
 POSIX
-L: [email protected]
 S: Maintained
 F: *posix*

I agree that we can remove the "L: qemu-devel" entries everywhere, but for these subsystems that have no "M:" entry, but "S: Maintained", this now looks somewhat strange - the subsystem is "Maintained" but has no maintainer? I think we need somebody who feels responsible to pick up patches here...?

It looks strange because it *is* strange. If we take the definition of
S: in MAINTAINERS seriously, we need to appoint a maintainer (a person, not a mailing list), or downgrade to S: Orphan.

#76 lore raw

Re: [Qemu-devel] [PATCH for-3.1 25/25] MAINTAINERS: Remove duplicate entries of [email protected]

Quoted 4 lines · Markus Armbruster
Quoted 4 lines
Quoted 4 lines

LINUX
-L: [email protected]
S: Maintained
F: linux-*

This pattern only matches

./block/linux-aio.c
./stubs/linux-aio.c

so it can be removed

Quoted 1 line
Quoted 1 line
Quoted 1 line

F: linux-headers/

For this I propose mst, Conny and myself.

Quoted 11 lines
Quoted 10 lines
Quoted 4 lines

POSIX
-L: [email protected]
S: Maintained
F: *posix*

I agree that we can remove the "L: qemu-devel" entries everywhere, but for these subsystems that have no "M:" entry, but "S: Maintained", this now looks somewhat strange - the subsystem is "Maintained" but has no maintainer? I think we need somebody who feels responsible to pick up patches here...?

Quoted 3 lines

It looks strange because it *is* strange. If we take the definition of
S: in MAINTAINERS seriously, we need to appoint a maintainer (a person, not a mailing list), or downgrade to S: Orphan.

I can volunteer for this one too, but please change the F: patterns to

F: os-posix.c
F: include/sysemu/os-posix.h
F: util/*posix*.c
F: include/qemu/*posix*.h

Thanks,

Paolo

author
#77 lore raw

Re: [Qemu-devel] [PATCH for-3.1 25/25] MAINTAINERS: Remove duplicate entries of [email protected]

Quoted 6 lines · Paolo Bonzini
Quoted 4 lines · Markus Armbruster
Quoted 4 lines
Quoted 4 lines

LINUX
-L: [email protected]
S: Maintained
F: linux-*

Quoted 7 lines

This pattern only matches

./block/linux-aio.c
./stubs/linux-aio.c

so it can be removed

OK

Quoted 3 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line

F: linux-headers/

For this I propose mst, Conny and myself.

Or remove... I'll let them opinate.

Quoted 16 lines
Quoted 12 lines
Quoted 11 lines
Quoted 5 lines

POSIX
-L: [email protected]
S: Maintained
F: *posix*

I agree that we can remove the "L: qemu-devel" entries everywhere, but for these subsystems that have no "M:" entry, but "S: Maintained", this now looks somewhat strange - the subsystem is "Maintained" but has no maintainer? I think we need somebody who feels responsible to pick up patches here...?

Quoted 3 lines

It looks strange because it *is* strange. If we take the definition of
S: in MAINTAINERS seriously, we need to appoint a maintainer (a person, not a mailing list), or downgrade to S: Orphan.

Quoted 6 lines

I can volunteer for this one too, but please change the F: patterns to

F: os-posix.c
F: include/sysemu/os-posix.h
F: util/*posix*.c
F: include/qemu/*posix*.h

OK, will do.

Thanks Paolo,

Phil.

Quoted 5 lines

Thanks,

Paolo