Drivers: hv: vmbus: Remove the useless API vmbus_get_outgoing_channel()
PATCH 1/1 Drivers: hv: vmbus: Remove the useless API vmbus_get_outgoing_channel()
From: Dexuan Cui <[email protected]>
Commit d86adf482b84 ("scsi: storvsc: Enable multi-queue support") removed the usage of the API in Jan 2017, and the API is not used since then.
netvsc and storvsc have their own algorithms to determine the outgoing channel, so this API is useless.
And the API is potentially unsafe, because it reads primary->num_sc without any lock held. This can be risky considering the RESCIND-OFFER message.
Let's remove the API.
Cc Long Li <[email protected]>
Cc Stephen Hemminger <[email protected]>
Cc K. Y. Srinivasan <[email protected]>
Cc Haiyang Zhang <[email protected]>
Signed-off-by Dexuan Cui <[email protected]>
Signed-off-by K. Y. Srinivasan <[email protected]>
--- drivers/hv/channel.c | 1 - drivers/hv/channel_mgmt.c | 45 --------------------------------------- include/linux/hyperv.h | 17 --------------- 3 files changed, 63 deletions(-)
drivers/hv/channel.c +0 -1
@@ -703,7 +703,6 @@ int vmbus_disconnect_ring(struct vmbus_channel *channel)/* Snapshot the list of subchannels */ spin_lock_irqsave (&channel->lock, flags);list_splice_init (&channel->sc_list, &list); - channel->num_sc =0 ;spin_unlock_irqrestore (&channel->lock, flags);list_for_each_entry_safe (cur_channel, tmp, &list, sc_list) {
drivers/hv/channel_mgmt.c +0 -45
63 lines not on this page · raw message
include/linux/hyperv.h +0 -17
@@ -830,15 +830,6 @@ struct vmbus_channel {* All Sub-channels of a primary channel are linked here. */ struct list_head sc_list; -/* -* Current number of sub-channels. -*/ -int num_sc; -/* -* Number of a sub-channel (position within sc_list) which is supposed -* to be used as the next outgoing channel. -*/ -int next_oc;/* * The primary channel this sub-channel belongs to. * This will be NULL for the primary channel.
@@ -965,14 +956,6 @@ void vmbus_set_sc_create_callback(struct vmbus_channel *primary_channel,void vmbus_set_chn_rescind_callback (struct vmbus_channel *channel,void (*chn_rescind_cb)(struct vmbus_channel *)); -/* -* Retrieve the (sub) channel on which to send an outgoing request. -* When a primary channel has multiple sub-channels, we choose a -* channel whose VCPU binding is closest to the VCPU on which -* this call is being made. -*/ -struct vmbus_channel *vmbus_get_outgoing_channel (struct vmbus_channel *primary); -/* * Check if sub-channels have already been offerred. This API will be useful * when the driver is unloaded after establishing sub-channels. In this case,
Signature · 1 line
2.19.1