KVM: s390: add and wire function gib_alert_irq_handler()
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 25 lines · Cornelia Huck
Quoted 21 lines · On Mon, 19 Nov 2018 18:25:35 +0100 Michael Mueller <[email protected]> wrote:
The patch implements a handler for GIB alert interruptions on the host. Its task is to alert storage backed guests that interrupts are pending for them.
A GIB alert interrupt statistic counter is added as well:
$ cat /proc/interrupts CPU0 CPU1 ... GAL: 0 0 [I/O] GIB Alert ...Signed-off-by Michael Mueller <[email protected]>--- arch/s390/include/asm/irq.h | 1 + arch/s390/include/asm/isc.h | 1 + arch/s390/kernel/irq.c | 1 + arch/s390/kvm/interrupt.c | 57 +++++++++++++++++++++++++++++++++++++-------- arch/s390/kvm/kvm-s390.c | 6 +++++ arch/s390/kvm/kvm-s390.h | 5 ++++ 6 files changed, 61 insertions(+), 10 deletions(-)
Quoted 10 lines
Review static void nullify_gisa(struct kvm_s390_gisa *gisa) · line 2923
Quoted 6 lines
(quoted diff) +1
-1@@ -2919,7 +2920,7 @@ static void nullify_gisa(struct kvm_s390_gisa *gisa) * belongs to. Thus, the pending guest interruption will be processed * in SIE context. */ -static void __maybe_unused process_gib_alert_list(void) +static void process_gib_alert_list(void)Can't you merge the patch creating that function into this patch, so you don't need to add
__maybe_unusedin the first place? (I don't think the function is big enough to need separate review.)
The function has been rewritten for v3 and I consider it worth to stay separated now. The version is already in the starting blocks and was just delayed by all your replies. ;)
Quoted 5 lines
Quoted 4 lines
(quoted diff) +0
-0{ struct kvm_s390_gisa *gisa = unlink_gib_alert_list(); struct kvm_s390_gisa *next_alert;