Skip to contentSkip to conversation

ARC: change defconfig defaults to ARCv2

PATCH Applied Kevin Hilman 2 participants 4 messages Nov 27, 2018 – Nov 29, 2018 Synopsys ARC architecture

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARC: change defconfig defaults to ARCv2

Change the default defconfig (used with 'make defconfig') to the ARCv2 nsim_hs_defconfig, and also switch the default Kconfig ISA selection to ARCv2.

This allows several default defconfigs (e.g. make defconfig, make allnoconfig, make tinyconfig) to all work with ARCv2 by default.

Signed-off-by Kevin Hilman <khilman at baylibre.com>

---
Applies on v4.20-rc4

 arch/arc/Kconfig  | 2 +-
 arch/arc/Makefile | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
arch/arc/Kconfig +1 -1
index c9e2a1323536..a65ca0955d8b 100644
@@ -109,7 +109,7 @@ endmenu
 
 choice
 	prompt "ARC Instruction Set"
-	default ISA_ARCOMPACT
+	default ISA_ARCV2
 
 config ISA_ARCOMPACT
 	bool "ARCompact ISA"
arch/arc/Makefile +1 -1
index c64c505d966c..df00578c279d 100644
@@ -6,7 +6,7 @@
 # published by the Free Software Foundation.
 #
 
-KBUILD_DEFCONFIG := nsim_700_defconfig
+KBUILD_DEFCONFIG := nsim_hs_defconfig
 
 cflags-y	+= -fno-common -pipe -fno-builtin -mmedium-calls -D__linux__
 cflags-$(CONFIG_ISA_ARCOMPACT)	+= -mA7
Signature · 1 line
2.11.0
Applied
#1 lore raw
Quoted 8 lines · Kevin Hilman

Change the default defconfig (used with 'make defconfig') to the ARCv2 nsim_hs_defconfig, and also switch the default Kconfig ISA selection to ARCv2.

This allows several default defconfigs (e.g. make defconfig, make allnoconfig, make tinyconfig) to all work with ARCv2 by default.

Signed-off-by Kevin Hilman <khilman at baylibre.com>

Applied to for-curr

Thx,
-Vineet

#2 lore raw

Hi Vineet,

Quoted 11 lines · Vineet Gupta
Quoted 8 lines · Kevin Hilman

Change the default defconfig (used with 'make defconfig') to the ARCv2 nsim_hs_defconfig, and also switch the default Kconfig ISA selection to ARCv2.

This allows several default defconfigs (e.g. make defconfig, make allnoconfig, make tinyconfig) to all work with ARCv2 by default.

Signed-off-by Kevin Hilman <khilman at baylibre.com>

Applied to for-curr

If it's not too late, could you tag this for stable?

Even though this is not technicall a regression, Greg said (in a different thread) he'd be willing to accept this for stable if it fixes the builders like kernelCI.

Thanks,

Kevin

#3 lore raw
Quoted 12 lines · Kevin Hilman

Hi Vineet,

Quoted 8 lines · Vineet Gupta
Quoted 7 lines · Kevin Hilman

Change the default defconfig (used with 'make defconfig') to the ARCv2 nsim_hs_defconfig, and also switch the default Kconfig ISA selection to ARCv2.

This allows several default defconfigs (e.g. make defconfig, make allnoconfig, make tinyconfig) to all work with ARCv2 by default.

Quoted 7 lines
Quoted 2 lines
Quoted 1 line
Signed-off-by Kevin Hilman <khilman at baylibre.com>

Applied to for-curr

If it's not too late, could you tag this for stable?

Even though this is not technicall a regression, Greg said (in a different thread) he'd be willing to accept this for stable if it fixes the builders like kernelCI.

Sure thing. But this change actually causes regression in our in-house testing for the arc700 defconfigs which falter due to missing CONFIG_ISA_ARCOMPACT which was the default before. Alexey found this and will post a fixup whcih I plan to squash into ur patch to keep bisectability (and allow trivial stable backports) and then regen the relevant defconfigs.

-Vineet