Skip to contentSkip to conversation

KVM: s390: add functions to (un)register GISC with GISA

PATCH Michael Mueller 1 participant 1 message Nov 29, 2018 1 message not in the archive s390

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 46 lines · Cornelia Huck
Quoted 43 lines · On Thu, 29 Nov 2018 13:35:07 +0100 Michael Mueller <[email protected]> wrote:
Quoted 41 lines · Cornelia Huck
Quoted 26 lines · On Thu, 29 Nov 2018 12:24:36 +0100 Michael Mueller <[email protected]> wrote:
Quoted 21 lines · Cornelia Huck
Quoted 12 lines · On Wed, 28 Nov 2018 11:19:40 +0100 Michael Mueller <[email protected]> wrote:

Add the IAM (Interruption Alert Mask) to the architectue specific kvm struct. This mask in the GISA is used to define for which ISC a GIB alert can be issued.

The functions kvm_s390_gisc_register() and kvm_s390_gisc_unregister() are used to (un)register a GISC (guest ISC) with a virtual machine and its GISA.

Upon successful completion, kvm_s390_gisc_register() returns the ISC to be used for GIB alert interruptions. A negative return code indicates an error during registration.

Quoted 5 lines
---
    arch/s390/include/asm/kvm_host.h |  6 ++++++
    arch/s390/kvm/interrupt.c        | 44 ++++++++++++++++++++++++++++++++++++++++
    2 files changed, 50 insertions(+)
Quoted 3 lines

I've started at this and the following patches and have not found a place where the functions are called... leftover from a previous version?

Quoted 10 lines

No, these functions are required by the related driver code.

Pls. see:

Message ID: [email protected]

[v2,3/3] vfio: ap: AP Queue Interrupt Control VFIO ioctl calls

Quoted 1 line

I guess they should go with that series, then.

Quoted 8 lines
Quoted 3 lines

No, I don't think so. These functions are part of the *GIB infrastructure* and will by consumed e.g. by VFIO AP with irqs but also by PCI.

I disagree. The rest of this series lays the groundwork, this patch exports two unused functions, and it is much clearer how they are supposed to be used with an actual user. Of course PCI can use them later on as well :)

Then you could even argue the whole series has to go together with the AP irq series as it has no effect unless kvm->arch.iam is assigned a value... ;)

Quoted 3 lines

But in the end, your call.

Signature · 8 lines
Mit freundlichen Gr��en / Kind regards
Michael M�ller

IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Martina K�deritz
Gesch�ftsf�hrung: Dirk Wittkopp
Sitz der Gesellschaft: B�blingen
Registergericht: Amtsgericht Stuttgart, HRB 243294