cpufreq: nforce2: Remove meaningless return
PATCH 1/1 cpufreq: nforce2: Remove meaningless return
In a function whose return type is void, returning on the last line is not required.So remove it.Also move the module declaration to the end.
--- drivers/cpufreq/cpufreq-nforce2.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-)
drivers/cpufreq/cpufreq-nforce2.c +4 -7
@@ -47,10 +47,6 @@ static int fid;static int min_fsb;static int max_fsb; -MODULE_AUTHOR ("Sebastian Witt <[email protected]>" ); -MODULE_DESCRIPTION ("nForce2 FSB changing cpufreq driver" ); -MODULE_LICENSE ("GPL" ); -module_param (fid, int,0444 );module_param (min_fsb, int,0444 );
@@ -123,8 +119,6 @@ static void nforce2_write_pll(int pll)/* Now write the value in all 64 registers */ for (temp =0 ; temp <=0x3f ; temp++)pci_write_config_dword (nforce2_dev,NFORCE2_PLLREG , pll); - -return ; }/**
@@ -436,6 +430,9 @@ static void __exit nforce2_exit(void)cpufreq_unregister_driver (&nforce2_driver); } +MODULE_AUTHOR ("Sebastian Witt <[email protected]>" ); +MODULE_DESCRIPTION ("nForce2 FSB changing cpufreq driver" ); +MODULE_LICENSE ("GPL" ); +module_init (nforce2_init);module_exit (nforce2_exit); -
Signature · 1 line
2.17.0
Rafael J. Wysocki
maintainerQuoted 3 lines · Yangtao Li
In a function whose return type is void, returning on the last line is not required.So remove it.Also move the module declaration to the end.
The last piece is not reflected by the subject.
Also, why do you move the MODULE_ stuff around at all?
Quoted 44 lines
Signed-off-by Yangtao Li <[email protected]>--- drivers/cpufreq/cpufreq-nforce2.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-)drivers/cpufreq/cpufreq-nforce2.c +4
-8@@ -47,10 +47,6 @@ static int fid;static int min_fsb;static int max_fsb; -MODULE_AUTHOR ("Sebastian Witt <[email protected]>" ); -MODULE_DESCRIPTION ("nForce2 FSB changing cpufreq driver" ); -MODULE_LICENSE ("GPL" ); -module_param (fid, int,0444 );module_param (min_fsb, int,0444 );@@ -123,8 +119,6 @@ static void nforce2_write_pll(int pll)/* Now write the value in all 64 registers */ for (temp =0 ; temp <=0x3f ; temp++)pci_write_config_dword (nforce2_dev,NFORCE2_PLLREG , pll); - -return ; }/** @@ -436,6 +430,9 @@ static void __exit nforce2_exit(void)cpufreq_unregister_driver (&nforce2_driver); } +MODULE_AUTHOR ("Sebastian Witt <[email protected]>" ); +MODULE_DESCRIPTION ("nForce2 FSB changing cpufreq driver" ); +MODULE_LICENSE ("GPL" ); +module_init (nforce2_init);module_exit (nforce2_exit); - --2.17.0
Quoted 9 lines · Rafael J. Wysocki
Quoted 3 lines · Yangtao Li
In a function whose return type is void, returning on the last line is not required.So remove it.Also move the module declaration to the end.
The last piece is not reflected by the subject.
Also, why do you move the
MODULE_stuff around at all?
When writing a driver, in most cases MODULE_ are put to the end. Why not modify this? it is more in line with the habits of most people.
Yours,
Yangtao
Quoted 45 lines
Quoted 45 lines
Signed-off-by Yangtao Li <[email protected]>--- drivers/cpufreq/cpufreq-nforce2.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-)drivers/cpufreq/cpufreq-nforce2.c +4
-8@@ -47,10 +47,6 @@ static int fid;static int min_fsb;static int max_fsb; -MODULE_AUTHOR ("Sebastian Witt <[email protected]>" ); -MODULE_DESCRIPTION ("nForce2 FSB changing cpufreq driver" ); -MODULE_LICENSE ("GPL" ); -module_param (fid, int,0444 );module_param (min_fsb, int,0444 );@@ -123,8 +119,6 @@ static void nforce2_write_pll(int pll)/* Now write the value in all 64 registers */ for (temp =0 ; temp <=0x3f ; temp++)pci_write_config_dword (nforce2_dev,NFORCE2_PLLREG , pll); - -return ; }/** @@ -436,6 +430,9 @@ static void __exit nforce2_exit(void)cpufreq_unregister_driver (&nforce2_driver); } +MODULE_AUTHOR ("Sebastian Witt <[email protected]>" ); +MODULE_DESCRIPTION ("nForce2 FSB changing cpufreq driver" ); +MODULE_LICENSE ("GPL" ); +module_init (nforce2_init);module_exit (nforce2_exit); - --2.17.0
Rafael J. Wysocki
maintainerQuoted 5 lines · Frank Lee
Quoted 3 lines · Rafael J. Wysocki
Quoted 1 line · Yangtao Li
Quoted 8 lines
Quoted 6 lines
Quoted 2 lines
In a function whose return type is void, returning on the last line is not required.So remove it.Also move the module declaration to the end.
The last piece is not reflected by the subject.
Also, why do you move the
MODULE_stuff around at all?When writing a driver, in most cases
MODULE_are put to the end. Why not modify this? it is more in line with the habits of most people.
If you write a new driver, then yes.
But why do you want to modify existing drivers this way? What value do you see in those changes, exactly?
Quoted 12 lines · Rafael J. Wysocki
Quoted 10 lines · Frank Lee
Quoted 8 lines · Rafael J. Wysocki
Quoted 3 lines · Yangtao Li
In a function whose return type is void, returning on the last line is not required.So remove it.Also move the module declaration to the end.
The last piece is not reflected by the subject.
Quoted 8 lines
Quoted 3 lines
Quoted 1 line
Also, why do you move the
MODULE_stuff around at all?When writing a driver, in most cases
MODULE_are put to the end. Why not modify this? it is more in line with the habits of most people.If you write a new driver, then yes.
But why do you want to modify existing drivers this way? What value do you see in those changes, exactly?
OK.I'll update this.
MBR,
Yangtao