trigger named just "tx" in drivers/net/wireless/atmel/at76c50x-usb.c
Subsystems (3)
Hi!
While grepping something else, I came across LED trigger that is named just "tx".
That's a bit too generic afaict?
+++ b/drivers/net/wireless/atmel/at76c50x-usb.c
@@ -520,7 +520,7 @@ static int at76_usbdfu_download(struct usb_device *udev, u8 *buf, u32 size,
static int tx_activity;
static void at76_ledtrig_tx_timerfunc(struct timer_list *unused);
static DEFINE_TIMER(ledtrig_tx_timer, at76_ledtrig_tx_timerfunc); -DEFINE_LED_TRIGGER(ledtrig_tx); +DEFINE_LED_TRIGGER(ledtrig_tx); /* Hey! "tx" is a bit too generic name for a trigger! */
Pavel
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Quoted 7 lines · Pavel Machek
While grepping something else, I came across LED trigger that is named just "tx".
That's a bit too generic afaict?
+++
b/drivers/net/wireless/atmel/at76c50x-usb.c
Review static int at76_usbdfu_download(struct usb_device · line 526
Quoted 7 lines
(quoted diff) +0
-0@@ -520,7 +520,7 @@ static int at76_usbdfu_download(struct usb_device *udev, u8 *buf, u32 size, static int tx_activity; static void at76_ledtrig_tx_timerfunc(struct timer_list *unused); static DEFINE_TIMER(ledtrig_tx_timer, at76_ledtrig_tx_timerfunc); -DEFINE_LED_TRIGGER(ledtrig_tx); +DEFINE_LED_TRIGGER(ledtrig_tx); /* Hey! "tx" is a bit too generic name for a trigger! */
This is an ancient driver, my guess is that nobody uses it anymore. I should orphan it and maybe even remove it at some point.
Signature · 1 line
Kalle Valo
Quoted 7 lines · Kalle Valo
Quoted 5 lines · Pavel Machek
While grepping something else, I came across LED trigger that is named just "tx".
That's a bit too generic afaict?
Quoted 12 lines
Review static int at76_usbdfu_download(struct usb_device · line 526
Quoted 9 lines
+++
b/drivers/net/wireless/atmel/at76c50x-usb.c(quoted diff) +0
-0@@ -520,7 +520,7 @@ static int at76_usbdfu_download(struct usb_device *udev, u8 *buf, u32 size, static int tx_activity; static void at76_ledtrig_tx_timerfunc(struct timer_list *unused); static DEFINE_TIMER(ledtrig_tx_timer, at76_ledtrig_tx_timerfunc); -DEFINE_LED_TRIGGER(ledtrig_tx); +DEFINE_LED_TRIGGER(ledtrig_tx); /* Hey! "tx" is a bit too generic name for a trigger! */This is an ancient driver, my guess is that nobody uses it anymore. I should orphan it and maybe even remove it at some point.
Are you willing to add a fixme there? I really don't want people to copy that example.
Pavel
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Quoted 21 lines · Pavel Machek
Quoted 7 lines · Kalle Valo
Quoted 5 lines · Pavel Machek
While grepping something else, I came across LED trigger that is named just "tx".
That's a bit too generic afaict?
Quoted 12 lines
Review static int at76_usbdfu_download(struct usb_device · line 526
Quoted 9 lines
+++
b/drivers/net/wireless/atmel/at76c50x-usb.c(quoted diff) +0
-0@@ -520,7 +520,7 @@ static int at76_usbdfu_download(struct usb_device *udev, u8 *buf, u32 size, static int tx_activity; static void at76_ledtrig_tx_timerfunc(struct timer_list *unused); static DEFINE_TIMER(ledtrig_tx_timer, at76_ledtrig_tx_timerfunc); -DEFINE_LED_TRIGGER(ledtrig_tx); +DEFINE_LED_TRIGGER(ledtrig_tx); /* Hey! "tx" is a bit too generic name for a trigger! */This is an ancient driver, my guess is that nobody uses it anymore. I should orphan it and maybe even remove it at some point.
Quoted 2 lines
Are you willing to add a fixme there? I really don't want people to copy that example.
Sure, patches welcome.
Signature · 1 line
Kalle Valo