media: omap2: omapfb: convert to DEFINE_SHOW_ATTRIBUTE
PATCH v2 1/1 media: omap2: omapfb: convert to DEFINE_SHOW_ATTRIBUTE
Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.
Signed-off-by Yangtao Li <[email protected]>
--- drivers/video/fbdev/omap2/omapfb/dss/core.c | 18 ++++-------------- 1 file changed, 4 insertions(+), 14 deletions(-)
drivers/video/fbdev/omap2/omapfb/dss/core.c +4 -14
@@ -99,24 +99,14 @@ int dss_set_min_bus_tput(struct device *dev, unsigned long tput) }#if defined(CONFIG_FB_OMAP2_DSS_DEBUGFS ) -static int dss_debug_show (struct seq_file *s,void *unused) +static int dss_show (struct seq_file *s,void *unused) {void (*func)(struct seq_file *) = s->private;func (s);return 0 ; } -static int dss_debug_open (struct inode *inode,struct file *file) -{ -return single_open (file, dss_debug_show, inode->i_private); -} - -static const struct file_operations dss_debug_fops = { - .open = dss_debug_open, - .read = seq_read, - .llseek = seq_lseek, - .release = single_release, -}; +DEFINE_SHOW_ATTRIBUTE (dss);static struct dentry *dss_debugfs_dir;
@@ -130,7 +120,7 @@ static int dss_initialize_debugfs(void) }debugfs_create_file ("clk" ,S_IRUGO , dss_debugfs_dir, - &dss_debug_dump_clocks, &dss_debug_fops); + &dss_debug_dump_clocks, &dss_fops);return 0 ; }
@@ -145,7 +135,7 @@ int dss_debugfs_create_file(const char *name, void (*write)(struct seq_file *))struct dentry *d; d =debugfs_create_file (name,S_IRUGO , dss_debugfs_dir, - write, &dss_debug_fops); + write, &dss_fops);return PTR_ERR_OR_ZERO (d); }
Signature · 1 line
2.17.0
Quoted 5 lines · Yangtao Li
Use
DEFINE_SHOW_ATTRIBUTEmacro to simplify the code.Signed-off-by Yangtao Li <[email protected]>---
Changes in v2:
-Add a missing edit of dss_fops
---
Quoted 3 lines · Yangtao Li
Use
DEFINE_SHOW_ATTRIBUTEmacro to simplify the code.Signed-off-by Yangtao Li <[email protected]>
Patch queued for 4.21, thanks.
[ subject line was fixed to "fbdev" from "media" while applying ]
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics