Skip to contentSkip to conversation

net: qca_spi: convert to DEFINE_SHOW_ATTRIBUTE

PATCH Applied Yangtao Li 3 participants 3 messages Dec 3, 2018 – Dec 4, 2018

Subsystems (3)
Networking Network drivers Qualcomm Atheros QCA7K Ethernet driver
lore
Share & tools
lore

Yangtao Li

author
#0 lore raw

PATCH 1/1 net: qca_spi: convert to DEFINE_SHOW_ATTRIBUTE

Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.

Signed-off-by Yangtao Li <[email protected]>
---
 drivers/net/ethernet/qualcomm/qca_debug.c | 16 ++--------------
 1 file changed, 2 insertions(+), 14 deletions(-)
drivers/net/ethernet/qualcomm/qca_debug.c +2 -14
index a9f1bc013364..264ddc0159ec 100644
@@ -125,19 +125,7 @@ qcaspi_info_show(struct seq_file *s, void *what)
 
 	return 0;
 }
-
-static int
-qcaspi_info_open(struct inode *inode, struct file *file)
-{
-	return single_open(file, qcaspi_info_show, inode->i_private);
-}
-
-static const struct file_operations qcaspi_info_ops = {
-	.open = qcaspi_info_open,
-	.read = seq_read,
-	.llseek = seq_lseek,
-	.release = single_release,
-};
+DEFINE_SHOW_ATTRIBUTE(qcaspi_info);
 
 void
 qcaspi_init_device_debugfs(struct qcaspi *qca)

@@ -153,7 +141,7 @@ qcaspi_init_device_debugfs(struct qcaspi *qca)
 		return;
 	}
 	debugfs_create_file("info", S_IFREG | 0444, device_root, qca,
-			    &qcaspi_info_ops);
+			    &qcaspi_info_fops);
 }
 
 void
Signature · 1 line
2.17.0