Skip to contentSkip to conversation

net: marvell: convert to DEFINE_SHOW_ATTRIBUTE

PATCH Applied Yangtao Li 2 participants 2 messages Dec 3, 2018 – Dec 4, 2018

Subsystems (3)
Networking Network drivers Marvell gigabit Ethernet drivers (skge/sky2)
lore
Share & tools
lore

Yangtao Li

author
#0 lore raw

PATCH 1/1 net: marvell: convert to DEFINE_SHOW_ATTRIBUTE

Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.

Signed-off-by Yangtao Li <[email protected]>
---
 drivers/net/ethernet/marvell/skge.c | 14 +-------------
 drivers/net/ethernet/marvell/sky2.c | 14 +-------------
 2 files changed, 2 insertions(+), 26 deletions(-)
drivers/net/ethernet/marvell/skge.c +1 -13
index 9c08c3650c02..04fd1f135011 100644
@@ -3732,19 +3732,7 @@ static int skge_debug_show(struct seq_file *seq, void *v)
 
 	return 0;
 }
-
-static int skge_debug_open(struct inode *inode, struct file *file)
-{
-	return single_open(file, skge_debug_show, inode->i_private);
-}
-
-static const struct file_operations skge_debug_fops = {
-	.owner		= THIS_MODULE,
-	.open		= skge_debug_open,
-	.read		= seq_read,
-	.llseek		= seq_lseek,
-	.release	= single_release,
-};
+DEFINE_SHOW_ATTRIBUTE(skge_debug);
 
 /*
  * Use network device events to create/remove/rename
drivers/net/ethernet/marvell/sky2.c +1 -13
index 697d9b374f5e..f4aa01ab3580 100644
@@ -4623,19 +4623,7 @@ static int sky2_debug_show(struct seq_file *seq, void *v)
 	napi_enable(&hw->napi);
 	return 0;
 }
-
-static int sky2_debug_open(struct inode *inode, struct file *file)
-{
-	return single_open(file, sky2_debug_show, inode->i_private);
-}
-
-static const struct file_operations sky2_debug_fops = {
-	.owner		= THIS_MODULE,
-	.open		= sky2_debug_open,
-	.read		= seq_read,
-	.llseek		= seq_lseek,
-	.release	= single_release,
-};
+DEFINE_SHOW_ATTRIBUTE(sky2_debug);
 
 /*
  * Use network device events to create/remove/rename
Signature · 1 line
2.17.0