Skip to contentSkip to conversation

util-linux: split out blkdiscard into its own package

PATCH In review André Draszik 3 participants 5 messages Dec 3, 2018 – Dec 4, 2018

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 util-linux: split out blkdiscard into its own package

From: André Draszik <[email protected]>

For systems that don't otherwise depend on the full util-linux package, blkdiscard is a mere 18k (on cortexa7t2hf-neon).

---
 meta/recipes-core/util-linux/util-linux.inc | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
meta/recipes-core/util-linux/util-linux.inc +3 -2
index a05c1cabbe..b5f77f7b6b 100644
@@ -27,7 +27,7 @@ DEPENDS_append_class-nativesdk = " lzo-native"
 SRC_URI = "${KERNELORG_MIRROR}/linux/utils/util-linux/v${MAJOR_VERSION}/util-linux-${PV}.tar.xz \
            "
 
-PACKAGES =+ "util-linux-agetty util-linux-fdisk util-linux-cfdisk util-linux-sfdisk \
+PACKAGES =+ "util-linux-agetty util-linux-blkdiscard util-linux-fdisk util-linux-cfdisk util-linux-sfdisk \
              util-linux-swaponoff util-linux-losetup util-linux-umount \
              util-linux-mount util-linux-readprofile util-linux-uuidd \
              util-linux-uuidgen util-linux-lscpu util-linux-fsck.cramfs util-linux-fsck \
@@ -74,6 +74,7 @@ FILES_${PN}-doc += "${datadir}/getopt/getopt-*.*"
 FILES_${PN}-dev += "${PYTHON_SITEPACKAGES_DIR}/libmount/pylibmount.la"
 
 FILES_util-linux-agetty = "${base_sbindir}/agetty"
+FILES_util-linux-blkdiscard = "${sbindir}/blkdiscard"
 FILES_util-linux-fdisk = "${base_sbindir}/fdisk.${BPN}"
 FILES_util-linux-fstrim = "${base_sbindir}/fstrim.${BPN}"
 FILES_util-linux-cfdisk = "${base_sbindir}/cfdisk"
@@ -126,7 +127,7 @@ RDEPENDS_util-linux-su += "libpam"
 RDEPENDS_${PN} = "util-linux-umount util-linux-swaponoff util-linux-losetup util-linux-sulogin util-linux-lsblk"
 RDEPENDS_${PN} += "${@bb.utils.contains('DISTRO_FEATURES', 'pam', 'util-linux-runuser util-linux-su', '', d)}"
 
-RRECOMMENDS_${PN} = "util-linux-fdisk util-linux-cfdisk util-linux-sfdisk util-linux-mount util-linux-readprofile util-linux-mkfs util-linux-mountpoint util-linux-prlimit util-linux-ionice util-linux-switch-root"
+RRECOMMENDS_${PN} = "util-linux-blkdiscard util-linux-fdisk util-linux-cfdisk util-linux-sfdisk util-linux-mount util-linux-readprofile util-linux-mkfs util-linux-mountpoint util-linux-prlimit util-linux-ionice util-linux-switch-root"
 
 RRECOMMENDS_${PN}_class-native = ""
 RRECOMMENDS_${PN}_class-nativesdk = ""
Signature · 1 line
2.20.0.rc1
#1 lore raw

When do we just programatically split instead of doing it piece by piece? :)

Ross

Quoted 50 lines · André Draszik

From: André Draszik <[email protected]>

For systems that don't otherwise depend on the full util-linux package, blkdiscard is a mere 18k (on cortexa7t2hf-neon).

---
 meta/recipes-core/util-linux/util-linux.inc | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
meta/recipes-core/util-linux/util-linux.inc +3 -3
index a05c1cabbe..b5f77f7b6b 100644
@@ -27,7 +27,7 @@ DEPENDS_append_class-nativesdk = " lzo-native"
 SRC_URI = "${KERNELORG_MIRROR}/linux/utils/util-linux/v${MAJOR_VERSION}/util-linux-${PV}.tar.xz \
            "
 
-PACKAGES =+ "util-linux-agetty util-linux-fdisk util-linux-cfdisk util-linux-sfdisk \
+PACKAGES =+ "util-linux-agetty util-linux-blkdiscard util-linux-fdisk util-linux-cfdisk util-linux-sfdisk \
              util-linux-swaponoff util-linux-losetup util-linux-umount \
              util-linux-mount util-linux-readprofile util-linux-uuidd \
              util-linux-uuidgen util-linux-lscpu util-linux-fsck.cramfs util-linux-fsck \
@@ -74,6 +74,7 @@ FILES_${PN}-doc += "${datadir}/getopt/getopt-*.*"
 FILES_${PN}-dev += "${PYTHON_SITEPACKAGES_DIR}/libmount/pylibmount.la"
 
 FILES_util-linux-agetty = "${base_sbindir}/agetty"
+FILES_util-linux-blkdiscard = "${sbindir}/blkdiscard"
 FILES_util-linux-fdisk = "${base_sbindir}/fdisk.${BPN}"
 FILES_util-linux-fstrim = "${base_sbindir}/fstrim.${BPN}"
 FILES_util-linux-cfdisk = "${base_sbindir}/cfdisk"
@@ -126,7 +127,7 @@ RDEPENDS_util-linux-su += "libpam"
 RDEPENDS_${PN} = "util-linux-umount util-linux-swaponoff util-linux-losetup util-linux-sulogin util-linux-lsblk"
 RDEPENDS_${PN} += "${@bb.utils.contains('DISTRO_FEATURES', 'pam', 'util-linux-runuser util-linux-su', '', d)}"
 
-RRECOMMENDS_${PN} = "util-linux-fdisk util-linux-cfdisk util-linux-sfdisk util-linux-mount util-linux-readprofile util-linux-mkfs util-linux-mountpoint util-linux-prlimit util-linux-ionice util-linux-switch-root"
+RRECOMMENDS_${PN} = "util-linux-blkdiscard util-linux-fdisk util-linux-cfdisk util-linux-sfdisk util-linux-mount util-linux-readprofile util-linux-mkfs util-linux-mountpoint util-linux-prlimit util-linux-ionice util-linux-switch-root"
 
 RRECOMMENDS_${PN}_class-native = ""
 RRECOMMENDS_${PN}_class-nativesdk = ""
--

2.20.0.rc1

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

#2 lore raw

I think this is a good idea. I opened a new bug in bugzilla to track it, and assigned it to myself. Ross, please check the bug description to see if that's what you want.
Andre, if you want to work on it, take the bug and let me know.

Best Regards,
Chen Qi

Quoted 53 lines · Ross

When do we just programatically split instead of doing it piece by piece? :)

Ross

Quoted 49 lines · André Draszik

From: André Draszik <[email protected]>

For systems that don't otherwise depend on the full util-linux package, blkdiscard is a mere 18k (on cortexa7t2hf-neon).

---
  meta/recipes-core/util-linux/util-linux.inc | 5 +++--
  1 file changed, 3 insertions(+), 2 deletions(-)
meta/recipes-core/util-linux/util-linux.inc +3 -3
index a05c1cabbe..b5f77f7b6b 100644
@@ -27,7 +27,7 @@ DEPENDS_append_class-nativesdk = " lzo-native"
  SRC_URI = "${KERNELORG_MIRROR}/linux/utils/util-linux/v${MAJOR_VERSION}/util-linux-${PV}.tar.xz \
             "
 
-PACKAGES =+ "util-linux-agetty util-linux-fdisk util-linux-cfdisk util-linux-sfdisk \
+PACKAGES =+ "util-linux-agetty util-linux-blkdiscard util-linux-fdisk util-linux-cfdisk util-linux-sfdisk \
               util-linux-swaponoff util-linux-losetup util-linux-umount \
               util-linux-mount util-linux-readprofile util-linux-uuidd \
               util-linux-uuidgen util-linux-lscpu util-linux-fsck.cramfs util-linux-fsck \
@@ -74,6 +74,7 @@ FILES_${PN}-doc += "${datadir}/getopt/getopt-*.*"
  FILES_${PN}-dev += "${PYTHON_SITEPACKAGES_DIR}/libmount/pylibmount.la"
 
  FILES_util-linux-agetty = "${base_sbindir}/agetty"
+FILES_util-linux-blkdiscard = "${sbindir}/blkdiscard"
  FILES_util-linux-fdisk = "${base_sbindir}/fdisk.${BPN}"
  FILES_util-linux-fstrim = "${base_sbindir}/fstrim.${BPN}"
  FILES_util-linux-cfdisk = "${base_sbindir}/cfdisk"
@@ -126,7 +127,7 @@ RDEPENDS_util-linux-su += "libpam"
  RDEPENDS_${PN} = "util-linux-umount util-linux-swaponoff util-linux-losetup util-linux-sulogin util-linux-lsblk"
  RDEPENDS_${PN} += "${@bb.utils.contains('DISTRO_FEATURES', 'pam', 'util-linux-runuser util-linux-su', '', d)}"
 
-RRECOMMENDS_${PN} = "util-linux-fdisk util-linux-cfdisk util-linux-sfdisk util-linux-mount util-linux-readprofile util-linux-mkfs util-linux-mountpoint util-linux-prlimit util-linux-ionice util-linux-switch-root"
+RRECOMMENDS_${PN} = "util-linux-blkdiscard util-linux-fdisk util-linux-cfdisk util-linux-sfdisk util-linux-mount util-linux-readprofile util-linux-mkfs util-linux-mountpoint util-linux-prlimit util-linux-ionice util-linux-switch-root"
 
  RRECOMMENDS_${PN}_class-native = ""
  RRECOMMENDS_${PN}_class-nativesdk = ""
--

2.20.0.rc1

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

#3 lore raw

Hi,

I'd be happy to work on that, but I won't have time to do so until sometime early next year...

Can this patch be applied in the meantime nevertheless please?

Cheers,
Andre'

Quoted 81 lines · ChenQi

I think this is a good idea. I opened a new bug in bugzilla to track it, and assigned it to myself.
Ross, please check the bug description to see if that's what you want. Andre, if you want to work on it, take the bug and let me know.

Best Regards,
Chen Qi

Quoted 70 lines · Ross

When do we just programatically split instead of doing it piece by piece? :)

Ross

Quoted 65 lines · André Draszik

From: André Draszik <[email protected]>

For systems that don't otherwise depend on the full util-linux package, blkdiscard is a mere 18k (on cortexa7t2hf-neon).

---
  meta/recipes-core/util-linux/util-linux.inc | 5 +++--
  1 file changed, 3 insertions(+), 2 deletions(-)
meta/recipes-core/util-linux/util-linux.inc +1 -1
index a05c1cabbe..b5f77f7b6b 100644
@@ -27,7 +27,7 @@ DEPENDS_append_class-nativesdk = " lzo-native"
  SRC_URI = "${KERNELORG_MIRROR}/linux/utils/util-
 linux/v${MAJOR_VERSION}/util-linux-${PV}.tar.xz \
             "
 
-PACKAGES =+ "util-linux-agetty util-linux-fdisk util-linux-cfdisk
 util-linux-sfdisk \
+PACKAGES =+ "util-linux-agetty util-linux-blkdiscard util-linux-fdisk 
 util-linux-cfdisk util-linux-sfdisk \

util-linux-swaponoff util-linux-losetup util-linux-
umount \
util-linux-mount util-linux-readprofile util-linux-
uuidd \
util-linux-uuidgen util-linux-lscpu util-linux-
fsck.cramfs util-linux-fsck \

meta/recipes-core/util-linux/util-linux.inc +0 -0
@@ -74,6 +74,7 @@ FILES_${PN}-doc += "${datadir}/getopt/getopt-*.*"
  FILES_${PN}-dev +=

"${PYTHON_SITEPACKAGES_DIR}/libmount/pylibmount.la"

  FILES_util-linux-agetty = "${base_sbindir}/agetty"
meta/recipes-core/util-linux/util-linux.inc +1 -0
+FILES_util-linux-blkdiscard = "${sbindir}/blkdiscard"
  FILES_util-linux-fdisk = "${base_sbindir}/fdisk.${BPN}"
  FILES_util-linux-fstrim = "${base_sbindir}/fstrim.${BPN}"
  FILES_util-linux-cfdisk = "${base_sbindir}/cfdisk"
@@ -126,7 +127,7 @@ RDEPENDS_util-linux-su += "libpam"
  RDEPENDS_${PN} = "util-linux-umount util-linux-swaponoff util-linux-

losetup util-linux-sulogin util-linux-lsblk"
RDEPENDS_${PN} += "${@bb.utils.contains('DISTRO_FEATURES', 'pam',
'util-linux-runuser util-linux-su', '', d)}"

-RRECOMMENDS_${PN} = "util-linux-fdisk util-linux-cfdisk util-linux- sfdisk util-linux-mount util-linux-readprofile util-linux-mkfs util- linux-mountpoint util-linux-prlimit util-linux-ionice util-linux- switch-root"
+RRECOMMENDS_${PN} = "util-linux-blkdiscard util-linux-fdisk util- linux-cfdisk util-linux-sfdisk util-linux-mount util-linux-readprofile util-linux-mkfs util-linux-mountpoint util-linux-prlimit util-linux- ionice util-linux-switch-root"

RRECOMMENDS_${PN}_class-native = ""
RRECOMMENDS_${PN}_class-nativesdk = ""
--
2.20.0.rc1

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

#4 lore raw

Yep, staged already.

Ross

Quoted 96 lines · André Draszik

Hi,

I'd be happy to work on that, but I won't have time to do so until sometime early next year...

Can this patch be applied in the meantime nevertheless please?

Cheers,
Andre'

Quoted 81 lines · ChenQi

I think this is a good idea. I opened a new bug in bugzilla to track it, and assigned it to myself.
Ross, please check the bug description to see if that's what you want. Andre, if you want to work on it, take the bug and let me know.

Best Regards,
Chen Qi

Quoted 70 lines · Ross

When do we just programatically split instead of doing it piece by piece? :)

Ross

Quoted 65 lines · André Draszik

From: André Draszik <[email protected]>

For systems that don't otherwise depend on the full util-linux package, blkdiscard is a mere 18k (on cortexa7t2hf-neon).

---
  meta/recipes-core/util-linux/util-linux.inc | 5 +++--
  1 file changed, 3 insertions(+), 2 deletions(-)
meta/recipes-core/util-linux/util-linux.inc +1 -1
index a05c1cabbe..b5f77f7b6b 100644
@@ -27,7 +27,7 @@ DEPENDS_append_class-nativesdk = " lzo-native"
  SRC_URI = "${KERNELORG_MIRROR}/linux/utils/util-
 linux/v${MAJOR_VERSION}/util-linux-${PV}.tar.xz \
             "
 
-PACKAGES =+ "util-linux-agetty util-linux-fdisk util-linux-cfdisk
 util-linux-sfdisk \
+PACKAGES =+ "util-linux-agetty util-linux-blkdiscard util-linux-fdisk
 util-linux-cfdisk util-linux-sfdisk \

util-linux-swaponoff util-linux-losetup util-linux-
umount \
util-linux-mount util-linux-readprofile util-linux-
uuidd \
util-linux-uuidgen util-linux-lscpu util-linux-
fsck.cramfs util-linux-fsck \

meta/recipes-core/util-linux/util-linux.inc +0 -0
@@ -74,6 +74,7 @@ FILES_${PN}-doc += "${datadir}/getopt/getopt-*.*"
  FILES_${PN}-dev +=

"${PYTHON_SITEPACKAGES_DIR}/libmount/pylibmount.la"

  FILES_util-linux-agetty = "${base_sbindir}/agetty"
meta/recipes-core/util-linux/util-linux.inc +1 -0
+FILES_util-linux-blkdiscard = "${sbindir}/blkdiscard"
  FILES_util-linux-fdisk = "${base_sbindir}/fdisk.${BPN}"
  FILES_util-linux-fstrim = "${base_sbindir}/fstrim.${BPN}"
  FILES_util-linux-cfdisk = "${base_sbindir}/cfdisk"
@@ -126,7 +127,7 @@ RDEPENDS_util-linux-su += "libpam"
  RDEPENDS_${PN} = "util-linux-umount util-linux-swaponoff util-linux-

losetup util-linux-sulogin util-linux-lsblk"
RDEPENDS_${PN} += "${@bb.utils.contains('DISTRO_FEATURES', 'pam',
'util-linux-runuser util-linux-su', '', d)}"

-RRECOMMENDS_${PN} = "util-linux-fdisk util-linux-cfdisk util-linux- sfdisk util-linux-mount util-linux-readprofile util-linux-mkfs util- linux-mountpoint util-linux-prlimit util-linux-ionice util-linux- switch-root"
+RRECOMMENDS_${PN} = "util-linux-blkdiscard util-linux-fdisk util- linux-cfdisk util-linux-sfdisk util-linux-mount util-linux-readprofile util-linux-mkfs util-linux-mountpoint util-linux-prlimit util-linux- ionice util-linux-switch-root"

RRECOMMENDS_${PN}_class-native = ""
RRECOMMENDS_${PN}_class-nativesdk = ""
--
2.20.0.rc1

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core