dma-mapping: simplify the dma_sync_single_range_for_{cpu, device} implementation
PATCH 1/1 dma-mapping: simplify the dma_sync_single_range_for_{cpu, device} implementation
We can just call the regular calls after adding offset the the address instead of reimplementing them.
Signed-off-by Christoph Hellwig <[email protected]>
--- include/linux/dma-debug.h | 27 ------------------------ include/linux/dma-mapping.h | 34 +++++++++--------------------- kernel/dma/debug.c | 42 ------------------------------------- 3 files changed, 10 insertions(+), 93 deletions(-)
include/linux/dma-debug.h +0 -27
@@ -72,17 +72,6 @@ extern void debug_dma_sync_single_for_device(struct device *dev,dma_addr_t dma_handle, size_t size, int direction); -extern void debug_dma_sync_single_range_for_cpu (struct device *dev, -dma_addr_t dma_handle, -unsigned long offset, -size_t size, -int direction); - -extern void debug_dma_sync_single_range_for_device (struct device *dev, -dma_addr_t dma_handle, -unsigned long offset, -size_t size,int direction); -extern void debug_dma_sync_sg_for_cpu (struct device *dev,struct scatterlist *sg,int nelems,int direction);
@@ -174,22 +163,6 @@ static inline void debug_dma_sync_single_for_device(struct device *dev, { } -static inline void debug_dma_sync_single_range_for_cpu (struct device *dev, -dma_addr_t dma_handle, -unsigned long offset, -size_t size, -int direction) -{ -} - -static inline void debug_dma_sync_single_range_for_device (struct device *dev, -dma_addr_t dma_handle, -unsigned long offset, -size_t size, -int direction) -{ -} -static inline void debug_dma_sync_sg_for_cpu (struct device *dev,struct scatterlist *sg,int nelems,int direction)
include/linux/dma-mapping.h +10 -24
@@ -360,6 +360,13 @@ static inline void dma_sync_single_for_cpu(struct device *dev, dma_addr_t addr,debug_dma_sync_single_for_cpu (dev, addr, size, dir); } +static inline void dma_sync_single_range_for_cpu (struct device *dev, +dma_addr_t addr,unsigned long offset,size_t size, +enum dma_data_direction dir) +{ +return dma_sync_single_for_cpu (dev, addr + offset, size, dir); +} +static inline void dma_sync_single_for_device (struct device *dev,dma_addr_t addr,size_t size,enum dma_data_direction dir)
@@ -372,32 +379,11 @@ static inline void dma_sync_single_for_device(struct device *dev,debug_dma_sync_single_for_device (dev, addr, size, dir); } -static inline void dma_sync_single_range_for_cpu (struct device *dev, -dma_addr_t addr, -unsigned long offset, -size_t size, -enum dma_data_direction dir) -{ -const struct dma_map_ops *ops =get_dma_ops (dev); - -BUG_ON (!valid_dma_direction (dir)); -if (ops->sync_single_for_cpu) - ops->sync_single_for_cpu (dev, addr + offset, size, dir); -debug_dma_sync_single_range_for_cpu (dev, addr, offset, size, dir); -} -static inline void dma_sync_single_range_for_device (struct device *dev, -dma_addr_t addr, -unsigned long offset, -size_t size, -enum dma_data_direction dir) +dma_addr_t addr,unsigned long offset,size_t size, +enum dma_data_direction dir) { -const struct dma_map_ops *ops =get_dma_ops (dev); - -BUG_ON (!valid_dma_direction (dir)); -if (ops->sync_single_for_device) - ops->sync_single_for_device (dev, addr + offset, size, dir); -debug_dma_sync_single_range_for_device (dev, addr, offset, size, dir); +return dma_sync_single_for_device (dev, addr + offset, size, dir); } static inline void
kernel/dma/debug.c +0 -42
48 lines not on this page · raw message
Signature · 1 line
2.19.1