char/rtc: Use of_node_name_eq for node name comparisons

PATCH New Rob Herring 1 participant 1 message Dec 5, 2018 Char and misc drivers

Share & tools

Rob Herring

author

2018-12-05 19:50 UTC #0 lore raw

PATCH 1/1 char/rtc: Use of_node_name_eq for node name comparisons

Convert string compares of DT node names to use of_node_name_eq helper instead. This removes direct access to the node name pointer.

The open coded iterating thru the child node names is converted to use for_each_child_of_node() instead.

Cc Arnd Bergmann <[email protected]>

Cc Greg Kroah-Hartman <[email protected]>

Signed-off-by Rob Herring <[email protected]>

---
 drivers/char/rtc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

drivers/char/rtc.c +2 -2

index 4948c8bda6b1..62b7c721c732 100644
@@ -866,8 +866,8 @@ static int __init rtc_init(void)
 #ifdef CONFIG_SPARC32
 	for_each_node_by_name(ebus_dp, "ebus") {
 		struct device_node *dp;
-		for (dp = ebus_dp; dp; dp = dp->sibling) {
-			if (!strcmp(dp->name, "rtc")) {
+		for_each_child_of_node(ebus_dp, dp) {
+			if (of_node_name_eq(dp, "rtc")) {
 				op = of_find_device_by_node(dp);
 				if (op) {
 					rtc_port = op->resource[0].start;

Signature · 1 line

2.19.1