ASoC: Use of_node_name_eq for node name comparisons

PATCH In review Rob Herring 4 participants 5 messages Dec 5, 2018 – Dec 6, 2018

Subsystems (4)

Sound ASoC Freescale SoC sound drivers Sound - generic sound card (Simple-Audio-Card, Audio-Graph-Card)

lore

Share & tools

lore

Rob Herring

author

2018-12-05 19:50 UTC #0 lore raw

PATCH 1/1 ASoC: Use of_node_name_eq for node name comparisons

Convert string compares of DT node names to use of_node_name_eq helper instead. This removes direct access to the node name pointer.

For the FSL ASoC card, the full node names appear to be "ssi", "esai", and "sai", so there's not any reason to use strstr and of_node_name_eq can be used instead.

Cc Timur Tabi <[email protected]>

Cc Nicolin Chen <[email protected]>

Cc Xiubo Li <[email protected]>

Cc Fabio Estevam <[email protected]>

Cc Liam Girdwood <[email protected]>

Cc Mark Brown <[email protected]>

Cc Jaroslav Kysela <[email protected]>

Cc Takashi Iwai <[email protected]>

Cc [email protected]

Signed-off-by Rob Herring <[email protected]>

---
 sound/soc/fsl/fsl-asoc-card.c       | 6 +++---
 sound/soc/generic/simple-scu-card.c | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

sound/soc/fsl/fsl-asoc-card.c +3 -3

index 44433b20435c..81f2fe2c6d23 100644
@@ -571,17 +571,17 @@ static int fsl_asoc_card_probe(struct platform_device *pdev)
 	}
 
 	/* Common settings for corresponding Freescale CPU DAI driver */
-	if (strstr(cpu_np->name, "ssi")) {
+	if (of_node_name_eq(cpu_np, "ssi")) {
 		/* Only SSI needs to configure AUDMUX */
 		ret = fsl_asoc_card_audmux_init(np, priv);
 		if (ret) {
 			dev_err(&pdev->dev, "failed to init audmux\n");
 			goto asrc_fail;
 		}
-	} else if (strstr(cpu_np->name, "esai")) {
+	} else if (of_node_name_eq(cpu_np, "esai")) {
 		priv->cpu_priv.sysclk_id[1] = ESAI_HCKT_EXTAL;
 		priv->cpu_priv.sysclk_id[0] = ESAI_HCKR_EXTAL;
-	} else if (strstr(cpu_np->name, "sai")) {
+	} else if (of_node_name_eq(cpu_np, "sai")) {
 		priv->cpu_priv.sysclk_id[1] = FSL_SAI_CLK_MAST1;
 		priv->cpu_priv.sysclk_id[0] = FSL_SAI_CLK_MAST1;
 	}

sound/soc/generic/simple-scu-card.c +1 -1

index 85b46f0eae0f..e9a1acffcf5b 100644
@@ -216,7 +216,7 @@ static int asoc_simple_card_parse_of(struct simple_card_data *priv)
 	i = 0;
 	for_each_child_of_node(node, np) {
 		is_fe = false;
-		if (strcmp(np->name, PREFIX "cpu") == 0)
+		if (of_node_name_eq(np, PREFIX "cpu"))
 			is_fe = true;
 
 		ret = asoc_simple_card_dai_link_of(np, priv, daifmt, i, is_fe);

Signature · 1 line

2.19.1

Kuninori Morimoto

maintainer

2018-12-06 01:30 UTC #1 lore raw

Hi Rob

Quoted 6 lines

Convert string compares of DT node names to use of_node_name_eq helper instead. This removes direct access to the node name pointer.
For the FSL ASoC card, the full node names appear to be "ssi", "esai", and "sai", so there's not any reason to use strstr and of_node_name_eq can be used instead.

I guess this patch is for FSL ?

Quoted 4 lines

---
 sound/soc/fsl/fsl-asoc-card.c       | 6 +++---
 sound/soc/generic/simple-scu-card.c | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

But, this patch is including simple-scu-card.
Is this miss ?

Best regards
---
Kuninori Morimoto

Nicolin Chen

reviewer

2018-12-06 01:53 UTC #2 lore raw

In reply to Rob Herring

Hi Rob,

Quoted 6 lines · Rob Herring

Convert string compares of DT node names to use of_node_name_eq helper instead. This removes direct access to the node name pointer.
For the FSL ASoC card, the full node names appear to be "ssi", "esai", and "sai", so there's not any reason to use strstr and of_node_name_eq

I am not quite sure about the replacement of strstr. IIRC, a node name in fsl dts might appear to be "ssi@xxxx".

I am currently out of town so cannot verify the patch.

Fabio, would it be possible for you to run a boot test?

Thanks
Nicolin

Rob Herring

author

2018-12-06 13:34 UTC #3 lore raw

Quoted 5 lines · Nicolin Chen

Hi Rob,
Quoted 1 line · Rob Herring

Quoted 8 lines

Quoted 5 lines
Convert string compares of DT node names to use of_node_name_eq helper instead. This removes direct access to the node name pointer.
For the FSL ASoC card, the full node names appear to be "ssi", "esai", and "sai", so there's not any reason to use strstr and of_node_name_eq
I am not quite sure about the replacement of strstr. IIRC, a node name in fsl dts might appear to be "ssi@xxxx".

That will work fine. Unit-addresses are not part of the node name for the comparison.

Quoted 6 lines

I am currently out of town so cannot verify the patch.
Fabio, would it be possible for you to run a boot test?
Thanks
Nicolin

Mark Brown

maintainer

2018-12-06 20:26 UTC #4 lore raw

Applied "ASoC: Use of_node_name_eq for node name comparisons" to the asoc tree

In reply to Rob Herring

The patch

ASoC: Use of_node_name_eq for node name comparisons

has been applied to the asoc tree at

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

Quoted 1 line

From 1d52a74ea2300158f87196fa381cde52d98cf4e4 Mon Sep 17 00:00:00 2001

From: Rob Herring <[email protected]>
Date: Wed, 5 Dec 2018 13:50:49 -0600
Subject: [PATCH] ASoC: Use of_node_name_eq for node name comparisons