Skip to contentSkip to conversation

libunwind: Enable building static archive on musl

PATCH In review Khem Raj 2 participants 5 messages Dec 6, 2018

lore
Share & tools
lore

Khem Raj

author
#0 lore raw

PATCH 1/1 libunwind: Enable building static archive on musl

This ensures that we have .a for libunwind on musl targets, this is used for stack unwinding infra e.g. in rust

Help compiling rust compiler and standard library from meta-rust

---
 meta/recipes-support/libunwind/libunwind_1.2.1.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-support/libunwind/libunwind_1.2.1.bb +1 -1
index e7fb2b2190..c9239b695e 100644
@@ -14,7 +14,7 @@ SRC_URI = "http://download.savannah.nongnu.org/releases/libunwind/libunwind-${PV
            "
 
 SRC_URI_append_libc-musl = " file://musl-header-conflict.patch"
-EXTRA_OECONF_append_libc-musl = " --disable-documentation --disable-tests "
+EXTRA_OECONF_append_libc-musl = " --disable-documentation --disable-tests --enable-static"
 
 # http://errors.yoctoproject.org/Errors/Details/20487/
 ARM_INSTRUCTION_SET_armv4 = "arm"
Signature · 1 line
2.19.2
#1 lore raw

Presumably static archives are disabled by the no-static-libs include. So is this really musl-specific?

Ross

Quoted 32 lines · Khem Raj

This ensures that we have .a for libunwind on musl targets, this is used for stack unwinding infra e.g. in rust

Help compiling rust compiler and standard library from meta-rust

---
 meta/recipes-support/libunwind/libunwind_1.2.1.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-support/libunwind/libunwind_1.2.1.bb +1 -2
index e7fb2b2190..c9239b695e 100644
@@ -14,7 +14,7 @@ SRC_URI = "http://download.savannah.nongnu.org/releases/libunwind/libunwind-${PV
            "
 
 SRC_URI_append_libc-musl = " file://musl-header-conflict.patch"
-EXTRA_OECONF_append_libc-musl = " --disable-documentation --disable-tests "
+EXTRA_OECONF_append_libc-musl = " --disable-documentation --disable-tests --enable-static"
 
 # http://errors.yoctoproject.org/Errors/Details/20487/
 ARM_INSTRUCTION_SET_armv4 = "arm"
--

2.19.2

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

author
#2 lore raw

Yes, they are. But for musl libunwind static lib is required for rust runtime to build all the time static or not

Quoted 42 lines · Ross

Presumably static archives are disabled by the no-static-libs include. So is this really musl-specific?

Ross

Quoted 4 lines · Khem Raj

This ensures that we have .a for libunwind on musl targets, this is used for stack unwinding infra e.g. in rust

Review

Quoted 8 lines

Help compiling rust compiler and standard library from meta-rust

---
 meta/recipes-support/libunwind/libunwind_1.2.1.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
(quoted diff) +0 -0

b/meta/recipes-support/libunwind/libunwind_1.2.1.bb

meta/recipes-support/libunwind/libunwind_1.2.1.bb SRC_URI = "

Quoted 4 lines

index e7fb2b2190..c9239b695e 100644

meta/recipes-support/libunwind/libunwind_1.2.1.bb +0 -0
@@ -14,7 +14,7 @@ SRC_URI = "

http://download.savannah.nongnu.org/releases/libunwind/libunwind-${PV

meta/recipes-support/libunwind/libunwind_1.2.1.bb SRC_URI = "http://download.savannah.nongnu.org/releases/libunwind/libunwind-${PV

Quoted 4 lines
meta/recipes-support/libunwind/libunwind_1.2.1.bb +0 -1
            "
 
 SRC_URI_append_libc-musl = " file://musl-header-conflict.patch"
-EXTRA_OECONF_append_libc-musl = " --disable-documentation

--disable-tests "

meta/recipes-support/libunwind/libunwind_1.2.1.bb SRC_URI = " · line 17

Quoted 1 line
meta/recipes-support/libunwind/libunwind_1.2.1.bb +1 -0
+EXTRA_OECONF_append_libc-musl = " --disable-documentation

--disable-tests --enable-static"

Quoted 11 lines
meta/recipes-support/libunwind/libunwind_1.2.1.bb +0 -1
 # http://errors.yoctoproject.org/Errors/Details/20487/
 ARM_INSTRUCTION_SET_armv4 = "arm"
--

2.19.2

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

#3 lore raw
Quoted 1 line · Khem Raj

Yes, they are. But for musl libunwind static lib is required for rust runtime to build all the time static or not

And that's a musl-specific quirk of rust?

Ross

author
#4 lore raw

Yes, that's correct, for glibc is uses libbacktrace, which is provided by glibc itself, thats why we dont see a need for this with glibc

Quoted 7 lines · Ross
Quoted 1 line · Khem Raj

Yes, they are. But for musl libunwind static lib is required for rust runtime to build all the time static or not

And that's a musl-specific quirk of rust?

Ross