media: v4l2-fwnode: Fix setting V4L2_MBUS_DATA_ACTIVE_HIGH/LOW flag

PATCH New [email protected] 1 participant 1 message Dec 7, 2018

Subsystems (2)

Media (V4L/DVB) V4L2 async and fwnode frameworks

lore

Share & tools

lore

[email protected]

author

2018-12-07 16:01 UTC #0 lore raw

PATCH 1/1 media: v4l2-fwnode: Fix setting V4L2_MBUS_DATA_ACTIVE_HIGH/LOW flag

From: Ondrej Jirman <[email protected]>

When parallel bus is used and data-active is being parsed, incorrect flags are cleared.

Clear the correct flag bits.

Fixes e9be1b863e2c2948deb003df8edd9635b4611a8a (media: v4l: fwnode:

Use default parallel flags).

Signed-off-by Ondrej Jirman <[email protected]>

---
 drivers/media/v4l2-core/v4l2-fwnode.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

drivers/media/v4l2-core/v4l2-fwnode.c +2 -2

index 218f0da0ce76..edd34cf09cf8 100644
@@ -310,8 +310,8 @@ v4l2_fwnode_endpoint_parse_parallel_bus(struct fwnode_handle *fwnode,
 	}
 
 	if (!fwnode_property_read_u32(fwnode, "data-active", &v)) {
-		flags &= ~(V4L2_MBUS_PCLK_SAMPLE_RISING |
-			   V4L2_MBUS_PCLK_SAMPLE_FALLING);
+		flags &= ~(V4L2_MBUS_DATA_ACTIVE_HIGH |
+			   V4L2_MBUS_DATA_ACTIVE_LOW);
 		flags |= v ? V4L2_MBUS_DATA_ACTIVE_HIGH :
 			V4L2_MBUS_DATA_ACTIVE_LOW;
 		pr_debug("data-active %s\n", v ? "high" : "low");

Signature · 1 line

2.19.2