net: xenbus: convert to DEFINE_SHOW_ATTRIBUTE
Subsystems (3)
PATCH 1/1 net: xenbus: convert to DEFINE_SHOW_ATTRIBUTE
Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.
--- drivers/net/xen-netback/xenbus.c | 18 +++--------------- 1 file changed, 3 insertions(+), 15 deletions(-)
drivers/net/xen-netback/xenbus.c +3 -15
@@ -186,7 +186,7 @@ static const struct file_operations xenvif_dbg_io_ring_ops_fops = { .write = xenvif_write_io_ring, }; -static int xenvif_read_ctrl (struct seq_file *m,void *v) +static int xenvif_ctrl_show (struct seq_file *m,void *v) {struct xenvif *vif = m->private;
@@ -194,19 +194,7 @@ static int xenvif_read_ctrl(struct seq_file *m, void *v)return 0 ; } - -static int xenvif_ctrl_open (struct inode *inode,struct file *filp) -{ -return single_open (filp, xenvif_read_ctrl, inode->i_private); -} - -static const struct file_operations xenvif_dbg_ctrl_ops_fops = { - .owner =THIS_MODULE , - .open = xenvif_ctrl_open, - .read = seq_read, - .llseek = seq_lseek, - .release = single_release, -}; +DEFINE_SHOW_ATTRIBUTE (xenvif_ctrl);static void xenvif_debugfs_addif (struct xenvif *vif) {
@@ -238,7 +226,7 @@ static void xenvif_debugfs_addif(struct xenvif *vif)0400 , vif->xenvif_dbg_root, vif, - &xenvif_dbg_ctrl_ops_fops); + &xenvif_ctrl_fops);if (IS_ERR_OR_NULL (pfile))pr_warn ("Creation of ctrl file returned %ld!\n" ,PTR_ERR (pfile));
Signature · 1 line
2.17.0
Quoted 3 lines · Yangtao Li
Use
DEFINE_SHOW_ATTRIBUTEmacro to simplify the code.Signed-off-by Yangtao Li <[email protected]>
Thanks for the patch.
Quoted 3 lines · Yangtao Li
Use
DEFINE_SHOW_ATTRIBUTEmacro to simplify the code.Signed-off-by Yangtao Li <[email protected]>
Thanks for the patch.
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
From: Yangtao Li <[email protected]>
Date: Mon, 10 Dec 2018 10:53:29 -0500
Quoted 3 lines
Use
DEFINE_SHOW_ATTRIBUTEmacro to simplify the code.Signed-off-by Yangtao Li <[email protected]>
Applied.
From: Yangtao Li <[email protected]>
Date: Mon, 10 Dec 2018 10:53:29 -0500
Quoted 3 lines
Use
DEFINE_SHOW_ATTRIBUTEmacro to simplify the code.Signed-off-by Yangtao Li <[email protected]>
Applied.
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel