x86: mm: remove unused variable
PATCH 1/1 x86: mm: remove unused variable
A recent change dropped the only user of the variable, which should now be removed as well to avoid this warning:
arch/x86/mm/init_32.c: In function 'arch_remove_memory':arch/x86/mm/init_32.c:867:15: error: unused variable 'zone' [-Werror=unused-variable]
--- arch/x86/mm/init_32.c | 1 - 1 file changed, 1 deletion(-)
arch/x86/mm/init_32.c +0 -1
@@ -864,7 +864,6 @@ int arch_remove_memory(int nid, u64 start, u64 size, struct vmem_altmap *altmap) {unsigned long start_pfn = start >>PAGE_SHIFT ;unsigned long nr_pages = size >>PAGE_SHIFT ; -struct zone *zone;return remove_sections (nid, start_pfn, nr_pages, altmap); }
Signature · 1 line
2.20.0
Quoted 8 lines · Arnd Bergmann
A recent change dropped the only user of the variable, which should now be removed as well to avoid this warning:
arch/x86/mm/init_32.c: In function 'arch_remove_memory':arch/x86/mm/init_32.c:867:15: error: unused variable 'zone' [-Werror=unused-variable]Fixes dd99d07f818b ("mm, memory_hotplug: move zone/pages handling to offline stage")Signed-off-by Arnd Bergmann <[email protected]>
Hi Arnd,
Quoted 18 lines · On Mon, 10 Dec 2018 21:53:02 +0100 Arnd Bergmann <[email protected]> wrote:
A recent change dropped the only user of the variable, which should now be removed as well to avoid this warning:
arch/x86/mm/init_32.c: In function 'arch_remove_memory':arch/x86/mm/init_32.c:867:15: error: unused variable 'zone' [-Werror=unused-variable]Fixes dd99d07f818b ("mm, memory_hotplug: move zone/pages handling to offline stage")Signed-off-by Arnd Bergmann <[email protected]>--- arch/x86/mm/init_32.c | 1 - 1 file changed, 1 deletion(-)arch/x86/mm/init_32.c +0
-0
arch/x86/mm/init_32.c int arch_remove_memory(int nid, u64 start, u64 size, struct vmem_altmap *altmap) · line 869
Quoted 7 lines
arch/x86/mm/init_32.c +0
-1@@ -864,7 +864,6 @@ int arch_remove_memory(int nid, u64 start, u64 size, struct vmem_altmap *altmap) {unsigned long start_pfn = start >>PAGE_SHIFT ;unsigned long nr_pages = size >>PAGE_SHIFT ; -struct zone *zone;return remove_sections (nid, start_pfn, nr_pages, altmap); }
I have added that to the akpm-current tree for today.
Signature · 2 lines
Cheers, Stephen Rothwell