Skip to contentSkip to conversation

timekeeping: convert to DEFINE_SHOW_ATTRIBUTE

PATCH Superseded Yangtao Li 2 participants 2 messages Dec 11, 2018 – Dec 12, 2018 Timekeeping, clocksource core, NTP, alarmtimer

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Yangtao Li

author
#0 lore raw

PATCH 1/1 timekeeping: convert to DEFINE_SHOW_ATTRIBUTE

Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.

Signed-off-by Yangtao Li <[email protected]>
---
 kernel/time/timekeeping_debug.c | 15 ++-------------
 1 file changed, 2 insertions(+), 13 deletions(-)
kernel/time/timekeeping_debug.c +2 -13
index 238e4be60229..a937300df452 100644
@@ -28,7 +28,7 @@
 
 static unsigned int sleep_time_bin[NUM_BINS] = {0};
 
-static int tk_debug_show_sleep_time(struct seq_file *s, void *data)
+static int tk_debug_sleep_time_show(struct seq_file *s, void *data)
 {
 	unsigned int bin;
 	seq_puts(s, "      time (secs)        count\n");

@@ -42,18 +42,7 @@ static int tk_debug_show_sleep_time(struct seq_file *s, void *data)
 	}
 	return 0;
 }
-
-static int tk_debug_sleep_time_open(struct inode *inode, struct file *file)
-{
-	return single_open(file, tk_debug_show_sleep_time, NULL);
-}
-
-static const struct file_operations tk_debug_sleep_time_fops = {
-	.open		= tk_debug_sleep_time_open,
-	.read		= seq_read,
-	.llseek		= seq_lseek,
-	.release	= single_release,
-};
+DEFINE_SHOW_ATTRIBUTE(tk_debug_sleep_time);
 
 static int __init tk_debug_sleep_time_init(void)
 {
Signature · 1 line
2.17.0
merge bot
#1 lore raw

[tip:timers/core] timekeeping: Convert to DEFINE_SHOW_ATTRIBUTE

timekeeping: Convert to DEFINE_SHOW_ATTRIBUTE
Commit-ID:  5b20c6fd6a60e182243da31c47f2ebff5b0e3d57
Gitweb:     https://git.kernel.org/tip/5b20c6fd6a60e182243da31c47f2ebff5b0e3d57
Author:     Yangtao Li <[email protected]>
AuthorDate: Tue, 11 Dec 2018 11:37:44 -0500
Committer:  Thomas Gleixner <[email protected]>
CommitDate: Tue, 11 Dec 2018 18:13:35 -0800

timekeeping: Convert to DEFINE_SHOW_ATTRIBUTE

Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.

Signed-off-by Yangtao Li <[email protected]>
Signed-off-by Thomas Gleixner <[email protected]>
Cc [email protected]
Cc [email protected]
Link https://lkml.kernel.org/r/[email protected] open here
---
 kernel/time/timekeeping_debug.c | 15 ++-------------
 1 file changed, 2 insertions(+), 13 deletions(-)
kernel/time/timekeeping_debug.c +2 -13
index f811882cfd13..86489950d690 100644
@@ -19,7 +19,7 @@
 
 static unsigned int sleep_time_bin[NUM_BINS] = {0};
 
-static int tk_debug_show_sleep_time(struct seq_file *s, void *data)
+static int tk_debug_sleep_time_show(struct seq_file *s, void *data)
 {
 	unsigned int bin;
 	seq_puts(s, "      time (secs)        count\n");

@@ -33,18 +33,7 @@ static int tk_debug_show_sleep_time(struct seq_file *s, void *data)
 	}
 	return 0;
 }
-
-static int tk_debug_sleep_time_open(struct inode *inode, struct file *file)
-{
-	return single_open(file, tk_debug_show_sleep_time, NULL);
-}
-
-static const struct file_operations tk_debug_sleep_time_fops = {
-	.open		= tk_debug_sleep_time_open,
-	.read		= seq_read,
-	.llseek		= seq_lseek,
-	.release	= single_release,
-};
+DEFINE_SHOW_ATTRIBUTE(tk_debug_sleep_time);
 
 static int __init tk_debug_sleep_time_init(void)
 {