ACPI: Allow CONFIG_PCI to be unset for reboot
Subsystems (4)
A message that is not in the archive (sent off-list or not yet received): [email protected]
PATCH v5 1/5 ACPI: Allow CONFIG_PCI to be unset for reboot
Make PCI reboot conditional on PCI support being present on the kernel configuration.
--- drivers/acpi/reboot.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-)
drivers/acpi/reboot.c +7 -3
@@ -7,8 +7,6 @@void acpi_reboot (void ) {struct acpi_generic_address *rr; -struct pci_bus *bus0; -unsigned int devfn;u8 reset_value;if (acpi_disabled)
@@ -33,6 +31,11 @@ void acpi_reboot(void)* on a device on bus 0. */ switch (rr->space_id) {case ACPI_ADR_SPACE_PCI_CONFIG : + { +#ifdef CONFIG_PCI +unsigned int devfn; +struct pci_bus *bus0; +/* The reset register can only live on bus 0. */ bus0 =pci_find_bus (0 ,0 );if (!bus0)
@@ -44,8 +47,9 @@ void acpi_reboot(void)/* Write the value that resets us. */ pci_bus_write_config_byte (bus0, devfn, (rr->address &0xffff ), reset_value); +#endif break ; - + }case ACPI_ADR_SPACE_SYSTEM_MEMORY :case ACPI_ADR_SPACE_SYSTEM_IO :printk (KERN_DEBUG "ACPI MEMORY or I/O RESET_REG.\n" );
Signature · 1 line
2.19.0
PATCH v5 2/5 ACPI / OSL: Stub out acpi_os_read_pci_configuration when CONFIG_PCI is unset
In reply to a message not in the archiveGetting ready to allow PCI to be disabled with ACPI enabled. Stub out acpi_os_read_pci_configuration function that depend on PCI.
--- drivers/acpi/osl.c | 4 ++++ 1 file changed, 4 insertions(+)
drivers/acpi/osl.c +4 -0
@@ -773,6 +773,7 @@ acpi_status acpi_os_read_pci_configuration(struct acpi_pci_id * pci_id, u32 reg, u64 *value, u32 width) { +#ifdef CONFIG_PCI int result, size;u32 value32;
@@ -799,6 +800,9 @@ acpi_os_read_pci_configuration(struct acpi_pci_id * pci_id, u32 reg, *value = value32;return (result ?AE_ERROR :AE_OK ); +#else +return pr_warn_once ("CONFIG_PCI is disabled\n" ) ?AE_SUPPORT :AE_OK ; +#endif } acpi_status
Signature · 1 line
2.19.0
Rafael J. Wysocki
maintainerRe: [PATCH v5 2/5] ACPI / OSL: Stub out acpi_os_read_pci_configuration when CONFIG_PCI is unset
Quoted 22 lines · Sinan Kaya
Getting ready to allow PCI to be disabled with ACPI enabled. Stub out
acpi_os_read_pci_configurationfunction that depend on PCI.Signed-off-by Sinan Kaya <[email protected]>--- drivers/acpi/osl.c | 4 ++++ 1 file changed, 4 insertions(+)drivers/acpi/osl.c +1
-0@@ -773,6 +773,7 @@ acpi_status acpi_os_read_pci_configuration(struct acpi_pci_id * pci_id, u32 reg, u64 *value, u32 width) { +#ifdef CONFIG_PCI int result, size;u32 value32;
drivers/acpi/osl.c acpi_os_read_pci_configuration(struct acpi_pci_id * pci_id, u32 reg, · line 804
Quoted 5 lines
drivers/acpi/osl.c +2
-0@@ -799,6 +800,9 @@ acpi_os_read_pci_configuration(struct acpi_pci_id * pci_id, u32 reg, *value = value32;return (result ?AE_ERROR :AE_OK ); +#else +return pr_warn_once ("CONFIG_PCI is disabled\n" ) ?AE_SUPPORT :AE_OK ;
What about saying "PCI configuration space access is not supported" instead?
Quoted 5 lines
drivers/acpi/osl.c +1
-1+#endif } acpi_status --
PATCH v5 3/5 ACPI / OSL: Stub out acpi_os_write_pci_configuration when CONFIG_PCI is unset
In reply to a message not in the archiveGetting ready to allow PCI to be disabled with ACPI enabled. Stub out acpi_os_write_pci_configuration function that depend on PCI.
--- drivers/acpi/osl.c | 4 ++++ 1 file changed, 4 insertions(+)
drivers/acpi/osl.c +4 -0
@@ -809,6 +809,7 @@ acpi_status acpi_os_write_pci_configuration(struct acpi_pci_id * pci_id, u32 reg, u64 value, u32 width) { +#ifdef CONFIG_PCI int result, size;switch (width) {
@@ -830,6 +831,9 @@ acpi_os_write_pci_configuration(struct acpi_pci_id * pci_id, u32 reg, reg, size, value);return (result ?AE_ERROR :AE_OK ); +#else +return pr_warn_once ("CONFIG_PCI is disabled\n" ) ?AE_SUPPORT :AE_OK ; +#endif }static void acpi_os_execute_deferred (struct work_struct *work)
Signature · 1 line
2.19.0
PATCH v5 4/5 PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set
In reply to a message not in the archiveWe are compiling PCI code today for systems with ACPI and no PCI device present. Remove the useless code and reduce the tight dependency.
--- arch/x86/include/asm/pci_x86.h | 7 +++++++ drivers/acpi/Kconfig | 1 - drivers/acpi/Makefile | 2 +- drivers/acpi/internal.h | 5 +++++ drivers/pci/Makefile | 2 +- include/acpi/acpi_drivers.h | 7 +++++++ include/linux/acpi.h | 7 +++++++ include/linux/pci.h | 4 ++++ 8 files changed, 32 insertions(+), 3 deletions(-)
arch/x86/include/asm/pci_x86.h +7 -0
@@ -121,7 +121,14 @@ extern void __init dmi_check_pciprobe(void);extern void __init dmi_check_skip_isa_align (void );/* some common used subsys_initcalls */ +#ifdef CONFIG_PCI extern int __init pci_acpi_init (void ); +#else +static inline int __init pci_acpi_init (void ) +{ +return -EINVAL ; +} +#endif extern void __init pcibios_irq_init (void );extern int __init pcibios_init (void );extern int pci_legacy_init (void );
drivers/acpi/Kconfig +0 -1
@@ -9,7 +9,6 @@ config ARCH_SUPPORTS_ACPI menuconfig ACPI bool "ACPI (Advanced Configuration and Power Interface) Support" depends on ARCH_SUPPORTS_ACPI - depends on PCI select PNP default y if X86 help
drivers/acpi/Makefile +1 -1
@@ -39,7 +39,7 @@ acpi-y += processor_core.o acpi-$(CONFIG_ARCH_MIGHT_HAVE_ACPI_PDC) += processor_pdc.o acpi-y += ec.o acpi-$(CONFIG_ACPI_DOCK) += dock.o -acpi-y += pci_root.o pci_link.o pci_irq.o +acpi-$(CONFIG_PCI) += pci_root.o pci_link.o pci_irq.o obj-$(CONFIG_ACPI_MCFG) += pci_mcfg.o acpi-y += acpi_lpss.o acpi_apd.o acpi-y += acpi_platform.o
drivers/acpi/internal.h +5 -0
@@ -25,8 +25,13 @@ int acpi_osi_init(void);acpi_status acpi_os_initialize1 (void );void init_acpi_device_notify (void );int acpi_scan_init (void ); +#ifdef CONFIG_PCI void acpi_pci_root_init (void );void acpi_pci_link_init (void ); +#else +static inline void acpi_pci_root_init (void ) {} +static inline void acpi_pci_link_init (void ) {} +#endif void acpi_processor_init (void );void acpi_platform_init (void );void acpi_pnp_init (void );
drivers/pci/Makefile +1 -1
@@ -11,6 +11,7 @@ ifdef CONFIG_PCI obj-$(CONFIG_PROC_FS) += proc.o obj-$(CONFIG_SYSFS) += slot.o obj-$(CONFIG_OF) += of.o +obj-$(CONFIG_ACPI) += pci-acpi.o endif obj-$(CONFIG_PCI_QUIRKS) += quirks.o
@@ -20,7 +21,6 @@ obj-$(CONFIG_PCI_MSI) += msi.o obj-$(CONFIG_PCI_ATS) += ats.o obj-$(CONFIG_PCI_IOV) += iov.o obj-$(CONFIG_PCI_BRIDGE_EMUL) += pci-bridge-emul.o -obj-$(CONFIG_ACPI) += pci-acpi.o obj-$(CONFIG_PCI_LABEL) += pci-label.o obj-$(CONFIG_X86_INTEL_MID) += pci-mid.o obj-$(CONFIG_PCI_SYSCALL) += syscall.o
include/acpi/acpi_drivers.h +7 -0
@@ -88,7 +88,14 @@ int acpi_pci_link_free_irq(acpi_handle handle);struct pci_bus ; +#ifdef CONFIG_PCI struct pci_dev *acpi_get_pci_dev (acpi_handle ); +#else +static inline struct pci_dev *acpi_get_pci_dev (acpi_handle handle) +{ +return NULL ; +} +#endif /* Arch-defined function to add a bus to the system */
include/linux/acpi.h +7 -0
@@ -340,7 +340,14 @@ struct pci_dev;int acpi_pci_irq_enable (struct pci_dev *dev);void acpi_penalize_isa_irq (int irq,int active);bool acpi_isa_irq_available (int irq); +#ifdef CONFIG_PCI void acpi_penalize_sci_irq (int irq,int trigger,int polarity); +#else +static inline void acpi_penalize_sci_irq (int irq,int trigger, +int polarity) +{ +} +#endif void acpi_pci_irq_disable (struct pci_dev *dev);extern int ec_read (u8 addr,u8 *val);
include/linux/pci.h +4 -0
@@ -1960,7 +1960,11 @@ int pcibios_set_pcie_reset_state(struct pci_dev *dev, enum pcie_reset_state state);int pcibios_add_device (struct pci_dev *dev);void pcibios_release_device (struct pci_dev *dev); +#ifdef CONFIG_PCI void pcibios_penalize_isa_irq (int irq,int active); +#else +static inline void pcibios_penalize_isa_irq (int irq,int active) {} +#endif int pcibios_alloc_irq (struct pci_dev *dev);void pcibios_free_irq (struct pci_dev *dev);resource_size_t pcibios_default_alignment (void );
Signature · 1 line
2.19.0
PATCH v5 5/5 ACPI / OSL: Remove PCI bits from ACPICA when CONFIG_PCI is unset
In reply to a message not in the archiveNow that we allow CONFIG_PCI to be unset, remove useless code from ACPICA too.
--- drivers/acpi/acpica/Makefile | 2 +- drivers/acpi/osl.c | 9 +++++++++ 2 files changed, 10 insertions(+), 1 deletion(-)
drivers/acpi/acpica/Makefile +1 -1
@@ -77,13 +77,13 @@ acpi-y += \ hwacpi.o \ hwesleep.o \ hwgpe.o \ - hwpci.o \ hwregs.o \ hwsleep.o \ hwvalid.o \ hwxface.o \ hwxfsleep.o +acpi-$(CONFIG_PCI) += hwpci.o acpi-$(ACPI_FUTURE_USAGE) += hwtimer.o acpi-y += \
drivers/acpi/osl.c +9 -0
@@ -1837,3 +1837,12 @@ acpi_status acpi_os_enter_sleep(u8 sleep_state, reg_a_value, reg_b_value);return status; } + +#ifndef CONFIG_PCI +acpi_status acpi_hw_derive_pci_id (struct acpi_pci_id *pci_id, +acpi_handle root_pci_device,acpi_handle pci_region) +{ +return AE_SUPPORT ; +} +#endif +
Signature · 1 line
2.19.0
Rafael J. Wysocki
maintainerRe: [PATCH v5 5/5] ACPI / OSL: Remove PCI bits from ACPICA when CONFIG_PCI is unset
Quoted 37 lines · Sinan Kaya
Now that we allow
CONFIG_PCIto be unset, remove useless code from ACPICA too.Signed-off-by Sinan Kaya <okaya(a)kernel.org>--- drivers/acpi/acpica/Makefile | 2 +- drivers/acpi/osl.c | 9 +++++++++ 2 files changed, 10 insertions(+), 1 deletion(-)drivers/acpi/acpica/Makefile +1
-1@@ -77,13 +77,13 @@ acpi-y += \ hwacpi.o \ hwesleep.o \ hwgpe.o \ - hwpci.o \ hwregs.o \ hwsleep.o \ hwvalid.o \ hwxface.o \ hwxfsleep.o +acpi-$(CONFIG_PCI) += hwpci.o acpi-$(ACPI_FUTURE_USAGE) += hwtimer.o acpi-y += \drivers/acpi/osl.c +0
-0@@ -1837,3 +1837,12 @@ acpi_status acpi_os_enter_sleep(u8 sleep_state, reg_a_value, reg_b_value);return status; }
drivers/acpi/osl.c acpi_status acpi_os_enter_sleep(u8 sleep_state,
Quoted 10 lines
drivers/acpi/osl.c +9
-1+ +#ifndef CONFIG_PCI +acpi_status acpi_hw_derive_pci_id (struct acpi_pci_id *pci_id, +acpi_handle root_pci_device,acpi_handle pci_region) +{ +return AE_SUPPORT ; +} +#endif + --
I would prefer the header to be modified instead. Yes, it is an ACPICA header, but then the change would complement the Makefile one in a rather straightforward way.