staging: erofs: Add a blank line after declarations
A message that is not in the archive (sent off-list or not yet received): [email protected]
Hi Sungkyung,
Quoted 13 lines · Sungkyung Kim
Fix a warning from checkpathch.pl: 'Missing a blank line after declarations'
Signed-off-by Sungkyung Kim <jotun9935 at gmail.com>--- drivers/staging/erofs/inode.c | 1 + 1 file changed, 1 insertion(+)drivers/staging/erofs/inode.c +0
-0
drivers/staging/erofs/inode.c struct inode *erofs_iget(struct super_block *sb, · line 281
Quoted 4 lines
drivers/staging/erofs/inode.c +1
-0@@ -278,6 +278,7 @@ struct inode *erofs_iget(struct super_block *sb,if (inode->i_state &I_NEW ) {int err;struct erofs_vnode *vi =EROFS_V (inode); +
Thanks for your patch, is there a only one 'Missing a blank line after declarations' in erofs?
If not, could you have time check the other files? That is my personal thought, and I cc-ed the staging mailing list as well.
Thanks,
Gao Xiang
Quoted 4 lines
drivers/staging/erofs/inode.c +0
-0vi->nid = nid; err =fill_inode (inode, isdir);
PATCH 1/1 staging: erofs: Add a blank line after declarations
Thank you. I appreciate it for your prompt reply.
As a result of checking through 'checkpatch.pl', there was only one coding style problem in 'erofs / inode.c' file.
I will check for other files and send the patch file soon.
Thanks,
Sungkyung Kim
2018? 12? 13? (?) ?? 10:51, Gao Xiang <gaoxiang25 at huawei.com>?? ??:
Quoted 25 lines
Hi Sungkyung,
Review
Quoted 9 lines · Sungkyung Kim
Fix a warning from checkpathch.pl: 'Missing a blank line after declarations'
Signed-off-by Sungkyung Kim <jotun9935 at gmail.com>--- drivers/staging/erofs/inode.c | 1 + 1 file changed, 1 insertion(+)(quoted diff) +0
-0
b/drivers/staging/erofs/inode.cdrivers/staging/erofs/inode.c struct inode *erofs_iget(struct super_block *sb, · line 281
Quoted 8 lines
index
04c61a9d7b76..82b6ad5badff100644drivers/staging/erofs/inode.c +1
-0@@ -278,6 +278,7 @@ struct inode *erofs_iget(struct super_block *sb,if (inode->i_state &I_NEW ) {int err;struct erofs_vnode *vi =EROFS_V (inode); +Thanks for your patch, is there a only one 'Missing a blank line after declarations' in erofs?
Quoted 12 lines
If not, could you have time check the other files? That is my personal thought, and
I cc-ed the staging mailing list as well.Thanks,
Gao XiangQuoted 4 lines
drivers/staging/erofs/inode.c +0
-0vi->nid = nid; err =fill_inode (inode, isdir);
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ozlabs.org/pipermail/linux-erofs/attachments/20181213/33ba85dd/attachment.html>
Quoted 7 lines · ???
Thank you. I appreciate it for your?prompt reply.
As a result of checking through 'checkpatch.pl <http://checkpatch.pl>', there was only one coding style problem in 'erofs /
inode.c' file.I will check for other files and send the patch file soon.
Yes, if you confirm that this is the only one place, I think this patch is ok for me personally. :)
Thanks,
Gao Xiang
Quoted 43 lines
Thanks,
Sungkyung Kim?
2018? 12? 13? (?) ?? 10:51, Gao Xiang <gaoxiang25 at huawei.com <mailto:gaoxiang25 at huawei.com>>?? ??:
Hi Sungkyung, On 2018/12/12 23:50, Sungkyung Kim wrote: > Fix a warning from checkpathch.pl <http://checkpathch.pl>: 'Missing a blank line after > declarations' > > Signed-off-by: Sungkyung Kim <jotun9935 at gmail.com <mailto:jotun9935 at gmail.com>> > --- >? drivers/staging/erofs/inode.c | 1 + >? 1 file changed, 1 insertion(+) > > diff --git a/drivers/staging/erofs/inode.c b/drivers/staging/erofs/inode.c > index 04c61a9d7b76..82b6ad5badff 100644 > --- a/drivers/staging/erofs/inode.c > +++ b/drivers/staging/erofs/inode.c > @@ -278,6 +278,7 @@ struct inode *erofs_iget(struct super_block *sb, >? ? ? ?if (inode->i_state & I_NEW) { >? ? ? ? ? ? ? ?int err; >? ? ? ? ? ? ? ?struct erofs_vnode *vi = EROFS_V(inode); > + Thanks for your patch, is there a only one 'Missing a blank line after declarations' in erofs? If not, could you have time check the other files? That is my personal thought, and I cc-ed the staging mailing list as well. Thanks, Gao Xiang >? ? ? ? ? ? ? ?vi->nid = nid; >? >? ? ? ? ? ? ? ?err = fill_inode(inode, isdir); >
Quoted 23 lines · Gao Xiang
Hi Sungkyung,
Quoted 13 lines · Sungkyung Kim
Fix a warning from checkpathch.pl: 'Missing a blank line after declarations'
Signed-off-by Sungkyung Kim <jotun9935 at gmail.com>--- drivers/staging/erofs/inode.c | 1 + 1 file changed, 1 insertion(+)drivers/staging/erofs/inode.c +0
-0drivers/staging/erofs/inode.c struct inode *erofs_iget(struct super_block *sb, · line 281
Quoted 4 lines
drivers/staging/erofs/inode.c +1
-0@@ -278,6 +278,7 @@ struct inode *erofs_iget(struct super_block *sb,if (inode->i_state &I_NEW ) {int err;struct erofs_vnode *vi =EROFS_V (inode); +Thanks for your patch, is there a only one 'Missing a blank line after declarations' in erofs?
Quoted 2 lines
If not, could you have time check the other files? That is my personal thought, and I cc-ed the staging mailing list as well.
Agreed, it needs to check all files, and fix similar coding style issues in one patch.
Thanks,
Quoted 11 lines
Thanks,
Gao Xiangdrivers/staging/erofs/inode.c struct inode *erofs_iget(struct super_block *sb, · line 284
Quoted 4 lines
drivers/staging/erofs/inode.c +0
-0vi->nid = nid; err =fill_inode (inode, isdir);.