Huawei laptops
Subsystems (2)
v11 cover Huawei laptops
This patch set is based on the new audio LED triggers in topic/leds-trigger branch from
git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git
Changes in v11:
* Minor code changes
Changes in v10:
* Use ec_get_handle instead of acpi_get_handle since we are using the ec device
* Switch to WMI0_EXPENSIVE_GUID and wmi_query_block to fetch keycode when WMI0 is used
Changes in v9:
* Explicitly use NULL in acpi_get_handle
* Drop __initconst from huawei_wmi_keymap
Changes in v8:
* Switch to wmi_driver
* Use devm to allocate and manage devices
* Skip registering LED subsystem if a ACPI controller method was not found
Changes in v7:
* Use audio LED triggers patch set
* Use KEY_CONFIG (XF86Tools) instead of KEY_PROG1.
In Windows, the key is used to launch Huawei PC manager. XF86Tools is used by default on most desktop environments i.e. Gnome.
Changes in v6:
* Review tags
Changes in v5:
* Consistency in file names
* How module would be enabled (Kconfig)
* Match license in SPDX and MODULE_LICENSE
Changes in v4:
* Code formatting
Changes in v3:
* Support for Huawei MBX
* Style and formatting issues
Ayman Bagabas (3):
ALSA: hda: fix front speakers on Huawei MBXP.
x86: add support for Huawei WMI hotkeys.
ALSA: hda: add support for Huawei WMI micmute LED
drivers/platform/x86/Kconfig | 17 +++ drivers/platform/x86/Makefile | 1 + drivers/platform/x86/huawei-wmi.c | 208 ++++++++++++++++++++++++++++++ sound/pci/hda/patch_realtek.c | 22 ++++ 4 files changed, 248 insertions(+) create mode 100644 drivers/platform/x86/huawei-wmi.c
Signature · 1 line
2.19.2
PATCH v11 1/3 ALSA: hda: fix front speakers on Huawei MBXP.
This patch solves bug 200501 'Only 2 of 4 speakers playing sound.'
https://bugzilla.kernel.org/show_bug.cgi?id=200501
It enables the front speakers on Huawei Matebook X Pro laptops. These laptops come with Dolby Atmos sound system and these pins configuration enables the front speakers.
--- sound/pci/hda/patch_realtek.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+)
sound/pci/hda/patch_realtek.c +18 -0
@@ -5490,6 +5490,7 @@ enum {ALC298_FIXUP_TPT470_DOCK ,ALC255_FIXUP_DUMMY_LINEOUT_VERB ,ALC255_FIXUP_DELL_HEADSET_MIC , +ALC256_FIXUP_HUAWEI_MBXP_PINS ,ALC295_FIXUP_HP_X360 , ALC221_FIXUP_HP_HEADSET_MIC, };
@@ -5761,6 +5762,22 @@ static const struct hda_fixup alc269_fixups[] = { .chained = true, .chain_id =ALC269_FIXUP_HEADSET_MIC }, + [ALC256_FIXUP_HUAWEI_MBXP_PINS] = { + .type = HDA_FIXUP_PINS, + .v.pins = (const struct hda_pintbl []) { + {0x12 ,0x90a60130 }, + {0x13 ,0x40000000 }, + {0x14 ,0x90170110 }, + {0x18 ,0x411111f0 }, + {0x19 ,0x04a11040 }, + {0x1a ,0x411111f0 }, + {0x1b ,0x90170112 }, + {0x1d ,0x40759a05 }, + {0x1e ,0x411111f0 }, + {0x21 ,0x04211020 }, + { } + }, + }, [ALC269_FIXUP_ASUS_X101_FUNC] = { .type = HDA_FIXUP_FUNC, .v.func = alc269_fixup_x101_headset_mic,
@@ -6591,6 +6608,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {SND_PCI_QUIRK (0x17aa ,0x511f ,"Thinkpad" ,ALC298_FIXUP_TPT470_DOCK ),SND_PCI_QUIRK (0x17aa ,0x3bf8 ,"Quanta FL1" ,ALC269_FIXUP_PCM_44K ),SND_PCI_QUIRK (0x17aa ,0x9e54 ,"LENOVO NB" ,ALC269_FIXUP_LENOVO_EAPD ), +SND_PCI_QUIRK (0x19e5 ,0x3204 ,"Huawei MBXP" ,ALC256_FIXUP_HUAWEI_MBXP_PINS ),SND_PCI_QUIRK (0x1b7d ,0xa831 ,"Ordissimo EVE2 " ,ALC269VB_FIXUP_ORDISSIMO_EVE2 ),/* Also known as Malata PC-B1303 */ #if 0
Signature · 1 line
2.19.2
PATCH v11 2/3 x86: add support for Huawei WMI hotkeys.
In reply to Ayman BagabasThis driver adds support for missing hotkeys on some Huawei laptops. Laptops such as the Matebook X have non functioning hotkeys. Whereas newer laptops such as the Matebook X Pro come with working hotkeys out of the box.
Old laptops, such as the Matebook X, report hotkey events through ACPI device "\WMI0". However, new laptops, such as the Matebook X Pro, does not have this WMI device.
All the hotkeys on the Matebook X Pro work fine
without this patch except (micmute, wlan, and huawei key). These keys and the brightness keys report events to "\AMW0" ACPI device. One problem is that brightness keys on the Matebook X Pro work without this patch. This results in reporting two brightness key press events one is captured by ACPI and another by this driver.
A solution would be to check if such event came from the "\AMW0" WMI driver then skip reporting event. Another solution would be to leave this to user-space to handle. Which can be achieved by using "hwdb" tables and remap those keys to "unknown". This solution seems more natural to me because it leaves the decision to user-space.
--- drivers/platform/x86/Kconfig | 17 +++ drivers/platform/x86/Makefile | 1 + drivers/platform/x86/huawei-wmi.c | 208 ++++++++++++++++++++++++++++++ 3 files changed, 226 insertions(+) create mode 100644 drivers/platform/x86/huawei-wmi.c
drivers/platform/x86/Kconfig +17 -0
@@ -1292,6 +1292,23 @@ config INTEL_ATOMISP2_PM To compile this driver as a module, choose M here: the module will be called intel_atomisp2_pm. +config HUAWEI_WMI + tristate "Huawei WMI hotkeys driver" + depends on ACPI_WMI + depends on INPUT + select INPUT_SPARSEKMAP + select LEDS_CLASS + select LEDS_TRIGGERS + select LEDS_TRIGGER_AUDIO + select NEW_LEDS + help + This driver provides support for Huawei WMI hotkeys. + It enables the missing keys and adds support to the micmute + LED found on some of these laptops. + + To compile this driver as a module, choose M here: the module + will be called huawei-wmi. + endif # X86_PLATFORM_DEVICES config PMC_ATOM
drivers/platform/x86/Makefile +1 -0
@@ -32,6 +32,7 @@ obj-$(CONFIG_ACERHDF) += acerhdf.o obj-$(CONFIG_HP_ACCEL) += hp_accel.o obj-$(CONFIG_HP_WIRELESS) += hp-wireless.o obj-$(CONFIG_HP_WMI) += hp-wmi.o +obj-$(CONFIG_HUAWEI_WMI) += huawei-wmi.o obj-$(CONFIG_AMILO_RFKILL) += amilo-rfkill.o obj-$(CONFIG_GPD_POCKET_FAN) += gpd-pocket-fan.o obj-$(CONFIG_TC1100_WMI) += tc1100-wmi.o
drivers/platform/x86/huawei-wmi.c new file +208 -0
208 lines not on this page · raw message
Signature · 1 line
2.19.2
PATCH v11 3/3 ALSA: hda: add support for Huawei WMI micmute LED
In reply to Ayman BagabasSome of Huawei laptops come with a LED in the micmute key. This patch enables the use of micmute LED for these devices:
1. Matebook X (19e5:3200), (19e5:3201)
2. Matebook X Pro (19e5:3204)
--- sound/pci/hda/patch_realtek.c | 4 ++++ 1 file changed, 4 insertions(+)
sound/pci/hda/patch_realtek.c +4 -0
@@ -5777,6 +5777,8 @@ static const struct hda_fixup alc269_fixups[] = { {0x21, 0x04211020}, { } }, + .chained = true, + .chain_id = ALC255_FIXUP_MIC_MUTE_LED }, [ALC269_FIXUP_ASUS_X101_FUNC] = { .type = HDA_FIXUP_FUNC,
@@ -6608,6 +6610,8 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {SND_PCI_QUIRK (0x17aa ,0x511f ,"Thinkpad" ,ALC298_FIXUP_TPT470_DOCK ),SND_PCI_QUIRK (0x17aa ,0x3bf8 ,"Quanta FL1" ,ALC269_FIXUP_PCM_44K ),SND_PCI_QUIRK (0x17aa ,0x9e54 ,"LENOVO NB" ,ALC269_FIXUP_LENOVO_EAPD ), +SND_PCI_QUIRK (0x19e5 ,0x3200 ,"Huawei MBX" ,ALC255_FIXUP_MIC_MUTE_LED ), +SND_PCI_QUIRK (0x19e5 ,0x3201 ,"Huawei MBX" ,ALC255_FIXUP_MIC_MUTE_LED ),SND_PCI_QUIRK (0x19e5 ,0x3204 ,"Huawei MBXP" ,ALC256_FIXUP_HUAWEI_MBXP_PINS ), SND_PCI_QUIRK(0x1b7d, 0xa831, "Ordissimo EVE2 ", ALC269VB_FIXUP_ORDISSIMO_EVE2), /* Also known as Malata PC-B1303 */
Signature · 1 line
2.19.2
Quoted 37 lines · Ayman Bagabas
This patch set is based on the new audio LED triggers in topic/leds-trigger branch from
git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.gitChanges in v11:
* Minor code changesChanges in v10:
* Useec_get_handleinstead ofacpi_get_handlesince we are using the ec device
* Switch toWMI0_EXPENSIVE_GUIDandwmi_query_blockto fetch keycode when WMI0 is usedChanges in v9:
* Explicitly use NULL inacpi_get_handle
* Drop__initconstfromhuawei_wmi_keymapChanges in v8:
* Switch towmi_driver
* Use devm to allocate and manage devices
* Skip registering LED subsystem if a ACPI controller method was not foundChanges in v7:
* Use audio LED triggers patch set
* UseKEY_CONFIG(XF86Tools) instead ofKEY_PROG1.
In Windows, the key is used to launch Huawei PC manager. XF86Tools is used by default on most desktop environments i.e. Gnome.Changes in v6:
* Review tagsChanges in v5:
* Consistency in file names
* How module would be enabled (Kconfig)
* Match license in SPDX andMODULE_LICENSEChanges in v4:
* Code formatting
Quoted 8 lines
Changes in v3:
* Support for Huawei MBX
* Style and formatting issuesAyman Bagabas (3):
ALSA: hda: fix front speakers on Huawei MBXP.
x86: add support for Huawei WMI hotkeys.
ALSA: hda: add support for Huawei WMI micmute LED
Thank you for your patient works!
Now I applied all three patches to topic/huawei-leds branch of sound git tree (with just minor corrections of patch descriptions). This is merged to for-next branch for 4.21 inclusion.
Andy, feel free to merge topic/huawei-leds branch into your tree if needed. This one is already based on topic/leds-trigger branch, where both branches are immutable.
thanks,
Takashi