Skip to contentSkip to conversation

Pull request: u-boot-dfu (13.12.2018)

U-Boot Lukasz Majewski 3 participants 6 messages Dec 12, 2018 – Dec 13, 2018

lore
Share & tools
lore
#0 lore raw

Dear Marek,

The following changes since commit 51b24944fdbfa760aa87a1ad812355e1df9c9355:

usb: musb: Remove legacy CONFIG_USB_DA8XX (2018-12-12 15:23:04 +0100)

are available in the git repository at:

git://git.denx.de/u-boot-dfu.git

for you to fetch changes up to 8a3755462f65c032528af70c6582abf89f91b2bc:

configs: am335x_boneblack_vboot: enable DM_USB and RNDIS boot in SPl (2018-12-12 15:35:08 +0100)

----------------------------------------------------------------
Jean-Jacques Hiblot (20):
usb: dwc3-generic: make it compatible with "ti, keystone-dwc3"
board: ks2_evm: Enable the USB clocks if DM_USB is used
ARM: dts: k2g-evm: enable USB0 and USB1
PHY: Add phy driver for the keystone USB PHY
usb: host: replace xhci-keystone driver by the generic dwc3 driver
configs: k2g_evm: Enable DFU on K2G EVM
spl: drivers: Link usb common library to SPL if USB gadget is enabled
spl: net: dm: usb: bind the gadget before attempting to load the image
phy: omap_usb2: Add support for am437x
dwc3-generic: Add support for the am437x
board: ti: am43xx: turn on USB clocks
dts: Add a u-boot specific dtsi file for the am4372
dts: am4372: Enable USB1 in SPL
configs: am43xx_evm: Enable DM_USB and DM_USB_GADGET
configs: am43xx: Enable RNDIS support in SPL
usb: musb-new: Allow the diver not to use the set_phy_power() callback
usb: musb-new: Add support for DM_USB
arm: am33xx: Register USB controllers if DM_USB is used but not OF_CONTROL
configs: am335x_evm: Do not disable DM_USB in SPL
configs: am335x_boneblack_vboot: enable DM_USB and RNDIS boot in SPl

 arch/arm/dts/am4372-generic-u-boot.dtsi  |   2 +
 arch/arm/dts/am4372-u-boot.dtsi          |  40 ++++++++++++++++++
 arch/arm/dts/am437x-gp-evm-u-boot.dtsi   |   2 +
 arch/arm/dts/am437x-idk-evm-u-boot.dtsi  |   2 +
 arch/arm/dts/am437x-sk-evm-u-boot.dtsi   |   2 +
 arch/arm/dts/keystone-k2g-evm.dts        |  28 +++++++++++++
 arch/arm/dts/keystone-k2g.dtsi           |  56 +++++++++++++++++++++++++
 arch/arm/include/asm/omap_musb.h         |   8 ++++
 arch/arm/mach-omap2/am33xx/board.c       |  58 ++++++++++++++++++++++----
 board/ti/am43xx/board.c                  |  22 ++++++++++
 board/ti/ks2_evm/board.c                 |  12 ++++++
 common/Makefile                          |   3 ++
 common/spl/spl_net.c                     |   4 +-
 configs/am335x_boneblack_vboot_defconfig |  10 +++++
 configs/am43xx_evm_defconfig             |  19 +++++++++
 configs/k2e_evm_defconfig                |   7 ++++
 configs/k2e_hs_evm_defconfig             |   7 ++++
 configs/k2g_evm_defconfig                |  12 ++++++
 configs/k2g_hs_evm_defconfig             |  12 ++++++
 configs/k2hk_evm_defconfig               |   7 ++++
 configs/k2hk_hs_evm_defconfig            |   7 ++++
 configs/k2l_evm_defconfig                |   7 ++++
 configs/k2l_hs_evm_defconfig             |   7 ++++
 drivers/Makefile                         |   1 +
 drivers/phy/Kconfig                      |  10 +++++
 drivers/phy/Makefile                     |   1 +
 drivers/phy/keystone-usb-phy.c           | 109 +++++++++++++++++++++++++++++++++++++++++++++++++
 drivers/phy/omap-usb2-phy.c              |  45 +++++++++++++++-----
 drivers/usb/dwc3/dwc3-generic.c          |   2 +
 drivers/usb/host/Makefile                |   1 -
 drivers/usb/host/xhci-keystone.c         | 240 -----------------------------------------------------------------------------------------------------------
 drivers/usb/musb-new/am35x.c             |   8 ++--
 drivers/usb/musb-new/musb_dsps.c         |   8 ++--
 drivers/usb/musb-new/musb_gadget.c       |  11 +++++
 drivers/usb/musb-new/musb_uboot.c        |   4 +-
 drivers/usb/musb-new/ti-musb.c           | 181 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++---------------------
 include/configs/am335x_evm.h             |   1 -
 include/configs/ti_armv7_keystone2.h     |  17 +++++---
 38 files changed, 649 insertions(+), 324 deletions(-)
 create mode 100644 arch/arm/dts/am4372-u-boot.dtsi
 create mode 100644 drivers/phy/keystone-usb-phy.c
 delete mode 100644 drivers/usb/host/xhci-keystone.c

Travis-Ci: https://travis-ci.org/lmajewski/u-boot-dfu/builds/467026476

This is the last instalment of patches from Jean-Jacques

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de -------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20181212/64773d41/attachment.sig>

#1 lore raw
Quoted 1 line · Lukasz Majewski

Dear Marek,

This looks quite heavy after RC1 . How thoroughly was this tested ?

Quoted 92 lines

The following changes since commit 51b24944fdbfa760aa87a1ad812355e1df9c9355:

usb: musb: Remove legacy CONFIG_USB_DA8XX (2018-12-12 15:23:04 +0100)

are available in the git repository at:

git://git.denx.de/u-boot-dfu.git

for you to fetch changes up to 8a3755462f65c032528af70c6582abf89f91b2bc:

configs: am335x_boneblack_vboot: enable DM_USB and RNDIS boot in SPl (2018-12-12 15:35:08 +0100)

----------------------------------------------------------------
Jean-Jacques Hiblot (20):
usb: dwc3-generic: make it compatible with "ti, keystone-dwc3"
board: ks2_evm: Enable the USB clocks if DM_USB is used
ARM: dts: k2g-evm: enable USB0 and USB1
PHY: Add phy driver for the keystone USB PHY
usb: host: replace xhci-keystone driver by the generic dwc3 driver
configs: k2g_evm: Enable DFU on K2G EVM
spl: drivers: Link usb common library to SPL if USB gadget is enabled
spl: net: dm: usb: bind the gadget before attempting to load the image
phy: omap_usb2: Add support for am437x
dwc3-generic: Add support for the am437x
board: ti: am43xx: turn on USB clocks
dts: Add a u-boot specific dtsi file for the am4372
dts: am4372: Enable USB1 in SPL
configs: am43xx_evm: Enable DM_USB and DM_USB_GADGET
configs: am43xx: Enable RNDIS support in SPL
usb: musb-new: Allow the diver not to use the set_phy_power() callback
usb: musb-new: Add support for DM_USB
arm: am33xx: Register USB controllers if DM_USB is used but not OF_CONTROL
configs: am335x_evm: Do not disable DM_USB in SPL
configs: am335x_boneblack_vboot: enable DM_USB and RNDIS boot in SPl

 arch/arm/dts/am4372-generic-u-boot.dtsi  |   2 +
 arch/arm/dts/am4372-u-boot.dtsi          |  40 ++++++++++++++++++
 arch/arm/dts/am437x-gp-evm-u-boot.dtsi   |   2 +
 arch/arm/dts/am437x-idk-evm-u-boot.dtsi  |   2 +
 arch/arm/dts/am437x-sk-evm-u-boot.dtsi   |   2 +
 arch/arm/dts/keystone-k2g-evm.dts        |  28 +++++++++++++
 arch/arm/dts/keystone-k2g.dtsi           |  56 +++++++++++++++++++++++++
 arch/arm/include/asm/omap_musb.h         |   8 ++++
 arch/arm/mach-omap2/am33xx/board.c       |  58 ++++++++++++++++++++++----
 board/ti/am43xx/board.c                  |  22 ++++++++++
 board/ti/ks2_evm/board.c                 |  12 ++++++
 common/Makefile                          |   3 ++
 common/spl/spl_net.c                     |   4 +-
 configs/am335x_boneblack_vboot_defconfig |  10 +++++
 configs/am43xx_evm_defconfig             |  19 +++++++++
 configs/k2e_evm_defconfig                |   7 ++++
 configs/k2e_hs_evm_defconfig             |   7 ++++
 configs/k2g_evm_defconfig                |  12 ++++++
 configs/k2g_hs_evm_defconfig             |  12 ++++++
 configs/k2hk_evm_defconfig               |   7 ++++
 configs/k2hk_hs_evm_defconfig            |   7 ++++
 configs/k2l_evm_defconfig                |   7 ++++
 configs/k2l_hs_evm_defconfig             |   7 ++++
 drivers/Makefile                         |   1 +
 drivers/phy/Kconfig                      |  10 +++++
 drivers/phy/Makefile                     |   1 +
 drivers/phy/keystone-usb-phy.c           | 109 +++++++++++++++++++++++++++++++++++++++++++++++++
 drivers/phy/omap-usb2-phy.c              |  45 +++++++++++++++-----
 drivers/usb/dwc3/dwc3-generic.c          |   2 +
 drivers/usb/host/Makefile                |   1 -
 drivers/usb/host/xhci-keystone.c         | 240 -----------------------------------------------------------------------------------------------------------
 drivers/usb/musb-new/am35x.c             |   8 ++--
 drivers/usb/musb-new/musb_dsps.c         |   8 ++--
 drivers/usb/musb-new/musb_gadget.c       |  11 +++++
 drivers/usb/musb-new/musb_uboot.c        |   4 +-
 drivers/usb/musb-new/ti-musb.c           | 181 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++---------------------
 include/configs/am335x_evm.h             |   1 -
 include/configs/ti_armv7_keystone2.h     |  17 +++++---
 38 files changed, 649 insertions(+), 324 deletions(-)
 create mode 100644 arch/arm/dts/am4372-u-boot.dtsi
 create mode 100644 drivers/phy/keystone-usb-phy.c
 delete mode 100644 drivers/usb/host/xhci-keystone.c

Travis-Ci: https://travis-ci.org/lmajewski/u-boot-dfu/builds/467026476

This is the last instalment of patches from Jean-Jacques

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de

Signature · 2 lines
Best regards,
Marek Vasut
#2 lore raw

Hi Marek,

Quoted 4 lines · Lukasz Majewski
Quoted 1 line

Dear Marek,

This looks quite heavy after RC1 . How thoroughly was this tested ?

I've run:

./tools/buildman/buildman.py --branch=HEAD k2 omap am335x am43 dra7 trats2 odroid-xu3 --detail --verbose --show_errors --force-build --count=20 --output-dir=../BUILD/

on it without any issues (DTS warnings were there - as expected).

Nonetheless, this is the second "instalment" of Jean-Jacques work and shall IMHO be treated as a one part with the code already included to main line.

I do not expect so much changes to DFU/UDC tree from now on - hence we can focus on fixes.

Quoted 94 lines
Quoted 94 lines

The following changes since commit
51b24944fdbfa760aa87a1ad812355e1df9c9355:

usb: musb: Remove legacy CONFIG_USB_DA8XX (2018-12-12 15:23:04
+0100)

are available in the git repository at:

git://git.denx.de/u-boot-dfu.git

for you to fetch changes up to
8a3755462f65c032528af70c6582abf89f91b2bc:

configs: am335x_boneblack_vboot: enable DM_USB and RNDIS boot in
SPl (2018-12-12 15:35:08 +0100)

----------------------------------------------------------------
Jean-Jacques Hiblot (20):
usb: dwc3-generic: make it compatible with "ti, keystone-dwc3"
board: ks2_evm: Enable the USB clocks if DM_USB is used
ARM: dts: k2g-evm: enable USB0 and USB1
PHY: Add phy driver for the keystone USB PHY
usb: host: replace xhci-keystone driver by the generic dwc3
driver configs: k2g_evm: Enable DFU on K2G EVM
spl: drivers: Link usb common library to SPL if USB gadget is
enabled spl: net: dm: usb: bind the gadget before attempting to load the image phy: omap_usb2: Add support for am437x
dwc3-generic: Add support for the am437x
board: ti: am43xx: turn on USB clocks
dts: Add a u-boot specific dtsi file for the am4372
dts: am4372: Enable USB1 in SPL
configs: am43xx_evm: Enable DM_USB and DM_USB_GADGET
configs: am43xx: Enable RNDIS support in SPL
usb: musb-new: Allow the diver not to use the set_phy_power()
callback usb: musb-new: Add support for DM_USB
arm: am33xx: Register USB controllers if DM_USB is used but
not OF_CONTROL configs: am335x_evm: Do not disable DM_USB in SPL
configs: am335x_boneblack_vboot: enable DM_USB and RNDIS boot
in SPl

 arch/arm/dts/am4372-generic-u-boot.dtsi  |   2 +
 arch/arm/dts/am4372-u-boot.dtsi          |  40 ++++++++++++++++++
 arch/arm/dts/am437x-gp-evm-u-boot.dtsi   |   2 +
 arch/arm/dts/am437x-idk-evm-u-boot.dtsi  |   2 +
 arch/arm/dts/am437x-sk-evm-u-boot.dtsi   |   2 +
 arch/arm/dts/keystone-k2g-evm.dts        |  28 +++++++++++++
 arch/arm/dts/keystone-k2g.dtsi           |  56
+++++++++++++++++++++++++ arch/arm/include/asm/omap_musb.h
|   8 ++++ arch/arm/mach-omap2/am33xx/board.c       |  58
++++++++++++++++++++++---- board/ti/am43xx/board.c
|  22 ++++++++++ board/ti/ks2_evm/board.c                 |  12
++++++ common/Makefile                          |   3 ++
 common/spl/spl_net.c                     |   4 +-
 configs/am335x_boneblack_vboot_defconfig |  10 +++++
 configs/am43xx_evm_defconfig             |  19 +++++++++
 configs/k2e_evm_defconfig                |   7 ++++
 configs/k2e_hs_evm_defconfig             |   7 ++++
 configs/k2g_evm_defconfig                |  12 ++++++
 configs/k2g_hs_evm_defconfig             |  12 ++++++
 configs/k2hk_evm_defconfig               |   7 ++++
 configs/k2hk_hs_evm_defconfig            |   7 ++++
 configs/k2l_evm_defconfig                |   7 ++++
 configs/k2l_hs_evm_defconfig             |   7 ++++
 drivers/Makefile                         |   1 +
 drivers/phy/Kconfig                      |  10 +++++
 drivers/phy/Makefile                     |   1 +
 drivers/phy/keystone-usb-phy.c           | 109
+++++++++++++++++++++++++++++++++++++++++++++++++
drivers/phy/omap-usb2-phy.c              |  45 +++++++++++++++-----
drivers/usb/dwc3/dwc3-generic.c          |   2 +
drivers/usb/host/Makefile                |   1 -
drivers/usb/host/xhci-keystone.c         | 240
-----------------------------------------------------------------------------------------------------------
drivers/usb/musb-new/am35x.c             |   8 ++--
drivers/usb/musb-new/musb_dsps.c         |   8 ++--
drivers/usb/musb-new/musb_gadget.c       |  11 +++++
drivers/usb/musb-new/musb_uboot.c        |   4 +-
drivers/usb/musb-new/ti-musb.c           | 181

+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++---------------------
include/configs/am335x_evm.h | 1 -
include/configs/ti_armv7_keystone2.h | 17 +++++--- 38 files
changed, 649 insertions(+), 324 deletions(-) create mode 100644 arch/arm/dts/am4372-u-boot.dtsi create mode 100644 drivers/phy/keystone-usb-phy.c delete mode 100644 drivers/usb/host/xhci-keystone.c

Travis-Ci:
https://travis-ci.org/lmajewski/u-boot-dfu/builds/467026476

This is the last instalment of patches from Jean-Jacques

Best regards,

Quoted 10 lines
Quoted 8 lines

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Wolfgang
Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email:
lukma at denx.de

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de -------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20181213/e576f706/attachment.sig>

#3 lore raw

Hi Marek, Lukasz,

Quoted 16 lines · Lukasz Majewski

Hi Marek,

Quoted 4 lines · Lukasz Majewski
Quoted 1 line

Dear Marek,

This looks quite heavy after RC1 . How thoroughly was this tested ?

I've run:

./tools/buildman/buildman.py --branch=HEAD k2 omap am335x am43 dra7 trats2 odroid-xu3 --detail --verbose --show_errors --force-build --count=20 --output-dir=../BUILD/

on it without any issues (DTS warnings were there - as expected).

Quoted 20 lines

Nonetheless, this is the second "instalment" of Jean-Jacques work and shall IMHO be treated as a one part with the code already included to main line.

I do not expect so much changes to DFU/UDC tree from now on - hence we can focus on fixes.

Quoted 13 lines
Quoted 13 lines

The following changes since commit
51b24944fdbfa760aa87a1ad812355e1df9c9355:

   usb: musb: Remove legacy CONFIG_USB_DA8XX (2018-12-12 15:23:04

+0100)

are available in the git repository at:

   git://git.denx.de/u-boot-dfu.git

for you to fetch changes up to
8a3755462f65c032528af70c6582abf89f91b2bc:

FWIW, I did verify 8a3755462f65c032528af70c6582abf89f91b2bc on AM437x-gp evem.

MMC Boot and DFU at u-boot prompt: https://pastebin.ubuntu.com/p/gmT33ksrFC/
USB Host Boot: https://pastebin.ubuntu.com/p/zyn8PNdJ5V/

Thanks and regards,
Lokesh

#4 lore raw
Quoted 41 lines · Lokesh Vutla

Hi Marek, Lukasz,

Quoted 16 lines · Lukasz Majewski

Hi Marek,

Quoted 4 lines · Lukasz Majewski
Quoted 1 line

Dear Marek,

This looks quite heavy after RC1 . How thoroughly was this tested ?

I've run:

./tools/buildman/buildman.py --branch=HEAD k2 omap am335x am43 dra7 trats2 odroid-xu3 --detail --verbose --show_errors --force-build --count=20 --output-dir=../BUILD/

on it without any issues (DTS warnings were there - as expected).

Quoted 20 lines

Nonetheless, this is the second "instalment" of Jean-Jacques work and shall IMHO be treated as a one part with the code already included to main line.

I do not expect so much changes to DFU/UDC tree from now on - hence we can focus on fixes.

Quoted 13 lines
Quoted 13 lines

The following changes since commit
51b24944fdbfa760aa87a1ad812355e1df9c9355:

   usb: musb: Remove legacy CONFIG_USB_DA8XX (2018-12-12 15:23:04 +0100)

are available in the git repository at:

   git://git.denx.de/u-boot-dfu.git

for you to fetch changes up to
8a3755462f65c032528af70c6582abf89f91b2bc:

Quoted 6 lines

FWIW, I did verify 8a3755462f65c032528af70c6582abf89f91b2bc on AM437x-gp evem.

MMC Boot and DFU at u-boot prompt:
https://pastebin.ubuntu.com/p/gmT33ksrFC/
USB Host Boot: https://pastebin.ubuntu.com/p/zyn8PNdJ5V/

Pulled, but I expect only fixes after this one.

Signature · 2 lines
Best regards,
Marek Vasut
#5 lore raw

Hi Marek,

Quoted 43 lines · Lokesh Vutla
Quoted 42 lines

Hi Marek, Lukasz,

Quoted 37 lines · Lukasz Majewski

Hi Marek,

Quoted 5 lines · Lukasz Majewski
Quoted 1 line

Dear Marek,

This looks quite heavy after RC1 . How thoroughly was this tested ?

I've run:

./tools/buildman/buildman.py --branch=HEAD k2 omap am335x am43 dra7 trats2 odroid-xu3 --detail --verbose --show_errors --force-build --count=20 --output-dir=../BUILD/

on it without any issues (DTS warnings were there - as expected).

Nonetheless, this is the second "instalment" of Jean-Jacques work and shall IMHO be treated as a one part with the code already included to main line.

I do not expect so much changes to DFU/UDC tree from now on - hence we can focus on fixes.

Quoted 13 lines
Quoted 13 lines

The following changes since commit
51b24944fdbfa760aa87a1ad812355e1df9c9355:

   usb: musb: Remove legacy CONFIG_USB_DA8XX (2018-12-12 15:23:04 +0100)

are available in the git repository at:

   git://git.denx.de/u-boot-dfu.git

for you to fetch changes up to
8a3755462f65c032528af70c6582abf89f91b2bc:

Quoted 9 lines
Quoted 6 lines

FWIW, I did verify 8a3755462f65c032528af70c6582abf89f91b2bc on AM437x-gp evem.

MMC Boot and DFU at u-boot prompt:
https://pastebin.ubuntu.com/p/gmT33ksrFC/
USB Host Boot: https://pastebin.ubuntu.com/p/zyn8PNdJ5V/

Pulled, but I expect only fixes after this one.

Roger :-)

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de -------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20181213/d9c5d18d/attachment.sig>