Skip to contentSkip to conversation

build: Remake config-host.mak when VERSION changes

PATCH In review Markus Armbruster 2 participants 2 messages Dec 14, 2018 – Dec 17, 2018 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 build: Remake config-host.mak when VERSION changes

configure gets the version number from VERSION, and writes it to config-host.mak. The make dependency for that is missing. Because of that, a rebuild after a VERSION change may not pick up the change. Fix that.

---
 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Makefile +1 -1
index c8b9efdad4..038780c6d0 100644
@@ -67,7 +67,7 @@ CONFIG_ALL=y
 -include config-all-devices.mak
 -include config-all-disas.mak
 
-config-host.mak: $(SRC_PATH)/configure $(SRC_PATH)/pc-bios
+config-host.mak: $(SRC_PATH)/configure $(SRC_PATH)/pc-bios $(SRC_PATH)/VERSION
 	@echo $@ is out-of-date, running configure
 	@# TODO: The next lines include code which supports a smooth
 	@# transition from old configurations without config.status.
Signature · 1 line
2.17.2
Reviewed-by on v1 1/1
#1 lore raw
Quoted 9 lines · Markus Armbruster

configure gets the version number from VERSION, and writes it to config-host.mak. The make dependency for that is missing. Because of that, a rebuild after a VERSION change may not pick up the change. Fix that.

---
  Makefile | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 15 lines
Makefile +1 -1
index c8b9efdad4..038780c6d0 100644
@@ -67,7 +67,7 @@ CONFIG_ALL=y
  -include config-all-devices.mak
  -include config-all-disas.mak
 
-config-host.mak: $(SRC_PATH)/configure $(SRC_PATH)/pc-bios
+config-host.mak: $(SRC_PATH)/configure $(SRC_PATH)/pc-bios $(SRC_PATH)/VERSION
  	@echo $@ is out-of-date, running configure
  	@# TODO: The next lines include code which supports a smooth
  	@# transition from old configurations without config.status.
Signature · 3 lines
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org