Skip to contentSkip to conversation

drm/msm/dpu: Change RGB565 and BGR565 format map.

PATCH Superseded Tanmay Shah 2 participants 3 messages Dec 14, 2018 2 messages not in the archive

Subsystems (2)

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/msm/dpu: Change RGB565 and BGR565 format map.

Red and Blue colors will be interchanged on display with current format maps for RGB565 and BGR565.

Change both format maps to dispaly correct colors.

---
 drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c +2 -2
index d53abc8ce670..f59fe1a9f4b9 100644
@@ -263,13 +263,13 @@ static const struct dpu_format dpu_format_map[] = {
 
 	INTERLEAVED_RGB_FMT(RGB565,
 		0, COLOR_5BIT, COLOR_6BIT, COLOR_5BIT,
-		C1_B_Cb, C0_G_Y, C2_R_Cr, 0, 3,
+		C2_R_Cr, C0_G_Y, C1_B_Cb, 0, 3,
 		false, 2, 0,
 		DPU_FETCH_LINEAR, 1),
 
 	INTERLEAVED_RGB_FMT(BGR565,
 		0, COLOR_5BIT, COLOR_6BIT, COLOR_5BIT,
-		C2_R_Cr, C0_G_Y, C1_B_Cb, 0, 3,
+		C1_B_Cb, C0_G_Y, C2_R_Cr, 0, 3,
 		false, 2, 0,
 		DPU_FETCH_LINEAR, 1),
 
Signature · 7 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

_______________________________________________
Freedreno mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/freedreno

A message that is not in the archive (sent off-list or not yet received): 20181214182340.1195-1-tanmay-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org

Reviewed-by Jayant Shekhar
#2 lore raw
Quoted 6 lines · Tanmay Shah

Red and Blue colors will be interchanged on display with current format maps for RGB565 and BGR565.

Change both format maps to dispaly correct colors.

LGTM.

Quoted 15 lines
---
 drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c +0 -1
index d53abc8ce670..f59fe1a9f4b9 100644
@@ -263,13 +263,13 @@ static const struct dpu_format dpu_format_map[] = 
 {
 
 	INTERLEAVED_RGB_FMT(RGB565,
 		0, COLOR_5BIT, COLOR_6BIT, COLOR_5BIT,
-		C1_B_Cb, C0_G_Y, C2_R_Cr, 0, 3,

drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c static const struct dpu_format dpu_format_map[] = · line 275

Quoted 10 lines
drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c +2 -1
+		C2_R_Cr, C0_G_Y, C1_B_Cb, 0, 3,
 		false, 2, 0,
 		DPU_FETCH_LINEAR, 1),
 
 	INTERLEAVED_RGB_FMT(BGR565,
 		0, COLOR_5BIT, COLOR_6BIT, COLOR_5BIT,
-		C2_R_Cr, C0_G_Y, C1_B_Cb, 0, 3,
+		C1_B_Cb, C0_G_Y, C2_R_Cr, 0, 3,
 		false, 2, 0,
 		DPU_FETCH_LINEAR, 1),

_______________________________________________
Freedreno mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/freedreno

A message that is not in the archive (sent off-list or not yet received): 9ad795cd7e2a31887deaa5affd407c29-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org

#4 lore raw
Quoted 6 lines · On 2018-12-15 00:04, [email protected] wrote:
Quoted 5 lines · Tanmay Shah

Red and Blue colors will be interchanged on display with current format maps for RGB565 and BGR565.

Change both format maps to dispaly correct colors.

spelling: dispaly/display

Quoted 25 lines
Quoted 1 line

LGTM.

Quoted 19 lines
---
 drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c +1 -1
index d53abc8ce670..f59fe1a9f4b9 100644
@@ -263,13 +263,13 @@ static const struct dpu_format dpu_format_map[] 
 = {
 
 	INTERLEAVED_RGB_FMT(RGB565,
 		0, COLOR_5BIT, COLOR_6BIT, COLOR_5BIT,
-		C1_B_Cb, C0_G_Y, C2_R_Cr, 0, 3,
+		C2_R_Cr, C0_G_Y, C1_B_Cb, 0, 3,
 		false, 2, 0,
 		DPU_FETCH_LINEAR, 1),
 
Quoted 10 lines

drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c static const struct dpu_format dpu_format_map[] = { · line 274

Quoted 6 lines
drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c +1 -1
 	INTERLEAVED_RGB_FMT(BGR565,
 		0, COLOR_5BIT, COLOR_6BIT, COLOR_5BIT,
-		C2_R_Cr, C0_G_Y, C1_B_Cb, 0, 3,
+		C1_B_Cb, C0_G_Y, C2_R_Cr, 0, 3,
 		false, 2, 0,
 		DPU_FETCH_LINEAR, 1),

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

_______________________________________________
Freedreno mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/freedreno