staging: fwserial: convert to DEFINE_SHOW_ATTRIBUTE
PATCH RESEND 1/1 staging: fwserial: convert to DEFINE_SHOW_ATTRIBUTE
Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.
Signed-off-by Yangtao Li <[email protected]>
--- drivers/staging/fwserial/fwserial.c | 32 ++++------------------------- 1 file changed, 4 insertions(+), 28 deletions(-)
drivers/staging/fwserial/fwserial.c +4 -28
@@ -1458,7 +1458,7 @@ static int fwtty_proc_show(struct seq_file *m, void *v)return 0 ; } -static int fwtty_debugfs_stats_show (struct seq_file *m,void *v) +static int fwtty_stats_show (struct seq_file *m,void *v) {struct fw_serial *serial = m->private;struct fwtty_port *port;
@@ -1476,8 +1476,9 @@ static int fwtty_debugfs_stats_show(struct seq_file *m, void *v) }return 0 ; } +DEFINE_SHOW_ATTRIBUTE (fwtty_stats); -static int fwtty_debugfs_peers_show (struct seq_file *m,void *v) +static int fwtty_peers_show (struct seq_file *m,void *v) {struct fw_serial *serial = m->private;struct fwtty_peer *peer;
@@ -1491,32 +1492,7 @@ static int fwtty_debugfs_peers_show(struct seq_file *m, void *v)rcu_read_unlock ();return 0 ; } - -static int fwtty_stats_open (struct inode *inode,struct file *fp) -{ -return single_open (fp, fwtty_debugfs_stats_show, inode->i_private); -} - -static int fwtty_peers_open (struct inode *inode,struct file *fp) -{ -return single_open (fp, fwtty_debugfs_peers_show, inode->i_private); -} - -static const struct file_operations fwtty_stats_fops = { - .owner =THIS_MODULE , - .open = fwtty_stats_open, - .read = seq_read, - .llseek = seq_lseek, - .release = single_release, -}; - -static const struct file_operations fwtty_peers_fops = { - .owner =THIS_MODULE , - .open = fwtty_peers_open, - .read = seq_read, - .llseek = seq_lseek, - .release = single_release, -}; +DEFINE_SHOW_ATTRIBUTE (fwtty_peers);static const struct tty_port_operations fwtty_port_ops = { .dtr_rts = fwtty_port_dtr_rts,
Signature · 1 line
2.17.0