ALSA: hda: add mute LED support for HP EliteBook 840 G4
PATCH 1/1 ALSA: hda: add mute LED support for HP EliteBook 840 G4
Tested with 4.19.8.
(Existing entries for similar models use CXT_FIXUP_HP_DOCK, which might be a better choice here as well, but that's far beyond my knowledge -- and I don't have a dock to test it with either.)
--- sound/pci/hda/patch_conexant.c | 1 + 1 file changed, 1 insertion(+)
sound/pci/hda/patch_conexant.c +1 -0
@@ -922,6 +922,7 @@ static const struct snd_pci_quirk cxt5066_fixups[] = {SND_PCI_QUIRK (0x1025 ,0x054f ,"Acer Aspire 4830T" ,CXT_FIXUP_ASPIRE_DMIC ),SND_PCI_QUIRK (0x103c ,0x8079 ,"HP EliteBook 840 G3" ,CXT_FIXUP_HP_DOCK ),SND_PCI_QUIRK (0x103c ,0x807C ,"HP EliteBook 820 G3" ,CXT_FIXUP_HP_DOCK ), +SND_PCI_QUIRK (0x103c ,0x828c ,"HP EliteBook 840 G4" ,CXT_FIXUP_MUTE_LED_GPIO ),SND_PCI_QUIRK (0x103c ,0x80FD ,"HP ProBook 640 G2" ,CXT_FIXUP_HP_DOCK ),SND_PCI_QUIRK (0x103c ,0x83b3 ,"HP EliteBook 830 G5" ,CXT_FIXUP_HP_DOCK ), SND_PCI_QUIRK(0x103c, 0x83d3, "HP ProBook 640 G4", CXT_FIXUP_HP_DOCK),
Signature · 6 lines
2.20.0 _______________________________________________ Alsa-devel mailing list [email protected] http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
Quoted 6 lines · Mantas Mikulėnas
Tested with 4.19.8.
(Existing entries for similar models use
CXT_FIXUP_HP_DOCK, which might be a better choice here as well, but that's far beyond my knowledge -- and I don't have a dock to test it with either.)
If CXT_FIXUP_HP_DOCK works for you, I guess it's better to use it. As you guessed, this is likely a better-matching one for EliteBook.
Also, the entries are (mostly) sorted in the PCI SSID order. Could you put your new entry in the right place?
thanks,
Takashi
Quoted 21 lines
Signed-off-by Mantas Mikulėnas <[email protected]>--- sound/pci/hda/patch_conexant.c | 1 + 1 file changed, 1 insertion(+)sound/pci/hda/patch_conexant.c +1
-0@@ -922,6 +922,7 @@ static const struct snd_pci_quirk cxt5066_fixups[] = {SND_PCI_QUIRK (0x1025 ,0x054f ,"Acer Aspire 4830T" ,CXT_FIXUP_ASPIRE_DMIC ),SND_PCI_QUIRK (0x103c ,0x8079 ,"HP EliteBook 840 G3" ,CXT_FIXUP_HP_DOCK ),SND_PCI_QUIRK (0x103c ,0x807C ,"HP EliteBook 820 G3" ,CXT_FIXUP_HP_DOCK ), +SND_PCI_QUIRK (0x103c ,0x828c ,"HP EliteBook 840 G4" ,CXT_FIXUP_MUTE_LED_GPIO ),SND_PCI_QUIRK (0x103c ,0x80FD ,"HP ProBook 640 G2" ,CXT_FIXUP_HP_DOCK ),SND_PCI_QUIRK (0x103c ,0x83b3 ,"HP EliteBook 830 G5" ,CXT_FIXUP_HP_DOCK ), SND_PCI_QUIRK(0x103c, 0x83d3, "HP ProBook 640 G4", CXT_FIXUP_HP_DOCK),Signature · 1 line
2.20.0
_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
Quoted 4 lines · Takashi Iwai
Quoted 1 line · Mantas Mikulėnas
Quoted 8 lines
Quoted 5 lines
Tested with 4.19.8.
(Existing entries for similar models use
CXT_FIXUP_HP_DOCK, which might be a better choice here as well, but that's far beyond my knowledge -- and I don't have a dock to test it with either.)If
CXT_FIXUP_HP_DOCKworks for you, I guess it's better to use it. As you guessed, this is likely a better-matching one for EliteBook.
Yes, it seems to work fine for me (the LEDs are controlled correctly and I haven't noticed any negative effects).
Quoted 2 lines
Also, the entries are (mostly) sorted in the PCI SSID order. Could you put your new entry in the right place?
Will do.
Signature · 5 lines
Mantas Mikulėnas _______________________________________________ Alsa-devel mailing list [email protected] http://mailman.alsa-project.org/mailman/listinfo/alsa-devel