Bug fixes for Qualcomm BT chip wcn3990
v4 cover Bug fixes for Qualcomm BT chip wcn3990
The below issues are found in the recent testing.
1. Observed device is not going into off state or not responding. As wcn3990 require a power pulses to turn on the irrespctive of igniting regulators, it was observed that power on or power off pulses are not in sync with respective to chip.
The below patch will help us to wait until byte is pushed on to wires.
* Bluetooth: hci_qca: use wait_until_sent() for power pulses
2. Observed Chip responding when we are in sleep.
This is due to turn on flow control during change baudrate request. The below patch will only pull the RTS line high instead of turning off the flow.
* Bluetooth: hci_qca: Pull RTS line high for baudrate change command.
3. Frame reassembly errors splashing on console.
wcn3990 requires will use multiple baudrates during booting stage. i.e. 2400 bps while sending power off pulse
115200 bps while sending power on pulse
port close
port open
set baudrate to 115200 request the chip version.
during above process, we are seeing some stray bytes coming up on the UART Rx FIFO it could be due to frequent baudrate change.
This patch will stop the frame reassembly errors.
* Bluetooth: hci_qca: Fix frame reassembly errors for wcn3990
4. Disable IBS state machine and flush Tx buffer
We are disabling IBS and flushing the Tx buffer before turning off the chip.
This is due to IBS state machine is active when we turn off the chip. This will stop queuing IBS protocol bytes.
* Bluetooth: hci_qca: Disable IBS state machine and flush Tx buffer
5. btqca: inject command complete event during fw download
Qualcomm latest chip will not send an command complete event for last packet of the fw dump sent, so here we are inject an command complete event.
* Bluetooth: btqca: inject command complete event during fw download
Changes in v3:
* moved IBS & qca_flush to different patch
* updated comments in code fo Deassert RTS patch
Changes in v4:
* used serdev_device_write_buf() instead of serdev_device_write().
* added new patch to stop logging of 0xfc00 timeout on console.
Balakrishna Godavarthi (5):
Bluetooth: hci_qca: use wait_until_sent() for power pulses
Bluetooth: hci_qca: Deassert RTS while baudrate change command
Bluetooth: hci_qca: Fix frame reassembly errors for wcn3990
Bluetooth: hci_qca: Disable IBS state machine and flush Tx buffer
Bluetooth: btqca: inject command complete event during fw download
drivers/bluetooth/btqca.c | 39 ++++++++++++++++++- drivers/bluetooth/btqca.h | 3 ++ drivers/bluetooth/hci_qca.c | 77 +++++++++++++++++++++---------------- 3 files changed, 84 insertions(+), 35 deletions(-)
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
PATCH v4 1/5 Bluetooth: hci_qca: use wait_until_sent() for power pulses
wcn3990 requires a power pulse to turn ON/OFF along with regulators. Sometimes we are observing the power pulses are sent out with some time delay, due to queuing these commands. This is causing synchronization issues with chip, which intern delay the chip setup or may end up with communication issues.
---
v4:
* used serdev_device_write_buf() instead of serdev_device_write()
v3:
* no change.
v2:
* Updated function qca_send_power_pulse()
* addressed reviewer comments.
v1:
* initial patch
--- drivers/bluetooth/hci_qca.c | 37 +++++++++++++------------------------ 1 file changed, 13 insertions(+), 24 deletions(-)
drivers/bluetooth/hci_qca.c +13 -24
@@ -1013,11 +1013,9 @@ static inline void host_set_baudrate(struct hci_uart *hu, unsigned int speed)hci_uart_set_baudrate (hu, speed); } -static int qca_send_power_pulse (struct hci_dev *hdev,u8 cmd) +static int qca_send_power_pulse (struct hci_uart *hu,u8 cmd) { -struct hci_uart *hu =hci_get_drvdata (hdev); -struct qca_data *qca = hu->priv; -struct sk_buff *skb; +int ret;/* These power pulses are single byte command which are sent * at required baudrate to wcn3990. On wcn3990, we have an external
@@ -1029,19 +1027,16 @@ static int qca_send_power_pulse(struct hci_dev *hdev, u8 cmd)* save power. Disabling hardware flow control is mandatory while * sending power pulses to SoC. */ -bt_dev_dbg (hdev,"sending power pulse %02x to SoC" , cmd); - - skb =bt_skb_alloc (sizeof (cmd),GFP_KERNEL ); -if (!skb) -return -ENOMEM ; - +bt_dev_dbg (hu->hdev,"sending power pulse %02x to SoC" , cmd);hci_uart_set_flow_control (hu, true); + ret =serdev_device_write_buf (hu->serdev, &cmd,sizeof (cmd)); +if (ret <0 ) { +bt_dev_err (hu->hdev,"failed to send power pulse %02x to SoC" , + cmd); +return ret; + } -skb_put_u8 (skb, cmd); -hci_skb_pkt_type (skb) =HCI_COMMAND_PKT ; - -skb_queue_tail (&qca->txq, skb); -hci_uart_tx_wakeup (hu); +serdev_device_wait_until_sent (hu->serdev,0 );/* Wait for 100 uS for SoC to settle down */ usleep_range (100 ,200 );
@@ -1116,7 +1111,6 @@ static int qca_set_speed(struct hci_uart *hu, enum qca_speed_type speed_type)static int qca_wcn3990_init (struct hci_uart *hu) { -struct hci_dev *hdev = hu->hdev;struct qca_serdev *qcadev;int ret;
@@ -1139,12 +1133,12 @@ static int qca_wcn3990_init(struct hci_uart *hu)/* Forcefully enable wcn3990 to enter in to boot mode. */ host_set_baudrate (hu,2400 ); - ret =qca_send_power_pulse (hdev,QCA_WCN3990_POWEROFF_PULSE ); + ret =qca_send_power_pulse (hu,QCA_WCN3990_POWEROFF_PULSE );if (ret)return ret;qca_set_speed (hu,QCA_INIT_SPEED ); - ret =qca_send_power_pulse (hdev,QCA_WCN3990_POWERON_PULSE ); + ret =qca_send_power_pulse (hu,QCA_WCN3990_POWERON_PULSE );if (ret)return ret;
@@ -1274,13 +1268,8 @@ static const struct qca_vreg_data qca_soc_data = {static void qca_power_shutdown (struct hci_uart *hu) { -struct serdev_device *serdev = hu->serdev; -unsigned char cmd =QCA_WCN3990_POWEROFF_PULSE ; -host_set_baudrate (hu,2400 ); -hci_uart_set_flow_control (hu, true); -serdev_device_write_buf (serdev, &cmd,sizeof (cmd)); -hci_uart_set_flow_control (hu, false); +qca_send_power_pulse (hu,QCA_WCN3990_POWEROFF_PULSE );qca_power_setup (hu, false); }
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
PATCH v4 2/5 Bluetooth: hci_qca: Deassert RTS while baudrate change command
In reply to Balakrishna GodavarthiThis patch will help to stop frame reassembly errors while changing the baudrate. This is because host send a change baudrate request command to the chip with 115200 bps, Whereas chip will change their UART clocks to the enable for new baudrate and sends the response for the change request command with newer baudrate, On host side we are still operating in 115200 bps which results of reading garbage data. Here we are pulling RTS line, so that chip we will wait to send data to host until host change its baudrate.
---
v4:
* no change
v3:
* Updated comments in code to be more specific.
v2:
* updated commit text and comments.
v1:
* initial patch
--- drivers/bluetooth/hci_qca.c | 24 +++++++++++++----------- 1 file changed, 13 insertions(+), 11 deletions(-)
drivers/bluetooth/hci_qca.c +13 -11
@@ -963,7 +963,6 @@ static int qca_set_baudrate(struct hci_dev *hdev, uint8_t baudrate)struct hci_uart *hu =hci_get_drvdata (hdev);struct qca_data *qca = hu->priv;struct sk_buff *skb; -struct qca_serdev *qcadev;u8 cmd[] = {0x01 ,0x48 ,0xFC ,0x01 ,0x00 };if (baudrate >QCA_BAUDRATE_3200000 )
@@ -977,13 +976,6 @@ static int qca_set_baudrate(struct hci_dev *hdev, uint8_t baudrate)return -ENOMEM ; } -/* Disabling hardware flow control is mandatory while -* sending change baudrate request to wcn3990 SoC. -*/ - qcadev =serdev_device_get_drvdata (hu->serdev); -if (qcadev->btsoc_type ==QCA_WCN3990 ) -hci_uart_set_flow_control (hu, true); -/* Assign commands to change baudrate and packet type. */ skb_put_data (skb, cmd,sizeof (cmd));hci_skb_pkt_type (skb) =HCI_COMMAND_PKT ;
@@ -999,9 +991,6 @@ static int qca_set_baudrate(struct hci_dev *hdev, uint8_t baudrate)schedule_timeout (msecs_to_jiffies (BAUDRATE_SETTLE_TIMEOUT_MS ));set_current_state (TASK_RUNNING ); -if (qcadev->btsoc_type ==QCA_WCN3990 ) -hci_uart_set_flow_control (hu, false); -return 0 ; }
@@ -1086,6 +1075,7 @@ static int qca_check_speeds(struct hci_uart *hu)static int qca_set_speed (struct hci_uart *hu,enum qca_speed_type speed_type) {unsigned int speed, qca_baudrate; +struct qca_serdev *qcadev;int ret;if (speed_type ==QCA_INIT_SPEED ) {
@@ -1097,6 +1087,15 @@ static int qca_set_speed(struct hci_uart *hu, enum qca_speed_type speed_type)if (!speed)return 0 ; +/* Deassert RTS while changing the baudrate of chip and host. +* This will prevent chip from transmitting its response with +* the new baudrate while the host port is still operating at +* the old speed. +*/ + qcadev =serdev_device_get_drvdata (hu->serdev); +if (qcadev->btsoc_type ==QCA_WCN3990 ) +serdev_device_set_rts (hu->serdev, false); + qca_baudrate =qca_get_baudrate_value (speed);bt_dev_dbg (hu->hdev,"Set UART speed to %d" , speed); ret =qca_set_baudrate (hu->hdev, qca_baudrate);
@@ -1104,6 +1103,9 @@ static int qca_set_speed(struct hci_uart *hu, enum qca_speed_type speed_type)return ret;host_set_baudrate (hu, speed); + +if (qcadev->btsoc_type ==QCA_WCN3990 ) +serdev_device_set_rts (hu->serdev, true); }return 0 ;
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
PATCH v4 3/5 Bluetooth: hci_qca: Fix frame reassembly errors for wcn3990
In reply to Balakrishna GodavarthiDuring initalization of wcn3990, we observed UART is reading some stray bytes on the Rx line. This is logging Frame reassembly errors on the serial console. This could be because of tristate of Tx line of wcn3990 during boot up.
[ 176.929612] Bluetooth: hci_qca.c:qca_recv() hci0: Frame reassembly failed (-84) [ 176.945734] Bluetooth: hci_qca.c:qca_recv() hci0: Frame reassembly failed (-84) [ 176.953298] Bluetooth: hci_qca.c:qca_recv() hci0: Frame reassembly failed (-84) [ 177.010660] Bluetooth: hci_qca.c:qca_recv() hci0: Frame reassembly failed (-84) [ 177.067633] Bluetooth: hci_qca.c:qca_recv() hci0: Frame reassembly failed (-84)
Now we enable a flag during bootup to stop executing proto receive function and clear it back once the initialization is done.
---
v4:
* no change
v3:
* moved ibs disable and qca_flush to different patch
* updated commnents in code.
v2:
* Updated commit text & comments.
v1:
* initial patch
--- drivers/bluetooth/hci_qca.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+)
drivers/bluetooth/hci_qca.c +16 -0
@@ -56,6 +56,7 @@/* Controller states */ #define STATE_IN_BAND_SLEEP_ENABLED 1 +#define STATE_DISCARD_RX 2#define IBS_WAKE_RETRANS_TIMEOUT_MS 100#define IBS_TX_IDLE_TIMEOUT_MS 2000
@@ -511,6 +512,7 @@ static int qca_open(struct hci_uart *hu) }else { hu->init_speed = qcadev->init_speed; hu->oper_speed = qcadev->oper_speed; +set_bit (STATE_DISCARD_RX , &qca->flags); ret =qca_power_setup (hu, true);if (ret) {destroy_workqueue (qca->workqueue);
@@ -903,6 +905,13 @@ static int qca_recv(struct hci_uart *hu, const void *data, int count)if (!test_bit (HCI_UART_REGISTERED , &hu->flags))return -EUNATCH ; +/* We discard Rx data received while device is in booting +* stage, This is because of BT chip Tx line is in tristate. +* Due to this we read some garbage data on UART Rx. +*/ +if (test_bit (STATE_DISCARD_RX , &qca->flags)) +return 0 ; + qca->rx_skb =h4_recv_buf (hu->hdev, qca->rx_skb, data, count, qca_recv_pkts,ARRAY_SIZE (qca_recv_pkts));if (IS_ERR (qca->rx_skb)) {
@@ -1194,6 +1203,7 @@ static int qca_setup(struct hci_uart *hu)if (ret)return ret; +clear_bit (STATE_DISCARD_RX , &qca->flags); ret =qca_read_soc_version (hdev, &soc_ver);if (ret)return ret;
@@ -1270,6 +1280,12 @@ static const struct qca_vreg_data qca_soc_data = {static void qca_power_shutdown (struct hci_uart *hu) { +struct qca_data *qca = hu->priv; + +/* From this point we go into power off state. But serial port is +* still open, discard all the garbage data received on the Rx line. +*/ +set_bit (STATE_DISCARD_RX , &qca->flags);host_set_baudrate (hu,2400 );qca_send_power_pulse (hu,QCA_WCN3990_POWEROFF_PULSE );qca_power_setup (hu, false);
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
PATCH v4 4/5 Bluetooth: hci_qca: Disable IBS state machine and flush Tx buffer
In reply to Balakrishna GodavarthiDuring hci down we observed IBS sleep commands are queued in the Tx buffer and hci_uart_write_work is sending data to the chip which is not required as the chip is powered off. This patch will disable IBS and flush the Tx buffer before we turn off the chip.
---
v4:
* no change.
v3:
* initial patch
--- drivers/bluetooth/hci_qca.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/bluetooth/hci_qca.c +2 -0
@@ -1286,6 +1286,8 @@ static void qca_power_shutdown(struct hci_uart *hu)* still open, discard all the garbage data received on the Rx line. */ set_bit (STATE_DISCARD_RX , &qca->flags); +clear_bit (STATE_IN_BAND_SLEEP_ENABLED , &qca->flags); +qca_flush (hu);host_set_baudrate (hu,2400 );qca_send_power_pulse (hu,QCA_WCN3990_POWEROFF_PULSE );qca_power_setup (hu, false);
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
PATCH v4 5/5 Bluetooth: btqca: inject command complete event during fw download
In reply to Balakrishna GodavarthiLatest qualcomm chips are not sending an command complete event for every firmware packet sent to chip. They only respond with a vendor specific event for the last firmware packet. This optimization will decrease the BT ON time. Due to this we are seeing a timeout error message logs on the console during firmware download. Now we are injecting a command complete event once we receive an vendor specific event for the last RAM firmware packet.
---
v4:
* intial patch.
--- drivers/bluetooth/btqca.c | 39 ++++++++++++++++++++++++++++++++++++++- drivers/bluetooth/btqca.h | 3 +++ 2 files changed, 41 insertions(+), 1 deletion(-)
drivers/bluetooth/btqca.c +38 -1
@@ -144,6 +144,7 @@ static void qca_tlv_check_data(struct rome_config *config,* In case VSE is skipped, only the last segment is acked. */ config->dnld_mode = tlv_patch->download_mode; + config->dnld_type = config->dnld_mode;BT_DBG ("Total Length : %d bytes" ,le32_to_cpu (tlv_patch->total_size));
@@ -264,6 +265,31 @@ static int qca_tlv_send_segment(struct hci_dev *hdev, int seg_size,return err; } +static int qca_inject_cmd_complete_event (struct hci_dev *hdev) +{ +struct hci_event_hdr *hdr; +struct hci_ev_cmd_complete *evt; +struct sk_buff *skb; + + skb =bt_skb_alloc (sizeof (*hdr) +sizeof (*evt) +1 ,GFP_KERNEL ); +if (!skb) +return -ENOMEM ; + + hdr =skb_put (skb,sizeof (*hdr)); + hdr->evt =HCI_EV_CMD_COMPLETE ; + hdr->plen =sizeof (*evt) +1 ; + + evt =skb_put (skb,sizeof (*evt)); + evt->ncmd =1 ; + evt->opcode =HCI_OP_NOP ; + +skb_put_u8 (skb,QCA_HCI_CC_SUCCESS ); + +hci_skb_pkt_type (skb) =HCI_EVENT_PKT ; + +return hci_recv_frame (hdev, skb); +} +static int qca_download_firmware (struct hci_dev *hdev,struct rome_config *config) {
@@ -297,11 +323,22 @@ static int qca_download_firmware(struct hci_dev *hdev, ret =qca_tlv_send_segment (hdev, segsize, segment, config->dnld_mode);if (ret) -break ; + goto out; segment += segsize; } +/* Latest qualcomm chipsets are not sending a command complete event +* for every fw packet sent. They only respond with a vendor specific +* event for the last packet. This optimization in the chip will +* decrease the BT in initialization time. Here we will inject a command +* complete event to avoid a command timeout error message. +*/ +if ((config->dnld_type ==ROME_SKIP_EVT_VSE_CC || + config->dnld_type ==ROME_SKIP_EVT_VSE )) +return qca_inject_cmd_complete_event (hdev); + +out:release_firmware (fw);return ret;
drivers/bluetooth/btqca.h +3 -0
@@ -40,6 +40,8 @@#define QCA_WCN3990_POWERON_PULSE 0xFC#define QCA_WCN3990_POWEROFF_PULSE 0xC0 +#define QCA_HCI_CC_SUCCESS 0x00 +enum qca_bardrate {QCA_BAUDRATE_115200 =0 ,QCA_BAUDRATE_57600 ,
@@ -81,6 +83,7 @@ struct rome_config {char fwname[64 ];uint8_t user_baud_rate;enum rome_tlv_dnld_mode dnld_mode; +enum rome_tlv_dnld_mode dnld_type; };struct edl_event_hdr {
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
Re: [PATCH v4 1/5] Bluetooth: hci_qca: use wait_until_sent() for power pulses
In reply to Balakrishna GodavarthiQuoted 50 lines · Balakrishna Godavarthi
wcn3990 requires a power pulse to turn ON/OFF along with regulators. Sometimes we are observing the power pulses are sent out with some time delay, due to queuing these commands. This is causing synchronization issues with chip, which intern delay the chip setup or may end up with communication issues.
Signed-off-by Balakrishna Godavarthi <[email protected]>---
v4:
* usedserdev_device_write_buf()instead ofserdev_device_write()v3:
* no change.
v2:
* Updated functionqca_send_power_pulse()
* addressed reviewer comments.v1:
* initial patch--- drivers/bluetooth/hci_qca.c | 37 +++++++++++++------------------------ 1 file changed, 13 insertions(+), 24 deletions(-)drivers/bluetooth/hci_qca.c +2
-8@@ -1013,11 +1013,9 @@ static inline void host_set_baudrate(struct hci_uart *hu, unsigned int speed)hci_uart_set_baudrate (hu, speed); } -static int qca_send_power_pulse (struct hci_dev *hdev,u8 cmd) +static int qca_send_power_pulse (struct hci_uart *hu,u8 cmd) { -struct hci_uart *hu =hci_get_drvdata (hdev); -struct qca_data *qca = hu->priv; -struct sk_buff *skb; +int ret;/* These power pulses are single byte command which are sent * at required baudrate to wcn3990. On wcn3990, we have an external @@ -1029,19 +1027,16 @@ static int qca_send_power_pulse(struct hci_dev *hdev, u8 cmd)* save power. Disabling hardware flow control is mandatory while * sending power pulses to SoC. */ -bt_dev_dbg (hdev,"sending power pulse %02x to SoC" , cmd); - - skb =bt_skb_alloc (sizeof (cmd),GFP_KERNEL ); -if (!skb)
drivers/bluetooth/hci_qca.c static int qca_send_power_pulse(struct hci_dev *hdev, u8 cmd) · line 1037
Quoted 10 lines
drivers/bluetooth/hci_qca.c +7
-2-return -ENOMEM ; - +bt_dev_dbg (hu->hdev,"sending power pulse %02x to SoC" , cmd);hci_uart_set_flow_control (hu, true); + ret =serdev_device_write_buf (hu->serdev, &cmd,sizeof (cmd)); +if (ret <0 ) { +bt_dev_err (hu->hdev,"failed to send power pulse %02x to SoC" , + cmd); +return ret; + }
As I mentioned earlier, serdev_device_write_buf() can buffer less than sizeof(cmd) bytes if the tty driver's write buffer is full (and return the number of bytes buffered).
How you want to deal with that is up to you and the bluetooth maintainers, but I think you want to at least log it even if you choose to ignore it.
Johan
Re: [PATCH v4 1/5] Bluetooth: hci_qca: use wait_until_sent() for power pulses
Hi Johan,
Quoted 69 lines · Johan Hovold
Quoted 53 lines · Balakrishna Godavarthi
wcn3990 requires a power pulse to turn ON/OFF along with regulators. Sometimes we are observing the power pulses are sent out with some time delay, due to queuing these commands. This is causing synchronization issues with chip, which intern delay the chip setup or may end up with communication issues.
Signed-off-by Balakrishna Godavarthi <[email protected]>---
v4:
* usedserdev_device_write_buf()instead ofserdev_device_write()v3:
* no change.
v2:
* Updated functionqca_send_power_pulse()
* addressed reviewer comments.v1:
* initial patch--- drivers/bluetooth/hci_qca.c | 37 +++++++++++++------------------------ 1 file changed, 13 insertions(+), 24 deletions(-)drivers/bluetooth/hci_qca.c +2
-4@@ -1013,11 +1013,9 @@ static inline void host_set_baudrate(struct hci_uart *hu, unsigned int speed)hci_uart_set_baudrate (hu ,speed ); } -static int qca_send_power_pulse (struct hci_dev *hdev,u8 cmd) +static int qca_send_power_pulse (struct hci_uart *hu,u8 cmd) { -struct hci_uart *hu =hci_get_drvdata (hdev); -struct qca_data *qca = hu->priv; -struct sk_buff *skb; +int ret;/* These power pulses are single byte command which are sent drivers/bluetooth/hci_qca.c +0
-4* at required baudrate to wcn3990. On wcn3990, we have an external @@ -1029,19 +1027,16 @@ static int qca_send_power_pulse(struct hci_dev*hdev, u8 cmd) * save power. Disabling hardware flow control is mandatory while * sending power pulses to SoC. */ -bt_dev_dbg (hdev,"sending power pulse %02x to SoC" , cmd); - - skb =bt_skb_alloc (sizeof (cmd),GFP_KERNEL ); -if (!skb)drivers/bluetooth/hci_qca.c static int qca_send_power_pulse(struct hci_dev · line 1038
Quoted 10 lines
drivers/bluetooth/hci_qca.c +7
-2-return -ENOMEM ; - +bt_dev_dbg (hu->hdev,"sending power pulse %02x to SoC" , cmd);hci_uart_set_flow_control (hu, true); + ret =serdev_device_write_buf (hu->serdev, &cmd,sizeof (cmd)); +if (ret <0 ) { +bt_dev_err (hu->hdev,"failed to send power pulse %02x to SoC" , + cmd); +return ret; + }As I mentioned earlier,
serdev_device_write_buf()can buffer less than sizeof(cmd) bytes if the tty driver's write buffer is full (and return the number of bytes buffered).
Quoted 5 lines
How you want to deal with that is up to you and the bluetooth maintainers, but I think you want to at least log it even if you choose to ignore it.
Johan
[Bala]: thanks for reminding me for buffer size.
we use the qca_send_power_pulse() where we useserdev_write_buf() to send
a single byte commands to the chip during power ON or power OFF
i.e. as soon as we open port or before close.
during power on:
ideally open port can guarantee me to the have tty buffer empty
as we didn't queued any data.
let us assume that if the buffer is full(),serdev_device_write_buf() will return -1 (as buffer is full)
anyways i have check for return status to log the write_buf
failure.
during power off:
yes here we may face an issue as already we have some data
queued in the buffer. i.e. due to previous transactions.
I think we can achieve this by callingserdev_device_write_flush() and then calling serdev_device_write_buf().
Signature · 2 lines
Regards Balakrishna.