Skip to contentSkip to conversation

sdk: Fix SDKIMAGE_LINGUAS handling

PATCH New Richard Weinberger 1 participant 1 message Dec 18, 2018

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sdk: Fix SDKIMAGE_LINGUAS handling

Currently SDKIMAGE_LINGUAS is broken for any inputs except "all". In the non-"all" case, each enabled language package is installed via pm.install("nativesdk-glibc-binary-localedata-%s.utf-8" % lang) This will throw a python exception since pm.install() expects a list of strings and not a string.

Fix the problem by passing a single element list to pm.install().

Fixes 67615e01751b ("rootfs_rpm.bbclass: migrate image creation to dnf")
---
 meta/lib/oe/sdk.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/lib/oe/sdk.py +1 -1
index 153b07d76b40..98073cf0cac7 100644
@@ -96,7 +96,7 @@ class Sdk(object, metaclass=ABCMeta):
                 pm.install_glob("nativesdk-glibc-binary-localedata-*.utf-8", sdk=True)
             else:
                 for lang in linguas.split():
-                    pm.install("nativesdk-glibc-binary-localedata-%s.utf-8" % lang)
+                    pm.install(["nativesdk-glibc-binary-localedata-%s.utf-8" % lang])
             # Generate a locale archive of them
             target_arch = self.d.getVar('SDK_ARCH')
             rootfs = oe.path.join(self.sdk_host_sysroot, self.sdk_native_path)
Signature · 1 line
2.20.1