hpet: Fix missing '=' character in the __setup() code of hpet_mmap_enable.

PATCH Superseded Buland Singh 2 participants 5 messages Dec 19, 2018 – Dec 20, 2018

Subsystems (2)

Char and misc drivers Hpet: High Precision Event Timers driver

lore

Share & tools

lore

Buland Singh

author

2018-12-19 09:25 UTC #0 lore raw

PATCH 1/1 hpet: Fix missing '=' character in the __setup() code of hpet_mmap_enable.

The kernel command parameter 'hpet_mmap' never takes effect due to missing '=' character in the __setup() code of hpet_mmap_enable and the memory map of the HPET registers never get expose to userspace.

Signed-off-by Buland Singh <[email protected]>

---
 drivers/char/hpet.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/char/hpet.c +1 -1

index 4a22b4b41aef..9bffcd37cc7b 100644
@@ -377,7 +377,7 @@ static __init int hpet_mmap_enable(char *str)
 	pr_info("HPET mmap %s\n", hpet_mmap_enabled ? "enabled" : "disabled");
 	return 1;
 }
-__setup("hpet_mmap", hpet_mmap_enable);
+__setup("hpet_mmap=", hpet_mmap_enable);
 
 static int hpet_mmap(struct file *file, struct vm_area_struct *vma)
 {

Signature · 1 line

2.19.1

Greg KH

maintainer

2018-12-19 09:46 UTC #1 lore raw

Quoted 14 lines · Buland Singh

The kernel command parameter 'hpet_mmap' never takes effect due to missing '=' character in the __setup() code of hpet_mmap_enable and the memory map of the HPET registers never get expose to userspace.
Signed-off-by Buland Singh <[email protected]>
---
 drivers/char/hpet.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/char/hpet.c +0 -0
index 4a22b4b41aef..9bffcd37cc7b 100644

drivers/char/hpet.c static __init int hpet_mmap_enable(char *str) · line 380

Quoted 5 lines

drivers/char/hpet.c +1 -1

@@ -377,7 +377,7 @@ static __init int hpet_mmap_enable(char *str)
 	pr_info("HPET mmap %s\n", hpet_mmap_enabled ? "enabled" : "disabled");
 	return 1;
 }
-__setup("hpet_mmap", hpet_mmap_enable);
+__setup("hpet_mmap=", hpet_mmap_enable);

What commit caused this bug? Should this go to the stable kernel trees?

thanks,

greg k-h

Buland Singh

author

2018-12-19 12:04 UTC #2 lore raw

Quoted 10 lines · Greg KH

Quoted 9 lines · Buland Singh
The kernel command parameter 'hpet_mmap' never takes effect due to missing '=' character in the __setup() code of hpet_mmap_enable and the memory map of the HPET registers never get expose to userspace.
Signed-off-by Buland Singh <[email protected]>
---
  drivers/char/hpet.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

Quoted 12 lines

drivers/char/hpet.c static __init int hpet_mmap_enable(char *str) · line 380
Quoted 10 lines
drivers/char/hpet.c +1 -1
index 4a22b4b41aef..9bffcd37cc7b 100644
@@ -377,7 +377,7 @@ static __init int hpet_mmap_enable(char *str)
  	pr_info("HPET mmap %s\n", hpet_mmap_enabled ? "enabled" : "disabled");
  	return 1;
  }
-__setup("hpet_mmap", hpet_mmap_enable);
+__setup("hpet_mmap=", hpet_mmap_enable);
What commit caused this bug? Should this go to the stable kernel trees?

Hello Greg,

The commit id is 3d035f58. The bug is there since the initial patch which introduced the kernel parameter 'hpet_mmap'. The fix should go to the stable kernel trees.

Regards,
Buland Singh

Greg KH

maintainer

2018-12-19 12:37 UTC #3 lore raw

Quoted 24 lines · Buland Singh

Quoted 10 lines · Greg KH
Quoted 9 lines · Buland Singh
The kernel command parameter 'hpet_mmap' never takes effect due to missing '=' character in the __setup() code of hpet_mmap_enable and the memory map of the HPET registers never get expose to userspace.
Signed-off-by Buland Singh <[email protected]>
---
  drivers/char/hpet.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 12 lines
drivers/char/hpet.c static __init int hpet_mmap_enable(char *str) · line 380
Quoted 10 lines
drivers/char/hpet.c +1 -1
index 4a22b4b41aef..9bffcd37cc7b 100644
@@ -377,7 +377,7 @@ static __init int hpet_mmap_enable(char *str)
  	pr_info("HPET mmap %s\n", hpet_mmap_enabled ? "enabled" : "disabled");
  	return 1;
  }
-__setup("hpet_mmap", hpet_mmap_enable);
+__setup("hpet_mmap=", hpet_mmap_enable);
What commit caused this bug? Should this go to the stable kernel trees?

Quoted 5 lines

Hello Greg,
The commit id is 3d035f58. The bug is there since the initial patch which introduced the kernel parameter 'hpet_mmap'. The fix should go to the stable kernel trees.

Great, can you resend it with all of this information (a fixes: and cc:
stable tag?)

thanks,

greg k-h

Buland Singh

author

2018-12-20 06:38 UTC #4 lore raw

Quoted 25 lines · Greg KH

Quoted 24 lines · Buland Singh
Quoted 22 lines · Greg KH
Quoted 14 lines · Buland Singh
The kernel command parameter 'hpet_mmap' never takes effect due to missing '=' character in the __setup() code of hpet_mmap_enable and the memory map of the HPET registers never get expose to userspace.
Signed-off-by Buland Singh <[email protected]>
---
   drivers/char/hpet.c | 2 +-
   1 file changed, 1 insertion(+), 1 deletion(-)
drivers/char/hpet.c +0 -0
index 4a22b4b41aef..9bffcd37cc7b 100644
drivers/char/hpet.c static __init int hpet_mmap_enable(char *str) · line 380
Quoted 5 lines
drivers/char/hpet.c +1 -1
@@ -377,7 +377,7 @@ static __init int hpet_mmap_enable(char *str)
   	pr_info("HPET mmap %s\n", hpet_mmap_enabled ? "enabled" : "disabled");
   	return 1;
   }
-__setup("hpet_mmap", hpet_mmap_enable);
+__setup("hpet_mmap=", hpet_mmap_enable);
What commit caused this bug? Should this go to the stable kernel trees?

Quoted 8 lines

Quoted 5 lines
Hello Greg,
The commit id is 3d035f58. The bug is there since the initial patch which introduced the kernel parameter 'hpet_mmap'. The fix should go to the stable kernel trees.
Great, can you resend it with all of this information (a fixes: and cc:
stable tag?)

Sure, I will send the v2 with all the information.

Regards,
Buland Singh