Skip to contentSkip to conversation

Fix to mlx5 devx interface

PATCH Applied Leon Romanovsky 3 participants 6 messages Dec 19, 2018 – Dec 20, 2018

Subsystems (5)
Networking Network drivers InfiniBand Mellanox mlx5 core +1 more subsystems
lore
Share & tools
lore

Leon Romanovsky

author
#0 lore raw

cover Fix to mlx5 devx interface

From: Leon Romanovsky <[email protected]>

Hi,

This small fix to mlx5 devx interface is separated to two, so we can apply first patch to mlx5-next.

Thanks

Yishai Hadas (2):
IB/mlx5: Introduce uid as part of alloc/dealloc transport domain IB/mlx5: Use uid as part of alloc/dealloc transport domain

 drivers/infiniband/hw/mlx5/cmd.c | 2 ++
 include/linux/mlx5/mlx5_ifc.h    | 4 ++--
 2 files changed, 4 insertions(+), 2 deletions(-)
author
#1 lore raw

PATCH 1/2 IB/mlx5: Introduce uid as part of alloc/dealloc transport domain

From: Yishai Hadas <[email protected]>

Introduce uid as part of alloc/dealloc transport domain to match the device specification.

Signed-off-by Yishai Hadas <[email protected]>
Reviewed-by Artemy Kovalyov <[email protected]>
Signed-off-by Leon Romanovsky <[email protected]>
---
 include/linux/mlx5/mlx5_ifc.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
include/linux/mlx5/mlx5_ifc.h +2 -2
index 15093356a226..61368ec2d295 100644
@@ -6593,7 +6593,7 @@ struct mlx5_ifc_dealloc_transport_domain_out_bits {
 
 struct mlx5_ifc_dealloc_transport_domain_in_bits {
 	u8         opcode[0x10];
-	u8         reserved_at_10[0x10];
+	u8         uid[0x10];
 
 	u8         reserved_at_20[0x10];
 	u8         op_mod[0x10];

@@ -7446,7 +7446,7 @@ struct mlx5_ifc_alloc_transport_domain_out_bits {
 
 struct mlx5_ifc_alloc_transport_domain_in_bits {
 	u8         opcode[0x10];
-	u8         reserved_at_10[0x10];
+	u8         uid[0x10];
 
 	u8         reserved_at_20[0x10];
 	u8         op_mod[0x10];
Signature · 1 line
2.19.1
author
#2 lore raw

PATCH 2/2 IB/mlx5: Use uid as part of alloc/dealloc transport domain

In reply to Leon Romanovsky

From: Yishai Hadas <[email protected]>

Use uid as part of alloc/dealloc transport domain to let firmware manages the resources correctly.

Fixes d2d19121ae2f("IB/mlx5: Set uid as part of TD commands)
Signed-off-by Yishai Hadas <[email protected]>
Reviewed-by Artemy Kovalyov <[email protected]>
Signed-off-by Leon Romanovsky <[email protected]>
---
 drivers/infiniband/hw/mlx5/cmd.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/infiniband/hw/mlx5/cmd.c +2 -0
index 752c60426a1c..356bccc715ee 100644
@@ -240,6 +240,7 @@ int mlx5_cmd_alloc_transport_domain(struct mlx5_core_dev *dev, u32 *tdn,
 
 	MLX5_SET(alloc_transport_domain_in, in, opcode,
 		 MLX5_CMD_OP_ALLOC_TRANSPORT_DOMAIN);
+	MLX5_SET(alloc_transport_domain_in, in, uid, uid);
 
 	err = mlx5_cmd_exec(dev, in, sizeof(in), out, sizeof(out));
 	if (!err)

@@ -257,6 +258,7 @@ void mlx5_cmd_dealloc_transport_domain(struct mlx5_core_dev *dev, u32 tdn,
 
 	MLX5_SET(dealloc_transport_domain_in, in, opcode,
 		 MLX5_CMD_OP_DEALLOC_TRANSPORT_DOMAIN);
+	MLX5_SET(dealloc_transport_domain_in, in, uid, uid);
 	MLX5_SET(dealloc_transport_domain_in, in, transport_domain, tdn);
 	mlx5_cmd_exec(dev, in, sizeof(in), out, sizeof(out));
 }
Signature · 1 line
2.19.1
#3 lore raw
In reply to Leon Romanovsky
Quoted 9 lines · Leon Romanovsky

From: Leon Romanovsky <[email protected]>

Hi,

This small fix to mlx5 devx interface is separated to two, so we can apply first patch to mlx5-next.

Thanks

Quoted 7 lines

Yishai Hadas (2):
IB/mlx5: Introduce uid as part of alloc/dealloc transport domain IB/mlx5: Use uid as part of alloc/dealloc transport domain

 drivers/infiniband/hw/mlx5/cmd.c | 2 ++
 include/linux/mlx5/mlx5_ifc.h    | 4 ++--
 2 files changed, 4 insertions(+), 2 deletions(-)

These look fine too, please update the shared branch

Thanks,
Jason

author
#4 lore raw
Quoted 14 lines · Jason Gunthorpe
Quoted 13 lines · Leon Romanovsky

From: Leon Romanovsky <[email protected]>

Hi,

This small fix to mlx5 devx interface is separated to two, so we can apply first patch to mlx5-next.

Thanks

Yishai Hadas (2):
IB/mlx5: Introduce uid as part of alloc/dealloc transport domain IB/mlx5: Use uid as part of alloc/dealloc transport domain

Quoted 5 lines
Quoted 3 lines
 drivers/infiniband/hw/mlx5/cmd.c | 2 ++
 include/linux/mlx5/mlx5_ifc.h    | 4 ++--
 2 files changed, 4 insertions(+), 2 deletions(-)

These look fine too, please update the shared branch

Done, thanks
71bef2fd583b IB/mlx5: Introduce uid as part of alloc/dealloc transport domain

Quoted 3 lines

Thanks,
Jason

Applied
#5 lore raw
In reply to Leon Romanovsky
Quoted 9 lines · Leon Romanovsky

From: Leon Romanovsky <[email protected]>

Hi,

This small fix to mlx5 devx interface is separated to two, so we can apply first patch to mlx5-next.

Thanks

Quoted 7 lines

Yishai Hadas (2):
IB/mlx5: Introduce uid as part of alloc/dealloc transport domain IB/mlx5: Use uid as part of alloc/dealloc transport domain

 drivers/infiniband/hw/mlx5/cmd.c | 2 ++
 include/linux/mlx5/mlx5_ifc.h    | 4 ++--
 2 files changed, 4 insertions(+), 2 deletions(-)

Applied to for-next

Thanks,
Jason