multipath-tools: reorder vendors in hwtable
PATCH 1/1 multipath-tools: reorder vendors in hwtable
Xio was acquired by Violin, and add FlashSystem 9100 to Storwize in comments.
--- libmultipath/hwtable.c | 50 ++++++++++++++++++++---------------------- 1 file changed, 24 insertions(+), 26 deletions(-)
libmultipath/hwtable.c +24 -26
@@ -604,7 +604,7 @@ static struct hwentry default_hw[] = { .pgpolicy = MULTIBUS, }, { -/* Storwize family / SAN Volume Controller / Flex System V7000 / FlashSystem V840/V9000 */ +/* Storwize family / SAN Volume Controller / Flex System V7000 / FlashSystem V840/V9000/9100 */ .vendor = "IBM", .product = "^2145", .no_path_retry = NO_PATH_RETRY_QUEUE,
@@ -1099,31 +1099,7 @@ static struct hwentry default_hw[] = { .no_path_retry = 30, },/* -* Xiotech -*/ - { - /* Intelligent Storage Elements family */ - .vendor = "(XIOTECH|XIOtech)", - .product = "ISE", - .pgpolicy = MULTIBUS, - .no_path_retry = 12, - }, - { - /* iglu blaze family */ - .vendor = "(XIOTECH|XIOtech)", - .product = "IGLU DISK", - .pgpolicy = MULTIBUS, - .no_path_retry = 30, - }, - { - /* Magnitude family */ - .vendor = "(XIOTECH|XIOtech)", - .product = "Magnitude", - .pgpolicy = MULTIBUS, - .no_path_retry = 30, - }, - /* - * Violin Memory +* Violin Systems */ {/* 3000 / 6000 Series */
@@ -1148,6 +1124,28 @@ static struct hwentry default_hw[] = { .product = "CONCERTO ARRAY", .pgpolicy = MULTIBUS, .no_path_retry = 30, + }, +/* Xiotech */ + { + /* Intelligent Storage Elements family */ + .vendor = "(XIOTECH|XIOtech)", + .product = "ISE", + .pgpolicy = MULTIBUS, + .no_path_retry = 12, + }, + { + /* iglu blaze family */ + .vendor = "(XIOTECH|XIOtech)", + .product = "IGLU DISK", + .pgpolicy = MULTIBUS, + .no_path_retry = 30, + }, + { + /* Magnitude family */ + .vendor = "(XIOTECH|XIOtech)", + .product = "Magnitude", + .pgpolicy = MULTIBUS, + .no_path_retry = 30, }, /* * Promise Technology
Signature · 1 line
2.20.1
Quoted 11 lines · Xose Vazquez Perez
Xio was acquired by Violin, and add FlashSystem 9100 to Storwize in comments.
Cc Christophe Varoqui <[email protected]>Cc DM-DEVEL ML <[email protected]>Signed-off-by Xose Vazquez Perez <[email protected]>--- libmultipath/hwtable.c | 50 ++++++++++++++++++++------------------ ---- 1 file changed, 24 insertions(+), 26 deletions(-)
How important is it to reflect this kind of company-A-owns-company-B information in multipath-tools source code? IMO it makes it harder to track code changes, for no obvious technical reason.
Regards
Martin
Quoted 77 lines
libmultipath/hwtable.c +0
-1@@ -604,7 +604,7 @@ static struct hwentry default_hw[] = { .pgpolicy = MULTIBUS, }, { -/* Storwize family / SAN Volume Controller / Flex System V7000 / FlashSystem V840/V9000 */
libmultipath/hwtable.c +1
-0+/* Storwize family / SAN Volume Controller / Flex System V7000 / FlashSystem V840/V9000/9100 */
libmultipath/hwtable.c +23
-25.vendor = "IBM", .product = "^2145", .no_path_retry = NO_PATH_RETRY_QUEUE,@@ -1099,31 +1099,7 @@ static struct hwentry default_hw[] = { .no_path_retry = 30, },/* -* Xiotech -*/ - { - /* Intelligent Storage Elements family */ - .vendor = "(XIOTECH|XIOtech)", - .product = "ISE", - .pgpolicy = MULTIBUS, - .no_path_retry = 12, - }, - { - /* iglu blaze family */ - .vendor = "(XIOTECH|XIOtech)", - .product = "IGLU DISK", - .pgpolicy = MULTIBUS, - .no_path_retry = 30, - }, - { - /* Magnitude family */ - .vendor = "(XIOTECH|XIOtech)", - .product = "Magnitude", - .pgpolicy = MULTIBUS, - .no_path_retry = 30, - }, - /* - * Violin Memory +* Violin Systems */ {/* 3000 / 6000 Series */ @@ -1148,6 +1124,28 @@ static struct hwentry default_hw[] = { .product = "CONCERTO ARRAY", .pgpolicy = MULTIBUS, .no_path_retry = 30, + }, +/* Xiotech */ + { + /* Intelligent Storage Elements family */ + .vendor = "(XIOTECH|XIOtech)", + .product = "ISE", + .pgpolicy = MULTIBUS, + .no_path_retry = 12, + }, + { + /* iglu blaze family */ + .vendor = "(XIOTECH|XIOtech)", + .product = "IGLU DISK", + .pgpolicy = MULTIBUS, + .no_path_retry = 30, + }, + { + /* Magnitude family */ + .vendor = "(XIOTECH|XIOtech)", + .product = "Magnitude", + .pgpolicy = MULTIBUS, + .no_path_retry = 30, }, /* * Promise Technology
Quoted 13 lines · Martin Wilck
Quoted 11 lines · Xose Vazquez Perez
Xio was acquired by Violin, and add FlashSystem 9100 to Storwize in comments.
Cc Christophe Varoqui <[email protected]>Cc DM-DEVEL ML <[email protected]>Signed-off-by Xose Vazquez Perez <[email protected]>--- libmultipath/hwtable.c | 50 ++++++++++++++++++++------------------ ---- 1 file changed, 24 insertions(+), 26 deletions(-)
Quoted 3 lines
How important is it to reflect this kind of company-A-owns-company-B information in multipath-tools source code? IMO it makes it harder to track code changes, for no obvious technical reason.
Keep the file consistent with the real world.
There is no more Xiotech company, now their products are sold by Violin. The same happened in the past with:
XIV : RamSan -> IBMLSI_RDAC : SolidFir -> NetApp
DEC -> Compaq : 3PAR : LEFTHAND : Nimble : SGI -> HPE
DGC : XtremIO -> EMC : Compellent -> DELL
...
......
Quoted 80 lines
Quoted 77 lines
libmultipath/hwtable.c +0
-1@@ -604,7 +604,7 @@ static struct hwentry default_hw[] = { .pgpolicy = MULTIBUS, }, { -/* Storwize family / SAN Volume Controller / Flex System V7000 / FlashSystem V840/V9000 */
libmultipath/hwtable.c +1
-0+/* Storwize family / SAN Volume Controller / Flex System V7000 / FlashSystem V840/V9000/9100 */
libmultipath/hwtable.c +23
-25.vendor = "IBM", .product = "^2145", .no_path_retry = NO_PATH_RETRY_QUEUE,@@ -1099,31 +1099,7 @@ static struct hwentry default_hw[] = { .no_path_retry = 30, },/* -* Xiotech -*/ - { - /* Intelligent Storage Elements family */ - .vendor = "(XIOTECH|XIOtech)", - .product = "ISE", - .pgpolicy = MULTIBUS, - .no_path_retry = 12, - }, - { - /* iglu blaze family */ - .vendor = "(XIOTECH|XIOtech)", - .product = "IGLU DISK", - .pgpolicy = MULTIBUS, - .no_path_retry = 30, - }, - { - /* Magnitude family */ - .vendor = "(XIOTECH|XIOtech)", - .product = "Magnitude", - .pgpolicy = MULTIBUS, - .no_path_retry = 30, - }, - /* - * Violin Memory +* Violin Systems */ {/* 3000 / 6000 Series */ @@ -1148,6 +1124,28 @@ static struct hwentry default_hw[] = { .product = "CONCERTO ARRAY", .pgpolicy = MULTIBUS, .no_path_retry = 30, + }, +/* Xiotech */ + { + /* Intelligent Storage Elements family */ + .vendor = "(XIOTECH|XIOtech)", + .product = "ISE", + .pgpolicy = MULTIBUS, + .no_path_retry = 12, + }, + { + /* iglu blaze family */ + .vendor = "(XIOTECH|XIOtech)", + .product = "IGLU DISK", + .pgpolicy = MULTIBUS, + .no_path_retry = 30, + }, + { + /* Magnitude family */ + .vendor = "(XIOTECH|XIOtech)", + .product = "Magnitude", + .pgpolicy = MULTIBUS, + .no_path_retry = 30, }, /* * Promise Technology
Quoted 21 lines · Xose Vazquez Perez
Quoted 14 lines · Martin Wilck
Quoted 4 lines · Xose Vazquez Perez
Xio was acquired by Violin, and add FlashSystem 9100 to Storwize in
comments.Quoted 9 lines
Cc Christophe Varoqui <[email protected]>Cc DM-DEVEL ML <[email protected]>Signed-off-by Xose Vazquez Perez <[email protected]>--- libmultipath/hwtable.c | 50 ++++++++++++++++++++-------------- ---- ---- 1 file changed, 24 insertions(+), 26 deletions(-)Quoted 5 lines
How important is it to reflect this kind of company-A-owns-company- B
information in multipath-tools source code? IMO it makes it harder to
track code changes, for no obvious technical reason.
Quoted 8 lines
Keep the file consistent with the real world.
There is no more Xiotech company, now their products are sold by Violin.
The same happened in the past with:
XIV : RamSan -> IBMLSI_RDAC: SolidFir -> NetApp
DEC -> Compaq : 3PAR : LEFTHAND : Nimble : SGI -> HPE DGC : XtremIO -> EMC : Compellent -> DELL
Fine with me, in general. But I dislike the "reordering vendors" type of patch, leading to 22 insertions and 22 deletions without changing any actual code. Sorting the hw entries by comments also makes little sense to me. IMO we should switch using the actual .vendor/.product strings for sorting, and perhaps move the "maintainers" information into a separate file.
The fact that we did it in the past doesn't mean it's the right thing to do. Anyone who needs to look up properties for a specific device in hwtable.c will likely use the "search" functionality of her text editor of choice, rather than rely on the alphabetic sorting of the entries; and again it's usually the vendor/product string that matters for this lookup rather than the comment on top of it. Therefore the benefit of keeping the order is low. But following the history of changes (in order to figure out when and with what rationale a certain setting was added) is made significantly harder by patches of this kind.
Martin