drm/msm/gpu: fix bo size for msm_rbmemptrs
Subsystems (3)
PATCH 1/1 drm/msm/gpu: fix bo size for msm_rbmemptrs
memptrs_bo is used to store msm_rbmemptrs. Size it correctly.
--- drivers/gpu/drm/msm/msm_gpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/msm/msm_gpu.c +1 -1
@@ -917,7 +917,7 @@ int msm_gpu_init(struct drm_device *drm, struct platform_device *pdev, goto fail; } - memptrs =msm_gem_kernel_new (drm,sizeof (*gpu->memptrs_bo), + memptrs =msm_gem_kernel_new (drm,sizeof (struct msm_rbmemptrs ) * nr_rings,MSM_BO_UNCACHED , gpu->aspace, &gpu->memptrs_bo, &memptrs_iova);
Signature · 6 lines
2.18.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 3 lines · Chia-I Wu
memptrs_bois used to storemsm_rbmemptrs. Size it correctly.Signed-off-by Chia-I Wu <[email protected]>
Thanks for your patch. I'm really glad somebody is looking seriously at this code. We have this in msm-next:
I think that might fix your concern?
Jordan
Quoted 24 lines
--- drivers/gpu/drm/msm/msm_gpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/msm/msm_gpu.c +1
-1@@ -917,7 +917,7 @@ int msm_gpu_init(struct drm_device *drm, struct platform_device *pdev, goto fail; } - memptrs =msm_gem_kernel_new (drm,sizeof (*gpu->memptrs_bo), + memptrs =msm_gem_kernel_new (drm,sizeof (struct msm_rbmemptrs ) * nr_rings,MSM_BO_UNCACHED , gpu->aspace, &gpu->memptrs_bo, &memptrs_iova);Signature · 6 lines
2.18.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Signature · 6 lines
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project _______________________________________________ Freedreno mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/freedreno
Ah, thanks. I was on drm-next branch. I will switch to msm-next.
Quoted 39 lines · Jordan Crouse
Quoted 3 lines · Chia-I Wu
memptrs_bois used to storemsm_rbmemptrs. Size it correctly.Signed-off-by Chia-I Wu <[email protected]>Thanks for your patch. I'm really glad somebody is looking seriously at this
code. We have this in msm-next:I think that might fix your concern?
Jordan
Review
Quoted 5 lines
--- drivers/gpu/drm/msm/msm_gpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)(quoted diff) +0
-0
b/drivers/gpu/drm/msm/msm_gpu.cdrivers/gpu/drm/msm/msm_gpu.c int msm_gpu_init(struct drm_device *drm, struct
Quoted 4 lines
index
11aac8337066..d23049eb29c4100644drivers/gpu/drm/msm/msm_gpu.c +0
-0@@ -917,7 +917,7 @@ int msm_gpu_init(struct drm_device *drm, struct
platform_device*pdev,drivers/gpu/drm/msm/msm_gpu.c int msm_gpu_init(struct drm_device *drm, struct platform_device *pdev,
Quoted 5 lines
drivers/gpu/drm/msm/msm_gpu.c +1
-1goto fail; } - memptrs = msm_gem_kernel_new(drm, sizeof(*gpu->memptrs_bo), + memptrs = msm_gem_kernel_new(drm, sizeof(struct msm_rbmemptrs) *
nr_rings,Quoted 6 lines
drivers/gpu/drm/msm/msm_gpu.c +0
-1MSM_BO_UNCACHED , gpu->aspace, &gpu->memptrs_bo, &memptrs_iova); --2.18.1
Quoted 9 lines
Quoted 4 lines
_______________________________________________
dri-devel mailing list [email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel--
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
_______________________________________________
Freedreno mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/freedreno