ASoC: rt5677: use more of the volume range from DACs
Subsystems (3)
PATCH 1/1 ASoC: rt5677: use more of the volume range from DACs
From: Dylan Reid <[email protected]>
The DACs volume can go over 0, both according to the data sheet and real world testing. The control can go up to +30dB.
This was tested by playing audio at full volume on a samus chromebook.
--- sound/soc/codecs/rt5677.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
sound/soc/codecs/rt5677.c +4 -4
@@ -832,13 +832,13 @@ static const struct snd_kcontrol_new rt5677_snd_controls[] = {/* DAC Digital Volume */ SOC_DOUBLE_TLV ("DAC1 Playback Volume" ,RT5677_DAC1_DIG_VOL , -RT5677_L_VOL_SFT ,RT5677_R_VOL_SFT ,87 ,0 , dac_vol_tlv), +RT5677_L_VOL_SFT ,RT5677_R_VOL_SFT ,127 ,0 , dac_vol_tlv),SOC_DOUBLE_TLV ("DAC2 Playback Volume" ,RT5677_DAC2_DIG_VOL , -RT5677_L_VOL_SFT ,RT5677_R_VOL_SFT ,87 ,0 , dac_vol_tlv), +RT5677_L_VOL_SFT ,RT5677_R_VOL_SFT ,127 ,0 , dac_vol_tlv),SOC_DOUBLE_TLV ("DAC3 Playback Volume" ,RT5677_DAC3_DIG_VOL , -RT5677_L_VOL_SFT ,RT5677_R_VOL_SFT ,87 ,0 , dac_vol_tlv), +RT5677_L_VOL_SFT ,RT5677_R_VOL_SFT ,127 ,0 , dac_vol_tlv),SOC_DOUBLE_TLV ("DAC4 Playback Volume" ,RT5677_DAC4_DIG_VOL , -RT5677_L_VOL_SFT ,RT5677_R_VOL_SFT ,87 ,0 , dac_vol_tlv), +RT5677_L_VOL_SFT ,RT5677_R_VOL_SFT ,127 ,0 , dac_vol_tlv),/* IN1/IN2 Control */ SOC_SINGLE_TLV("IN1 Boost", RT5677_IN1, RT5677_BST_SFT1, 8, 0, bst_tlv),
Signature · 1 line
2.20.1.415.g653613c723-goog
Quoted 10 lines · Ross Zwisler
From: Dylan Reid <[email protected]>
The DACs volume can go over 0, both according to the data sheet and real world testing. The control can go up to +30dB.
This was tested by playing audio at full volume on a samus chromebook.
Signed-off-by Dylan Reid <[email protected]>Reviewed-by Hsinyu Chao <[email protected]>Signed-off-by Ross Zwisler <[email protected]>
Ping on this patch.
Mark Brown
maintainerQuoted 1 line · Ross Zwisler
Ping on this patch.
Please don't send content free pings and please allow a reasonable time for review. People get busy, go on holiday, attend conferences and so on so unless there is some reason for urgency (like critical bug fixes) please allow at least a couple of weeks for review. If there have been review comments then people may be waiting for those to be addressed.
Sending content free pings adds to the mail volume (if they are seen at all) which is often the problem and since they can't be reviewed directly if something has gone wrong you'll have to resend the patches anyway, so sending again is generally a better approach though there are some other maintainers who like them - if in doubt look at how patches for the subsystem are normally handled.