Skip to contentSkip to conversation

clk: imx7d: fix refcount leak in imx7d_clocks_init()

PATCH Applied Yangtao Li 2 participants 2 messages Dec 26, 2018 – Dec 28, 2018

Subsystems (3)
Arm i.MX and Layerscape Common clk NXP i.MX clock drivers
lore
Share & tools
lore

Yangtao Li

author
#0 lore raw

PATCH 1/1 clk: imx7d: fix refcount leak in imx7d_clocks_init()

The of_find_compatible_node() returns a node pointer with refcount incremented, but there is the lack of use of the of_node_put() when done. Add the missing of_node_put() to release the refcount.

Signed-off-by Yangtao Li <[email protected]>
---
 drivers/clk/imx/clk-imx7d.c | 1 +
 1 file changed, 1 insertion(+)
drivers/clk/imx/clk-imx7d.c +1 -0
index adb08f64c691..12e2e85bbe1c 100644
@@ -404,6 +404,7 @@ static void __init imx7d_clocks_init(struct device_node *ccm_node)
 	np = of_find_compatible_node(NULL, NULL, "fsl,imx7d-anatop");
 	base = of_iomap(np, 0);
 	WARN_ON(!base);
+	of_node_put(np);
 
 	clks[IMX7D_PLL_ARM_MAIN_SRC]  = imx_clk_mux("pll_arm_main_src", base + 0x60, 14, 2, pll_bypass_src_sel, ARRAY_SIZE(pll_bypass_src_sel));
 	clks[IMX7D_PLL_DRAM_MAIN_SRC] = imx_clk_mux("pll_dram_main_src", base + 0x70, 14, 2, pll_bypass_src_sel, ARRAY_SIZE(pll_bypass_src_sel));
Signature · 1 line
2.17.0
maintainer Applied
#1 lore raw

Quoting Yangtao Li (2018-12-26 05:57:16)

Quoted 6 lines

The of_find_compatible_node() returns a node pointer with refcount incremented, but there is the lack of use of the of_node_put() when done. Add the missing of_node_put() to release the refcount.

Signed-off-by Yangtao Li <[email protected]>

---

Applied to clk-next