Skip to contentSkip to conversation

x86/cpu/intel: Lower "ENERGY_PERF_BIAS: Set to normal" message log priority

PATCH New Hans de Goede 2 participants 2 messages Dec 30, 2018 – Apr 19, 2019 x86

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86/cpu/intel: Lower "ENERGY_PERF_BIAS: Set to normal" message log priority

The "ENERGY_PERF_BIAS: Set to 'normal', was 'performance'" message triggers on pretty much every Intel machine. The purpose of log messages with a warning level is to notify the user of something which potentially is a problem, or at least somewhat unexpected.

This message clearly does not match those criteria, so lower its log priority from warning to info.

---
 arch/x86/kernel/cpu/intel.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/x86/kernel/cpu/intel.c +2 -2
index fc3c07fe7df5..3142fd7a9b32 100644
@@ -611,8 +611,8 @@ static void init_intel_energy_perf(struct cpuinfo_x86 *c)
 	if ((epb & 0xF) != ENERGY_PERF_BIAS_PERFORMANCE)
 		return;
 
-	pr_warn_once("ENERGY_PERF_BIAS: Set to 'normal', was 'performance'\n");
-	pr_warn_once("ENERGY_PERF_BIAS: View and update with x86_energy_perf_policy(8)\n");
+	pr_info_once("ENERGY_PERF_BIAS: Set to 'normal', was 'performance'\n");
+	pr_info_once("ENERGY_PERF_BIAS: View and update with x86_energy_perf_policy(8)\n");
 	epb = (epb & ~0xF) | ENERGY_PERF_BIAS_NORMAL;
 	wrmsrl(MSR_IA32_ENERGY_PERF_BIAS, epb);
 }
Signature · 1 line
2.20.1
#1 lore raw

[tip:x86/urgent] x86/cpu/intel: Lower the "ENERGY_PERF_BIAS: Set to normal" message's log priority

x86/cpu/intel: Lower the "ENERGY_PERF_BIAS: Set to normal" message's log priority
Commit-ID:  2ee27796f298b710992a677a7e4d35c8c588b17e
Gitweb:     https://git.kernel.org/tip/2ee27796f298b710992a677a7e4d35c8c588b17e
Author:     Hans de Goede <[email protected]>
AuthorDate: Sun, 30 Dec 2018 18:27:15 +0100
Committer:  Ingo Molnar <[email protected]>
CommitDate: Fri, 19 Apr 2019 19:23:13 +0200

x86/cpu/intel: Lower the "ENERGY_PERF_BIAS: Set to normal" message's log priority

The "ENERGY_PERF_BIAS: Set to 'normal', was 'performance'" message triggers on pretty much every Intel machine. The purpose of log messages with a warning level is to notify the user of something which potentially is a problem, or at least somewhat unexpected.

This message clearly does not match those criteria, so lower its log priority from warning to info.

---
 arch/x86/kernel/cpu/intel.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/x86/kernel/cpu/intel.c +2 -2
index fc3c07fe7df5..3142fd7a9b32 100644
@@ -611,8 +611,8 @@ static void init_intel_energy_perf(struct cpuinfo_x86 *c)
 	if ((epb & 0xF) != ENERGY_PERF_BIAS_PERFORMANCE)
 		return;
 
-	pr_warn_once("ENERGY_PERF_BIAS: Set to 'normal', was 'performance'\n");
-	pr_warn_once("ENERGY_PERF_BIAS: View and update with x86_energy_perf_policy(8)\n");
+	pr_info_once("ENERGY_PERF_BIAS: Set to 'normal', was 'performance'\n");
+	pr_info_once("ENERGY_PERF_BIAS: View and update with x86_energy_perf_policy(8)\n");
 	epb = (epb & ~0xF) | ENERGY_PERF_BIAS_NORMAL;
 	wrmsrl(MSR_IA32_ENERGY_PERF_BIAS, epb);
 }