ipv6: Consider sk_bound_dev_if when binding a socket to an address
Subsystems (2)
PATCH 1/1 ipv6: Consider sk_bound_dev_if when binding a socket to an address
From: David Ahern <[email protected]>
IPv6 does not consider if the socket is bound to a device when binding to an address. The result is that a socket can be bound to eth0 and then bound to the address of eth1. If the device is a VRF, the result is that a socket can only be bound to an address in the default VRF.
Resolve by considering the device if sk_bound_dev_if is set.
This problem exists from the beginning of git history.
--- net/ipv6/af_inet6.c | 3 +++ 1 file changed, 3 insertions(+)
net/ipv6/af_inet6.c +3 -0
@@ -350,6 +350,9 @@ static int __inet6_bind(struct sock *sk, struct sockaddr *uaddr, int addr_len, err = -EINVAL ; goto out_unlock; } + } + +if (sk->sk_bound_dev_if) { dev =dev_get_by_index_rcu (net, sk->sk_bound_dev_if);if (!dev) { err = -ENODEV ;
Signature · 1 line
2.11.0
David Miller
maintainerFrom: David Ahern <[email protected]>
Date: Wed, 2 Jan 2019 18:57:09 -0800
Quoted 7 lines
From: David Ahern <[email protected]>
IPv6 does not consider if the socket is bound to a device when binding to an address. The result is that a socket can be bound to eth0 and then bound to the address of eth1. If the device is a VRF, the result is that a socket can only be bound to an address in the default VRF.
Quoted 5 lines
Resolve by considering the device if
sk_bound_dev_ifis set.This problem exists from the beginning of git history.
Signed-off-by David Ahern <[email protected]>
Applied and queued up for -stable.
Hi all,
thanks a lot! I can confirm that this fixes my test script.
Kind regards,
Ralf
Quoted 31 lines · David Ahern
From: David Ahern <[email protected]>
IPv6 does not consider if the socket is bound to a device when binding to an address. The result is that a socket can be bound to eth0 and then bound to the address of eth1. If the device is a VRF, the result is that a socket can only be bound to an address in the default VRF.
Resolve by considering the device if
sk_bound_dev_ifis set.This problem exists from the beginning of git history.
Signed-off-by David Ahern <[email protected]>--- net/ipv6/af_inet6.c | 3 +++ 1 file changed, 3 insertions(+)net/ipv6/af_inet6.c +3
-0@@ -350,6 +350,9 @@ static int __inet6_bind(struct sock *sk, struct sockaddr *uaddr, int addr_len, err = -EINVAL ; goto out_unlock; } + } + +if (sk->sk_bound_dev_if) { dev =dev_get_by_index_rcu (net, sk->sk_bound_dev_if);if (!dev) { err = -ENODEV ;