configs: Enable CONFIG_BLK in a few TI boards
PATCH 1/1 configs: Enable CONFIG_BLK in a few TI boards
With DM conversion completed, enable CONFIG_BLK for a few pending TI boards.
--- configs/am335x_boneblack_vboot_defconfig | 1 - configs/am335x_evm_defconfig | 1 - configs/am335x_hs_evm_defconfig | 1 - configs/am335x_hs_evm_uart_defconfig | 1 - configs/am43xx_evm_defconfig | 1 - configs/am43xx_evm_qspiboot_defconfig | 1 - configs/am43xx_evm_rtconly_defconfig | 1 - configs/am43xx_evm_usbhost_boot_defconfig | 1 - configs/am43xx_hs_evm_defconfig | 1 - configs/am57xx_evm_defconfig | 1 - configs/am57xx_hs_evm_defconfig | 1 - configs/k2g_evm_defconfig | 1 - configs/k2g_hs_evm_defconfig | 1 - 13 files changed, 13 deletions(-)
configs/am335x_boneblack_vboot_defconfig +0 -1
@@ -29,7 +29,6 @@ CONFIG_OF_CONTROL=y CONFIG_DEFAULT_DEVICE_TREE="am335x-boneblack" CONFIG_ENV_IS_IN_MMC=y CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG=y -# CONFIG_BLK is not set CONFIG_BOOTCOUNT_LIMIT=y CONFIG_DFU_MMC=y CONFIG_DFU_RAM=y
configs/am335x_evm_defconfig +0 -1
@@ -26,7 +26,6 @@ CONFIG_OF_CONTROL=y CONFIG_DEFAULT_DEVICE_TREE="am335x-evm" CONFIG_OF_LIST="am335x-evm am335x-bone am335x-boneblack am335x-evmsk am335x-bonegreen am335x-icev2" CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG=y -# CONFIG_BLK is not set CONFIG_BOOTCOUNT_LIMIT=y CONFIG_DFU_MMC=y CONFIG_DFU_NAND=y
configs/am335x_hs_evm_defconfig +0 -1
@@ -32,7 +32,6 @@ CONFIG_OF_CONTROL=y CONFIG_DEFAULT_DEVICE_TREE="am335x-evm" CONFIG_OF_LIST="am335x-evm am335x-bone am335x-boneblack am335x-evmsk am335x-bonegreen am335x-icev2" CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG=y -# CONFIG_BLK is not set CONFIG_BOOTCOUNT_LIMIT=y CONFIG_DFU_MMC=y CONFIG_DFU_NAND=y
configs/am335x_hs_evm_uart_defconfig +0 -1
@@ -34,7 +34,6 @@ CONFIG_OF_CONTROL=y CONFIG_DEFAULT_DEVICE_TREE="am335x-evm" CONFIG_OF_LIST="am335x-evm am335x-bone am335x-boneblack am335x-evmsk am335x-bonegreen am335x-icev2" CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG=y -# CONFIG_BLK is not set CONFIG_BOOTCOUNT_LIMIT=y CONFIG_DFU_MMC=y CONFIG_DFU_NAND=y
configs/am43xx_evm_defconfig +0 -1
@@ -36,7 +36,6 @@ CONFIG_REGMAP=y CONFIG_SPL_REGMAP=y CONFIG_SYSCON=y CONFIG_SPL_SYSCON=y -# CONFIG_BLK is not set CONFIG_DFU_MMC=y CONFIG_DFU_RAM=y CONFIG_DFU_SF=y
configs/am43xx_evm_qspiboot_defconfig +0 -1
@@ -31,7 +31,6 @@ CONFIG_MULTI_DTB_FIT=y CONFIG_ENV_IS_IN_SPI_FLASH=y CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG=y CONFIG_DM=y -# CONFIG_BLK is not set CONFIG_DFU_MMC=y CONFIG_DFU_RAM=y CONFIG_DFU_SF=y
configs/am43xx_evm_rtconly_defconfig +0 -1
@@ -28,7 +28,6 @@ CONFIG_DEFAULT_DEVICE_TREE="am437x-gp-evm" CONFIG_OF_LIST="am437x-gp-evm am437x-sk-evm am43x-epos-evm am437x-idk-evm" CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG=y CONFIG_DM=y -# CONFIG_BLK is not set CONFIG_DFU_MMC=y CONFIG_DFU_RAM=y CONFIG_DFU_SF=y
configs/am43xx_evm_usbhost_boot_defconfig +0 -1
@@ -40,7 +40,6 @@ CONFIG_OF_LIST="am437x-gp-evm am437x-sk-evm am43x-epos-evm am437x-idk-evm" CONFIG_ENV_IS_IN_FAT=y CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG=y CONFIG_DM=y -# CONFIG_BLK is not set CONFIG_DFU_MMC=y CONFIG_DFU_RAM=y CONFIG_DFU_SF=y
configs/am43xx_hs_evm_defconfig +0 -1
@@ -38,7 +38,6 @@ CONFIG_DEFAULT_DEVICE_TREE="am437x-gp-evm" CONFIG_OF_LIST="am437x-gp-evm am437x-sk-evm am43x-epos-evm am437x-idk-evm" CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG=y CONFIG_DM=y -# CONFIG_BLK is not set CONFIG_DFU_MMC=y CONFIG_DFU_RAM=y CONFIG_DFU_SF=y
configs/am57xx_evm_defconfig +0 -1
@@ -39,7 +39,6 @@ CONFIG_DM=y CONFIG_SPL_DM=y CONFIG_SPL_DM_SEQ_ALIAS=y CONFIG_SCSI_AHCI=y -# CONFIG_BLK is not set CONFIG_DFU_MMC=y CONFIG_DFU_RAM=y CONFIG_USB_FUNCTION_FASTBOOT=y
configs/am57xx_hs_evm_defconfig +0 -1
@@ -42,7 +42,6 @@ CONFIG_DM=y CONFIG_SPL_DM=y CONFIG_SPL_DM_SEQ_ALIAS=y CONFIG_SCSI_AHCI=y -# CONFIG_BLK is not set CONFIG_DFU_MMC=y CONFIG_DFU_RAM=y CONFIG_USB_FUNCTION_FASTBOOT=y
configs/k2g_evm_defconfig +0 -1
@@ -34,7 +34,6 @@ CONFIG_DTB_RESELECT=y CONFIG_MULTI_DTB_FIT=y CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG=y CONFIG_DM=y -# CONFIG_BLK is not set CONFIG_DFU_MMC=y CONFIG_SYS_I2C_DAVINCI=y CONFIG_MISC=y
configs/k2g_hs_evm_defconfig +0 -1
@@ -27,7 +27,6 @@ CONFIG_DTB_RESELECT=y CONFIG_MULTI_DTB_FIT=y CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG=y CONFIG_DM=y -# CONFIG_BLK is not set CONFIG_DFU_MMC=y CONFIG_SYS_I2C_DAVINCI=y CONFIG_MISC=y
Signature · 1 line
2.19.2
PATCH 1/1 configs: Enable CONFIG_BLK in a few TI boards
+ Tom
Quoted 4 lines · Faiz Abbas
With DM conversion completed, enable
CONFIG_BLKfor a few pending TI boards.Signed-off-by Faiz Abbas <[email protected]>
Thanks and regards,
Lokesh
Quoted 173 lines
--- configs/am335x_boneblack_vboot_defconfig | 1 - configs/am335x_evm_defconfig | 1 - configs/am335x_hs_evm_defconfig | 1 - configs/am335x_hs_evm_uart_defconfig | 1 - configs/am43xx_evm_defconfig | 1 - configs/am43xx_evm_qspiboot_defconfig | 1 - configs/am43xx_evm_rtconly_defconfig | 1 - configs/am43xx_evm_usbhost_boot_defconfig | 1 - configs/am43xx_hs_evm_defconfig | 1 - configs/am57xx_evm_defconfig | 1 - configs/am57xx_hs_evm_defconfig | 1 - configs/k2g_evm_defconfig | 1 - configs/k2g_hs_evm_defconfig | 1 - 13 files changed, 13 deletions(-)configs/am335x_boneblack_vboot_defconfig +0
-1@@ -29,7 +29,6 @@ CONFIG_OF_CONTROL=y CONFIG_DEFAULT_DEVICE_TREE="am335x-boneblack" CONFIG_ENV_IS_IN_MMC=y CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG=y -# CONFIG_BLK is not set CONFIG_BOOTCOUNT_LIMIT=y CONFIG_DFU_MMC=y CONFIG_DFU_RAM=yconfigs/am335x_evm_defconfig +0
-1@@ -26,7 +26,6 @@ CONFIG_OF_CONTROL=y CONFIG_DEFAULT_DEVICE_TREE="am335x-evm" CONFIG_OF_LIST="am335x-evm am335x-bone am335x-boneblack am335x-evmsk am335x-bonegreen am335x-icev2" CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG=y -# CONFIG_BLK is not set CONFIG_BOOTCOUNT_LIMIT=y CONFIG_DFU_MMC=y CONFIG_DFU_NAND=yconfigs/am335x_hs_evm_defconfig +0
-1@@ -32,7 +32,6 @@ CONFIG_OF_CONTROL=y CONFIG_DEFAULT_DEVICE_TREE="am335x-evm" CONFIG_OF_LIST="am335x-evm am335x-bone am335x-boneblack am335x-evmsk am335x-bonegreen am335x-icev2" CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG=y -# CONFIG_BLK is not set CONFIG_BOOTCOUNT_LIMIT=y CONFIG_DFU_MMC=y CONFIG_DFU_NAND=yconfigs/am335x_hs_evm_uart_defconfig +0
-1@@ -34,7 +34,6 @@ CONFIG_OF_CONTROL=y CONFIG_DEFAULT_DEVICE_TREE="am335x-evm" CONFIG_OF_LIST="am335x-evm am335x-bone am335x-boneblack am335x-evmsk am335x-bonegreen am335x-icev2" CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG=y -# CONFIG_BLK is not set CONFIG_BOOTCOUNT_LIMIT=y CONFIG_DFU_MMC=y CONFIG_DFU_NAND=yconfigs/am43xx_evm_defconfig +0
-1@@ -36,7 +36,6 @@ CONFIG_REGMAP=y CONFIG_SPL_REGMAP=y CONFIG_SYSCON=y CONFIG_SPL_SYSCON=y -# CONFIG_BLK is not set CONFIG_DFU_MMC=y CONFIG_DFU_RAM=y CONFIG_DFU_SF=yconfigs/am43xx_evm_qspiboot_defconfig +0
-1@@ -31,7 +31,6 @@ CONFIG_MULTI_DTB_FIT=y CONFIG_ENV_IS_IN_SPI_FLASH=y CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG=y CONFIG_DM=y -# CONFIG_BLK is not set CONFIG_DFU_MMC=y CONFIG_DFU_RAM=y CONFIG_DFU_SF=yconfigs/am43xx_evm_rtconly_defconfig +0
-1@@ -28,7 +28,6 @@ CONFIG_DEFAULT_DEVICE_TREE="am437x-gp-evm" CONFIG_OF_LIST="am437x-gp-evm am437x-sk-evm am43x-epos-evm am437x-idk-evm" CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG=y CONFIG_DM=y -# CONFIG_BLK is not set CONFIG_DFU_MMC=y CONFIG_DFU_RAM=y CONFIG_DFU_SF=yconfigs/am43xx_evm_usbhost_boot_defconfig +0
-1@@ -40,7 +40,6 @@ CONFIG_OF_LIST="am437x-gp-evm am437x-sk-evm am43x-epos-evm am437x-idk-evm" CONFIG_ENV_IS_IN_FAT=y CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG=y CONFIG_DM=y -# CONFIG_BLK is not set CONFIG_DFU_MMC=y CONFIG_DFU_RAM=y CONFIG_DFU_SF=yconfigs/am43xx_hs_evm_defconfig +0
-1@@ -38,7 +38,6 @@ CONFIG_DEFAULT_DEVICE_TREE="am437x-gp-evm" CONFIG_OF_LIST="am437x-gp-evm am437x-sk-evm am43x-epos-evm am437x-idk-evm" CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG=y CONFIG_DM=y -# CONFIG_BLK is not set CONFIG_DFU_MMC=y CONFIG_DFU_RAM=y CONFIG_DFU_SF=yconfigs/am57xx_evm_defconfig +0
-1@@ -39,7 +39,6 @@ CONFIG_DM=y CONFIG_SPL_DM=y CONFIG_SPL_DM_SEQ_ALIAS=y CONFIG_SCSI_AHCI=y -# CONFIG_BLK is not set CONFIG_DFU_MMC=y CONFIG_DFU_RAM=y CONFIG_USB_FUNCTION_FASTBOOT=yconfigs/am57xx_hs_evm_defconfig +0
-1@@ -42,7 +42,6 @@ CONFIG_DM=y CONFIG_SPL_DM=y CONFIG_SPL_DM_SEQ_ALIAS=y CONFIG_SCSI_AHCI=y -# CONFIG_BLK is not set CONFIG_DFU_MMC=y CONFIG_DFU_RAM=y CONFIG_USB_FUNCTION_FASTBOOT=yconfigs/k2g_evm_defconfig +0
-1@@ -34,7 +34,6 @@ CONFIG_DTB_RESELECT=y CONFIG_MULTI_DTB_FIT=y CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG=y CONFIG_DM=y -# CONFIG_BLK is not set CONFIG_DFU_MMC=y CONFIG_SYS_I2C_DAVINCI=y CONFIG_MISC=yconfigs/k2g_hs_evm_defconfig +0
-1@@ -27,7 +27,6 @@ CONFIG_DTB_RESELECT=y CONFIG_MULTI_DTB_FIT=y CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG=y CONFIG_DM=y -# CONFIG_BLK is not set CONFIG_DFU_MMC=y CONFIG_SYS_I2C_DAVINCI=y CONFIG_MISC=y
Quoted 5 lines · Faiz Abbas
With DM conversion completed, enable
CONFIG_BLKfor a few pending TI boards.Signed-off-by Faiz Abbas <[email protected]>Reviewed-by Lokesh Vutla <[email protected]>
Quoted 15 lines
--- configs/am335x_boneblack_vboot_defconfig | 1 - configs/am335x_evm_defconfig | 1 - configs/am335x_hs_evm_defconfig | 1 - configs/am335x_hs_evm_uart_defconfig | 1 - configs/am43xx_evm_defconfig | 1 - configs/am43xx_evm_qspiboot_defconfig | 1 - configs/am43xx_evm_rtconly_defconfig | 1 - configs/am43xx_evm_usbhost_boot_defconfig | 1 - configs/am43xx_hs_evm_defconfig | 1 - configs/am57xx_evm_defconfig | 1 - configs/am57xx_hs_evm_defconfig | 1 - configs/k2g_evm_defconfig | 1 - configs/k2g_hs_evm_defconfig | 1 - 13 files changed, 13 deletions(-)
So, a problem with this patch is that we can't only enable CONFIG_BLK in all cases, we also need to make sure that if we have MMC we have DM_MMC and if we have USB we have DM_USB. This latter case is what tripped me up as am43xx_evm_usbhost_boot_defconfig will have a warning with this patch applied as SPL_USB_SUPPORT really requires CONFIG_USB_STORAGE support and that in turn depends on either (BLK==n && DM_USB==n) or (BLK==y && DM_USB==y).
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190115/b262fd8a/attachment.sig>
Quoted 22 lines · Tom Rini
Quoted 5 lines · Faiz Abbas
With DM conversion completed, enable
CONFIG_BLKfor a few pending TI boards.Signed-off-by Faiz Abbas <[email protected]>Reviewed-by Lokesh Vutla <[email protected]>Quoted 15 lines
--- configs/am335x_boneblack_vboot_defconfig | 1 - configs/am335x_evm_defconfig | 1 - configs/am335x_hs_evm_defconfig | 1 - configs/am335x_hs_evm_uart_defconfig | 1 - configs/am43xx_evm_defconfig | 1 - configs/am43xx_evm_qspiboot_defconfig | 1 - configs/am43xx_evm_rtconly_defconfig | 1 - configs/am43xx_evm_usbhost_boot_defconfig | 1 - configs/am43xx_hs_evm_defconfig | 1 - configs/am57xx_evm_defconfig | 1 - configs/am57xx_hs_evm_defconfig | 1 - configs/k2g_evm_defconfig | 1 - configs/k2g_hs_evm_defconfig | 1 - 13 files changed, 13 deletions(-)
Quoted 7 lines
So, a problem with this patch is that we can't only enable
CONFIG_BLKin all cases, we also need to make sure that if we have MMC we haveDM_MMCand if we have USB we haveDM_USB. This latter case is what tripped me up asam43xx_evm_usbhost_boot_defconfigwill have a warning with this patch applied asSPL_USB_SUPPORTreally requiresCONFIG_USB_STORAGEsupport and that in turn depends on either (BLK==n && DM_USB==n) or (BLK==y && DM_USB==y).
Maybe we should break this down.
1) k2g and am57: they already have the right options enabled.
2) am335x: the options are also present, although some are disabled in SPL
3) am43x: some configs need to be converted to DM_USB and DM_MMC first.
JJ
Quoted 6 lines
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
https://lists.denx.de/listinfo/u-boot
Quoted 32 lines · Jean-Jacques Hiblot
Quoted 22 lines · Tom Rini
Quoted 5 lines · Faiz Abbas
With DM conversion completed, enable
CONFIG_BLKfor a few pending TI boards.Signed-off-by Faiz Abbas <[email protected]>Reviewed-by Lokesh Vutla <[email protected]>Quoted 15 lines
--- configs/am335x_boneblack_vboot_defconfig | 1 - configs/am335x_evm_defconfig | 1 - configs/am335x_hs_evm_defconfig | 1 - configs/am335x_hs_evm_uart_defconfig | 1 - configs/am43xx_evm_defconfig | 1 - configs/am43xx_evm_qspiboot_defconfig | 1 - configs/am43xx_evm_rtconly_defconfig | 1 - configs/am43xx_evm_usbhost_boot_defconfig | 1 - configs/am43xx_hs_evm_defconfig | 1 - configs/am57xx_evm_defconfig | 1 - configs/am57xx_hs_evm_defconfig | 1 - configs/k2g_evm_defconfig | 1 - configs/k2g_hs_evm_defconfig | 1 - 13 files changed, 13 deletions(-)Quoted 7 lines
So, a problem with this patch is that we can't only enable
CONFIG_BLKin all cases, we also need to make sure that if we have MMC we haveDM_MMCand if we have USB we haveDM_USB. This latter case is what tripped me up asam43xx_evm_usbhost_boot_defconfigwill have a warning with this patch applied asSPL_USB_SUPPORTreally requiresCONFIG_USB_STORAGEsupport and that in turn depends on either (BLK==n && DM_USB==n) or (BLK==y && DM_USB==y).
Quoted 7 lines
Maybe we should break this down.
1) k2g and am57: they already have the right options enabled.
2) am335x: the options are also present, although some are disabled in SPL
3) am43x: some configs need to be converted to
DM_USBandDM_MMCfirst.
Yes, submitting this as a 3 or 4 part change that goes per-SoC would be good, and clear that you're also changing a bit more on am43xx. Thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190125/33d61547/attachment.sig>
Hi,
Quoted 35 lines · Tom Rini
Quoted 34 lines · Jean-Jacques Hiblot
Quoted 22 lines · Tom Rini
Quoted 5 lines · Faiz Abbas
With DM conversion completed, enable
CONFIG_BLKfor a few pending TI boards.Signed-off-by Faiz Abbas <[email protected]>Reviewed-by Lokesh Vutla <[email protected]>Quoted 15 lines
--- configs/am335x_boneblack_vboot_defconfig | 1 - configs/am335x_evm_defconfig | 1 - configs/am335x_hs_evm_defconfig | 1 - configs/am335x_hs_evm_uart_defconfig | 1 - configs/am43xx_evm_defconfig | 1 - configs/am43xx_evm_qspiboot_defconfig | 1 - configs/am43xx_evm_rtconly_defconfig | 1 - configs/am43xx_evm_usbhost_boot_defconfig | 1 - configs/am43xx_hs_evm_defconfig | 1 - configs/am57xx_evm_defconfig | 1 - configs/am57xx_hs_evm_defconfig | 1 - configs/k2g_evm_defconfig | 1 - configs/k2g_hs_evm_defconfig | 1 - 13 files changed, 13 deletions(-)Quoted 7 lines
So, a problem with this patch is that we can't only enable
CONFIG_BLKin all cases, we also need to make sure that if we have MMC we haveDM_MMCand if we have USB we haveDM_USB. This latter case is what tripped me up asam43xx_evm_usbhost_boot_defconfigwill have a warning with this patch applied asSPL_USB_SUPPORTreally requiresCONFIG_USB_STORAGEsupport and that in turn depends on either (BLK==n && DM_USB==n) or (BLK==y && DM_USB==y).Maybe we should break this down.
Quoted 9 lines
Quoted 5 lines
1) k2g and am57: they already have the right options enabled.
2) am335x: the options are also present, although some are disabled in SPL
3) am43x: some configs need to be converted to
DM_USBandDM_MMCfirst.Yes, submitting this as a 3 or 4 part change that goes per-SoC would be good, and clear that you're also changing a bit more on am43xx. Thanks!
Sounds good. Will post a patch for each defconfig.
Thanks,
Faiz